From patchwork Tue Feb 2 16:32:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benson Leung X-Patchwork-Id: 374934 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0E8C43381 for ; Tue, 2 Feb 2021 16:39:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D0AD64F76 for ; Tue, 2 Feb 2021 16:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236702AbhBBQjF (ORCPT ); Tue, 2 Feb 2021 11:39:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236396AbhBBQgc (ORCPT ); Tue, 2 Feb 2021 11:36:32 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 954DCC0612F2 for ; Tue, 2 Feb 2021 08:33:07 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id w14so14699200pfi.2 for ; Tue, 02 Feb 2021 08:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eAEmX4T0SFhCX900Vx4u0Ymo1oePmn//2Jt6pbrxJRM=; b=P4NrsAe6VNaTkp+kWO5WECdGg5XEKewsuFO7JZUNV6F7jEkq0C/9vP23BBB57HoGAx vbB6CjOlwF3ataZYUKLSpnvjkLD/+6VtqdoOK+nlXrbOLVNvLXUhECvB90dBJBO//Z2b h3MYWqBXNHbMBnWqnPLAvPbUJW7dq4N6KPS9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eAEmX4T0SFhCX900Vx4u0Ymo1oePmn//2Jt6pbrxJRM=; b=n2DIZhb0pKTAxZg548vAQXIDBfNoNjc7Vom/uyPYIPu2XeR/C2K9icRocFdpZF3Mq2 xaW76Yfn1RNy0PMtoUk9J9gxTPy2tdRqkCRhLs3I4qwq87HU3w3UkcPzsBIOr9YyLFB2 ngbPTBRrHMj6n3PYUqjDVTXjoLs0Hvv5Fv/KVYGlh/9ls4AfwDqRPU6CB58IM8Kg7isj 3X/ORONnCX6GJW1T3FM54g3MIXgqaJGYqZDmgtOHCgXg5lQPGP7nBRIZcrlQXTISz3Dn 36exHLQ+pR6enJvDBCpXsftR46avjsscbFqzMbQ2xl9qsV+ZOYL3u1r6ZENgUyvc8hqJ 8lsA== X-Gm-Message-State: AOAM533+JOGuuDEdul71l6pCrkToA0Ajwxb0/ccqzhkZ8df7O9stWTcv zlLlik8QGQdwFmT4+8PT7+wcGw== X-Google-Smtp-Source: ABdhPJx7beim7GgN+Jw1TKGiM6BGWFthksNDqUSEVQjVdn+wX6KKt4N6o+LMbQF8+5fuM+xj+r0yJQ== X-Received: by 2002:a63:5b43:: with SMTP id l3mr22400040pgm.369.1612283586702; Tue, 02 Feb 2021 08:33:06 -0800 (PST) Received: from bleung.mtv.corp.google.com ([2620:15c:202:201:f693:9fff:fef4:fc72]) by smtp.gmail.com with ESMTPSA id i7sm22362511pfc.50.2021.02.02.08.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 08:33:05 -0800 (PST) From: Benson Leung To: heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com, pmalani@chromium.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kyletso@google.com, bleung@google.com, bleung@chromium.org Subject: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision Date: Tue, 2 Feb 2021 08:32:48 -0800 Message-Id: <20210202163248.3981555-1-bleung@chromium.org> X-Mailer: git-send-email 2.30.0.365.g02bc693789-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org typec_partner_set_pd_revision returns void now. Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision from status Signed-off-by: Benson Leung --- drivers/platform/chrome/cros_ec_typec.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index a7778258d0a0..7b93dfd02999 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -842,11 +842,7 @@ static int cros_typec_handle_sop_disc(struct cros_typec_data *typec, int port_nu goto disc_exit; } - ret = typec_partner_set_pd_revision(port->partner, pd_revision); - if (ret < 0) { - dev_err(typec->dev, "Failed to update partner PD revision, port: %d\n", port_num); - goto disc_exit; - } + typec_partner_set_pd_revision(port->partner, pd_revision); memset(sop_disc, 0, EC_PROTO2_MAX_RESPONSE_SIZE); ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_DISCOVERY, &req, sizeof(req),