From patchwork Mon Jul 6 13:33:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 234852 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp4779585ilg; Mon, 6 Jul 2020 06:34:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyj+4gFrN6Dstaxnw3EJSaFUGyaxEMxJdR9PaGC/19O8g4XlG69yJbZgyjqVePzOiWySWvI X-Received: by 2002:aa7:db53:: with SMTP id n19mr26651231edt.338.1594042458476; Mon, 06 Jul 2020 06:34:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594042458; cv=none; d=google.com; s=arc-20160816; b=wXVnh7p4KbkFLrdLrDj9N2X7R+AummBQ9H8NzxkJlWXzPmHHH9MwAsfQ6Q6CXhhVDd FFiaeBTfclaLt+zXLKCprSlL/vAx23HCLpRbk3xYZyYVk0DpsFHmdcOVu8lI0KdaXAAH Lze9JvWl0uU+EbVInJyiBLUDQ78S0Fllsz46n3OSiVFKJ2k4bzEj0gLSom9fgzNQDL2B fCN89FdmaDqcBxS4bDf6jBexTRNAlOjnG3cPQSKooGmZ9Hw1zLcxd1U3fyBKNtb/xJOU aB2LXfveZuCua9Ip1hcgvAIYtrlEdbS1Q87uoJpS/ZeZ2VuW/STZsIIPeN7WIYWOqIAL 01fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tuuvgBdpWU3P+bBrTu/2KsiGO4ss74gkTJhNI/l0mkY=; b=Xwo/T7hwBXQ/vu6c/BYOGkojDzwJ56jfZdTMSDWd6+ZD2NaufvYG/Jm/jVanYVodYh BOsMMn3VdfZa+YiZmdSq4D4cwCu3K80Fk6o98TnFdwUlZSMQy82vrurgptIV7YSwniOG mgAIOJlK/PsDSFIdKKWuXULdaq9A3caK/1VvzNFmWR71xJgPJ8lMhiPYuguqPs9Gg1E0 8mdgKFoob8Rgo5FV89oc0+QnJCP3jgqQtSQdkejOXF5MPVNFzdcnU83Ax36uJUnsI9z5 NNO6wxmgZNs36KPdpq7dI5FVomqrkEg2/bVQFW1rtCYXXetZ/Sm6oNu3Y8/OC0B/oEPn cXvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tDxm68x6; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id uz6si12423914ejb.50.2020.07.06.06.34.18; Mon, 06 Jul 2020 06:34:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tDxm68x6; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729204AbgGFNeR (ORCPT + 5 others); Mon, 6 Jul 2020 09:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729354AbgGFNeQ (ORCPT ); Mon, 6 Jul 2020 09:34:16 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB7EC061794 for ; Mon, 6 Jul 2020 06:34:15 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l2so40630820wmf.0 for ; Mon, 06 Jul 2020 06:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tuuvgBdpWU3P+bBrTu/2KsiGO4ss74gkTJhNI/l0mkY=; b=tDxm68x6EEuzSyF8zb1P7MNnLA1RLSLV7ALNXgP2jbhLbdEirodV/LE4bXzaJbsPRg SUs25JhonwmI4Zqrwaw4zG1N8CYo4lAXlnF26lpK/OFRkQCBCsW93WEi1lCMj5UWQUmj QMnuck2Ci0chN7EEaR5qWLPh9Nag2b7j1MCcb9/mrCXgV+WBZ7ijQZzXPdT8Hjg0PTNS goxdYPMOU0X2sc2aE1VXEpQk/0hLVxQjbMvmUCXhN28efa29/LuSc8kkdAhJT0CG2LUK rVz1fvRtUKDbzGwTdNfqJrgIE5j/IDqenQl2BErSZqG2pPSnQFEsUwi3TsrnXUWaGjxc gQXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tuuvgBdpWU3P+bBrTu/2KsiGO4ss74gkTJhNI/l0mkY=; b=jdRt0SXtbxxxi5a+nWNt5eKHNNlYBfsq0aGX4F9cnWZ60K1C4gBKnmLeU43tKVywaC EjZvUQ5XhSZNvUp8mfOKLEBNCMT1yctHhjpd2Vpd2gj6wQC7T5lPLwueK1xOUydPdHYT 222B/MwAAqbcytllClnu8FYiJxtnt3SsTS1dBhkov6mQr5h/5UVFJIrdh81I/mMP4KZr nDW7nBNXlVajsDRAFOcTDkbc5/glnUIacJqlwkR3DkjYAuFE3OmVPgj0QO8f+TjdirRr /GRqN/UmSy+neEDnzQ7IBzR4Ii4ruAlOm9P5TI+9q1omPbqUQEdzbOBVvJgYJ4ys65WQ AD2A== X-Gm-Message-State: AOAM530ebmRGEAJ4l4Siagl0DZ7OhTHJ5gADPxMyn0sWrCZtfAQKZsIW yJ8MZX0y04wTfNovnO7RX1UH0Q== X-Received: by 2002:a1c:49d4:: with SMTP id w203mr50012638wma.13.1594042454380; Mon, 06 Jul 2020 06:34:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:13 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Sumit Garg , Daniel Thompson , Douglas Anderson , Petr Mladek , "Eric W. Biederman" , Yinghai Lu , Jason Wessel Subject: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Date: Mon, 6 Jul 2020 14:33:34 +0100 Message-Id: <20200706133341.476881-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org 'ret' hasn't been checked since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 915 | int chunk, ret; | ^~~ Cc: Sumit Garg Cc: Daniel Thompson Cc: Douglas Anderson Cc: Petr Mladek Cc: "Eric W. Biederman" Cc: Yinghai Lu Cc: Jason Wessel Signed-off-by: Lee Jones --- drivers/usb/early/ehci-dbgp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 Acked-by: "Eric W. Biederman" diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c index 775cf70cfb3ed..b075dbfad730f 100644 --- a/drivers/usb/early/ehci-dbgp.c +++ b/drivers/usb/early/ehci-dbgp.c @@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s) static void early_dbgp_write(struct console *con, const char *str, u32 n) { - int chunk, ret; + int chunk; char buf[DBGP_MAX_PACKET]; int use_cr = 0; u32 cmd, ctrl; @@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n) buf[chunk] = *str; } if (chunk > 0) { - ret = dbgp_bulk_write(USB_DEBUG_DEVNUM, - dbgp_endpoint_out, buf, chunk); + dbgp_bulk_write(USB_DEBUG_DEVNUM, + dbgp_endpoint_out, buf, chunk); } } if (unlikely(reset_run)) {