From patchwork Mon Jul 6 13:33:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 234869 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp4781148ilg; Mon, 6 Jul 2020 06:36:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRFelZ6T6jmp3dkGTisCjdLzFs2tsvZpkYLU1VHIHTIY5EKPxQbWZyqeOKvdl50+9sDRhc X-Received: by 2002:a17:907:7283:: with SMTP id dt3mr44849649ejc.195.1594042559869; Mon, 06 Jul 2020 06:35:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594042559; cv=none; d=google.com; s=arc-20160816; b=Vh+Ept+qoS5aLbwdaIrs2SgqpmvTLLBAH9k7e/nQjyoJc7KCciTIKygIzN2HzL5p6z rDStxpQ9G2Tt6YbHskbAv8FLw5SNFPP1bnVACTxjgeTlJimmkha+0YuY1jetSXhPNcY/ +OblY3Hpfa/YIlJ3kkAIq4Kks8FOfElg0/vq/b1b+FbhD6TrtNUPGlHqkSJuNggEH9/e kt96j/Ni/aK9oZ8MHc/aG1T0Q5goyqn64n07Q6YxuN+Q/mMe0h2E1jXliDu+rbyS9vhl 6bA7qKnW29XZWkzlNKUphXwoJdzhZ8fHcyhm8BR8WSeb6vy/eyIMK2891XCtJ1n8Bnbi 8vKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=UtwO/XiUf1wqTyIisfVTQ7mrbFYyCCaL09Z13iwpP8Yk/Ctzq37IQ8/Vv86MPNpqxp G9yl+4AzCm16h20Q7J4Tsf/wChRC+GSSRPlvaOux8wILzL1rUJqLG1g2P0l4K8hBDxTM XChalaBDH7AzKOXykCXBBBqDIsZOFRH6K19wIHF5A7R4CbI5MV5iQ69AEAZlvUDQCLkw V9/IMaq0M/tyTL4juc6NDthIx9juFoNhYEMBusKmh137Mn4RXRLNvkab7Y/JEE+CSxNN +cV7Ix87gX7YbkEOcgrZmuhIY2/Vns+WFW9YabfgjEesXBE7ndSrHgaYfNBS4jiA+suU MIOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OmZFfKsZ; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si13297954edr.292.2020.07.06.06.35.59; Mon, 06 Jul 2020 06:35:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OmZFfKsZ; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729538AbgGFNfs (ORCPT + 5 others); Mon, 6 Jul 2020 09:35:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729302AbgGFNeB (ORCPT ); Mon, 6 Jul 2020 09:34:01 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60021C061755 for ; Mon, 6 Jul 2020 06:34:01 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o2so42118722wmh.2 for ; Mon, 06 Jul 2020 06:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=OmZFfKsZE3nw2Rx7QazBJNlNeA+U8z1Z2PcNhcqjoK68z1sVetkUL2vJdCbMgfCx+z GQ5OdTbXa+xGGweQRAIjQY+yIMbO16Ik2oUI+cRDjkln/G96vTY+Sv3Hmg9wjeMj9Moe wjup2WRBceFy+RvHDn6sGC88K+miXgtBtFdiQiKW7ax7JwncaSGkDlPgFdll46+6/YiB c2Hvox1thv7IHBF2cFtkUXRSO0tVbQdaKgKzefw5AxbQcMOI86AnSy5xCXNu/8SdAEfj tMQN++j0iRkOEy/9hGk3KCKGViLlrFbGp+lhcUlgAE3JBu5bqpBfe9atSyQizMIJsTA+ txEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=mTiS31Z0d69Bt5WZvVKcHcE5hi1ITgtO2GVSwv1y2TBNQOCNlIS4uD+Mkimy2U7Qck 8cbbSuEUrwlqbwQLvX0GNGu+AymWOPHeEZJYyZ0MKIyh7c0EuUMwv2cYa+E1hLHGPL2D H9dpRPkDxfmYIB6naOKqwDoITkfpkI/AZoppSp5ALOjQheassrlG7XmFl/A0M6TjwRuA ASN0kd6j/nOuSulc6v7b4aI7O7FXh4PyGsxNTbyyjdvClgkLbPbxBUCMFXqJTtgoKvLZ mKJDX+A0RGLQ3oqrOFroyEs+zHjcJMMAlrsJVjhBJDda2+QYPDJBg2O5ZKBYaCwkR1c+ uQZw== X-Gm-Message-State: AOAM533C/O/yAD24fpcMjZes6aL0gNZ71BG9qHJy0GJM3R+FUOCkWHpB S4oh5AJjPT4Mmx05tB9yFkKKZw== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr2416268wmh.121.1594042440115; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Yoshihiro Shimoda Subject: [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Date: Mon, 6 Jul 2020 14:33:22 +0100 Message-Id: <20200706133341.476881-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks like it's been this way since the driver's inception in 2007. Fixes the following W=1 kernel build warning(s): drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’: drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] 478 | u16 tmp; | ^~~ Cc: Yoshihiro Shimoda Signed-off-by: Lee Jones --- drivers/usb/host/r8a66597-hcd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) -- 2.25.1 diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index 0c03ac6b02137..63719cdf6a4e6 100644 --- a/drivers/usb/host/r8a66597-hcd.c +++ b/drivers/usb/host/r8a66597-hcd.c @@ -475,16 +475,14 @@ static void pipe_stop(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) static void clear_all_buffer(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) { - u16 tmp; - if (!pipe || pipe->info.pipenum == 0) return; pipe_stop(r8a66597, pipe); r8a66597_bset(r8a66597, ACLRM, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); r8a66597_bclr(r8a66597, ACLRM, pipe->pipectr); }