From patchwork Thu Jul 2 14:46:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192268 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1511941ilg; Thu, 2 Jul 2020 07:49:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9axS7aT0tQI/bwyu4B5KifBtwjz9xC/0ntzNmpurQgoN2asufA0CtP840PWsRW0q7BtLu X-Received: by 2002:a17:906:d8db:: with SMTP id re27mr27358562ejb.554.1593701368993; Thu, 02 Jul 2020 07:49:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593701368; cv=none; d=google.com; s=arc-20160816; b=RYpJW1aY/mg2HP1i7xDLWbB10O6lmx5TOQCZqtO2/gwhB9ugWuSEMEjlP5dLgR52bS 9FjpQexWpfU07lqanZaBYU/ncsdxXQLedfnwHr7w8ldBwm/XDaSHoa2f8z16Im0ZBm/R kNWTrhjxTFEsfmnQGH4AEcRMSSElNMWeG9d8xreRVivJQQqcVAhVJ3ZdyWWPg7CdZuBU tlFTRUAoVn+ugSt7s900IHXVOlYQkXGulKwSSeQTGusariVHsxGX+ncgthJy/pRZdBLU lfuSwm2fLpWapwAUnuFe4CxBdHDg2AN1T3HkY+GUPqw3UZRT5oT4rUEF/uml6Jvdu8uS OPoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=OI0BVl2PWnMZ5pRCkDank+zXeRaG1Mp9o+5IE1rZvNmRLDUbGEybQdqZf0SjFb6hJZ dd/gHPdPe9jcWX9UMaw1N3nMhcfpcsQ3lTg3jVMiinYH5XJwx1XCwAqmZ0TFIVd+Fjic wI1WAtQ+Usc17UBquen4bUIzAny2X4yjsHm8Z2/IYLcyuM6/c0l1LlHRXJWSStFlx5ta 1GSHB1ALs3tyoF7q2h/h2aEeA+Pv2EUycE3dVGTR4MHIyLhW3zP6DVugcEDcD0QFFWdG 2ueb0ayXs41d5WRb6Y0g7HypRMTQAzmes+B3PV/uy1Y/IzSgAGJa+aSJKBzDMvbek4Za gLAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yIWlMjN0; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n14si5692504ejs.745.2020.07.02.07.49.28; Thu, 02 Jul 2020 07:49:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yIWlMjN0; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730308AbgGBOtV (ORCPT + 5 others); Thu, 2 Jul 2020 10:49:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729959AbgGBOqm (ORCPT ); Thu, 2 Jul 2020 10:46:42 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F85BC08C5DD for ; Thu, 2 Jul 2020 07:46:42 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f18so20722318wrs.0 for ; Thu, 02 Jul 2020 07:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=yIWlMjN0w19WzloUJb27YHxd5Lv2apKTHNCXpZAD+f82IlZ3PHXnJHPuKhqY0rS81s QhZs+X6iPjFvByqqq7pbk0L53rMGDtKW5FxzOziYz6xeaR8f5G/QXdzGL/5bqnDtJiPL sNH3X1dLCSubDr7yM/FA9k24CATuCeAh/iLiL1cX5ux7S1E0GMK8QS8Bt+apIPUWr5vd SZ57qUbVbp6Y3pFbnr8TEYhdSOdESv+8q7JOp726Q0hQtCOeKBHPSPTEt5Msd4ErPqsN BjNbMI2tqHASmGNzXbMyPz2SSAoKQWZklBkBhEeDGBIYuaaXABebQIPiWIan83aqDdb/ Ufrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=CqOeiuNnwCkg6/eTFW57kCNbI6TWTukN3bZFVkcJx8gmq1YAoODs+dH1sxJ+3n3mHd I9WKI1dIZgSPsMk29Nn3BOmc2be7hpXnw11BSJs8DH924BkXCH15lg0iKMyW1cztpIxv ZHWwuF+rOjXINlTW2mjbHJ2F3ccXPdFIzIwelrCmYh29LPKjCOWpF8dd39TptCtdTspV BlJc8YZXy2CSeG2O1DSqVQzqUYXNTJqZQncpcEiXEYRqYJkNXrjTonm+RNRQiezSObTy 91RFJvDU1dIEUKQcjv4H1wo32jutE52EYuBNO8KX5/iaMg6NDvEpZQrB8nDSGps0WQOj 9BZQ== X-Gm-Message-State: AOAM531/urwPWHpBZA56EzzQOZuradY9dIAwBRoEujzq2I7r5qXuQa0R CTC8AKlCA4QHUaVzumKLtCRvZA== X-Received: by 2002:a5d:44c7:: with SMTP id z7mr34212570wrr.226.1593701201196; Thu, 02 Jul 2020 07:46:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:40 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Heikki Krogerus Subject: [PATCH 07/30] usb: common: ulpi: Fix a few kerneldoc related issues Date: Thu, 2 Jul 2020 15:46:02 +0100 Message-Id: <20200702144625.2533530-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Firstly, demote function header to standard comment block as they are not suitable for kerneldoc. Then provide description for ulpi_register_driver()'s argument 'module'. Finally rename description for ulpi_unregister_interface()'s 'ulpi' arg. Fixes the following W=1 warnings: drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'ulpi' not described in 'ulpi_read' drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'addr' not described in 'ulpi_read' drivers/usb/common/ulpi.c:150: warning: Function parameter or member 'module' not described in '__ulpi_register_driver' drivers/usb/common/ulpi.c:299: warning: Function parameter or member 'ulpi' not described in 'ulpi_unregister_interface' drivers/usb/common/ulpi.c:299: warning: Excess function parameter 'intrf' description in 'ulpi_unregister_interface' Cc: Felipe Balbi Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/common/ulpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 9a2ab6751a23c..a18d7c4222ddf 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * ulpi.c - USB ULPI PHY bus * * Copyright (C) 2015 Intel Corporation @@ -143,6 +143,7 @@ static const struct device_type ulpi_dev_type = { /** * ulpi_register_driver - register a driver with the ULPI bus * @drv: driver being registered + * @module: ends up being THIS_MODULE * * Registers a driver with the ULPI bus. */ @@ -290,7 +291,7 @@ EXPORT_SYMBOL_GPL(ulpi_register_interface); /** * ulpi_unregister_interface - unregister ULPI interface - * @intrf: struct ulpi_interface + * @ulpi: struct ulpi_interface * * Unregisters a ULPI device and it's interface that was created with * ulpi_create_interface().