From patchwork Thu Jul 7 22:21:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 71641 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp126789qgy; Thu, 7 Jul 2016 15:23:53 -0700 (PDT) X-Received: by 10.66.218.234 with SMTP id pj10mr4189413pac.81.1467930225700; Thu, 07 Jul 2016 15:23:45 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si327151pfw.171.2016.07.07.15.23.45; Thu, 07 Jul 2016 15:23:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932452AbcGGWX2 (ORCPT + 5 others); Thu, 7 Jul 2016 18:23:28 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35108 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbcGGWVi (ORCPT ); Thu, 7 Jul 2016 18:21:38 -0400 Received: by mail-pa0-f42.google.com with SMTP id dx3so9522883pab.2 for ; Thu, 07 Jul 2016 15:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XMlwgRKfa9b5rDN0l0bSBaQXIHXQvpOK7c7qjHHLFdM=; b=PbLBG3X4PrY7BTmfkTk3v8f0JsQfJDdhxTaBKbGeXc2OTz3o2qSfGlSlM250HdVkSy x4zxbEQfl1AwtEGJ0yVIfibR4t/oQJkecPE5JlhK969opvfTR9Ctv1jtM7/kM85wqTUe +d7yfYkGPPgqE+tc1kCQgrA1YVwOivRc8n8ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XMlwgRKfa9b5rDN0l0bSBaQXIHXQvpOK7c7qjHHLFdM=; b=I/4p80kcEwb12whCI1NS1OuWbii1RgvcjvaVj8kKGTC66hvJbbTxBDFr1dx935fXGs 5wke6TRlsme8pK0qPKUu+lTJ01/TSHMdiwNp22KgSX0MI2eYsdCtBm2Dtug1f60vDM3F 471cHL3SaZrXHcJxlkx3SBYy+SH7JKyQPM74etMcFEv72HpSmmQ+d78xL5ontFCt5pZ5 mQHFsdrBCCRr0eZm6E+5U7LJuVudad/uts2f6DfOYKbyStbirflSQua+T3T4xk/87EwW h93SE5coGF4WMPhxDlNbix7GaxHm/HNUngcxiV86G78QIpmQsZiZIQYGyRinteskdU3l LgNQ== X-Gm-Message-State: ALyK8tLPk2YWdmhMPSNHagbQQtdBkh22ELaebWVR18Y3uiovpseqyfCPcGP76Ip5HnvldYVh X-Received: by 10.66.62.226 with SMTP id b2mr4200661pas.119.1467930097969; Thu, 07 Jul 2016 15:21:37 -0700 (PDT) Received: from localhost.localdomain (ip68-101-172-78.sd.sd.cox.net. [68.101.172.78]) by smtp.gmail.com with ESMTPSA id j8sm6781807paj.22.2016.07.07.15.21.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Jul 2016 15:21:37 -0700 (PDT) From: Stephen Boyd To: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Greg Kroah-Hartman Subject: [PATCH v2 13/22] usb: chipidea: msm: Use hw_write_id_reg() instead of writel Date: Thu, 7 Jul 2016 15:21:04 -0700 Message-Id: <20160707222114.1673-14-stephen.boyd@linaro.org> X-Mailer: git-send-email 2.9.0.rc2.8.ga28705d In-Reply-To: <20160707222114.1673-1-stephen.boyd@linaro.org> References: <20160707222114.1673-1-stephen.boyd@linaro.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The MSM_USB_BASE macro trick is not very clear, and we're using it for only one register write so let's just move to using hw_write_id_reg() and passing the ci pointer instead. That clearly shows what offset we're using and avoids needing to include the msm_hsusb_hw.h file when we're going to delete that file soon. Acked-by: Peter Chen Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- drivers/usb/chipidea/ci_hdrc_msm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.9.0.rc2.8.ga28705d -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 719b20caf88e..b282a717bf8c 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -8,14 +8,12 @@ #include #include #include -#include -#include #include #include #include "ci.h" -#define MSM_USB_BASE (ci->hw_bank.abs) +#define HS_PHY_AHB_MODE 0x0098 static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) { @@ -25,7 +23,7 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) case CI_HDRC_CONTROLLER_RESET_EVENT: dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n"); /* use AHB transactor, allow posted data writes */ - writel(0x8, USB_AHBMODE); + hw_write_id_reg(ci, HS_PHY_AHB_MODE, 0xffffffff, 0x8); usb_phy_init(ci->usb_phy); break; case CI_HDRC_CONTROLLER_STOPPED_EVENT: