From patchwork Mon May 5 15:30:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 29651 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f199.google.com (mail-qc0-f199.google.com [209.85.216.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 60F3A202E6 for ; Mon, 5 May 2014 15:30:49 +0000 (UTC) Received: by mail-qc0-f199.google.com with SMTP id i17sf16922475qcy.6 for ; Mon, 05 May 2014 08:30:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=XBGFI18lRx5OWEW0hMbyjmCZZsjyPHNRpmxDrRZagZ8=; b=LsXyLyxp97BrtCew2VlVx/TiMB9lHJSDdOunFJXLIPZIhfCl0UYFn4xTV+JKCdFwpw gJ1442pgmnOiJx72BQ4tQJMHrGHa17SaLHnIZCUI2H45nThnc4r+n1azrSQdZmaKMOgH 19Bev+8BBMATjbY0VcRpvW6ZRL9U64yxpe9jrnmLYjML21pswQgiVfITfXpVU+bMlC6x vmEWjlQ2AvlsCYfJ6GMLmOlXTDG4Dafg5SqaCiIUAFwZ/bnZxGb7sMKwDz1v7JK+/7FQ U8foOwfZSBQcfd6Sug2sEq/amStTlTl9cjeTrq7KWZafruSeQeDw0chMFTkbGuZyd6aH Lq0Q== X-Gm-Message-State: ALoCoQlfdb/dH7KUJ8piZJtUVtoZ8lbzmAjVK8F9naiwrRvK1ybk67/7zVUnGsCgVq2ioglkXL0W X-Received: by 10.58.94.163 with SMTP id dd3mr4284981veb.29.1399303849168; Mon, 05 May 2014 08:30:49 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.50.81 with SMTP id r75ls2469690qga.71.gmail; Mon, 05 May 2014 08:30:48 -0700 (PDT) X-Received: by 10.52.119.178 with SMTP id kv18mr1357248vdb.39.1399303848799; Mon, 05 May 2014 08:30:48 -0700 (PDT) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx.google.com with ESMTPS id sw4si1657292vdc.174.2014.05.05.08.30.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 05 May 2014 08:30:48 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.128.179; Received: by mail-ve0-f179.google.com with SMTP id oy12so5884623veb.38 for ; Mon, 05 May 2014 08:30:48 -0700 (PDT) X-Received: by 10.52.72.138 with SMTP id d10mr19728840vdv.15.1399303848719; Mon, 05 May 2014 08:30:48 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp149272vcb; Mon, 5 May 2014 08:30:47 -0700 (PDT) X-Received: by 10.43.140.144 with SMTP id ja16mr34418716icc.46.1399303847508; Mon, 05 May 2014 08:30:47 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si13044369igr.51.2014.05.05.08.30.47; Mon, 05 May 2014 08:30:47 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752621AbaEEPap (ORCPT + 3 others); Mon, 5 May 2014 11:30:45 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:55564 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbaEEPao (ORCPT ); Mon, 5 May 2014 11:30:44 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s45FUcTo017692; Mon, 5 May 2014 10:30:38 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s45FUbiJ011036; Mon, 5 May 2014 10:30:37 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Mon, 5 May 2014 10:30:37 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s45FUa5g009621; Mon, 5 May 2014 10:30:37 -0500 Date: Mon, 5 May 2014 10:30:33 -0500 From: Felipe Balbi To: Felipe Balbi CC: "Ivan T. Ivanov" , , , Linux USB Mailing List Subject: Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int Message-ID: <20140505153033.GB17875@saruman.home> Reply-To: References: <1398875916-14461-1-git-send-email-balbi@ti.com> <1399100192.7131.2.camel@violet> <20140505150331.GA17875@saruman.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140505150331.GA17875@saruman.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Mon, May 05, 2014 at 10:03:31AM -0500, Felipe Balbi wrote: > On Sat, May 03, 2014 at 09:56:32AM +0300, Ivan T. Ivanov wrote: > > On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote: > > > this solves the following build warning found when > > > running compile tests. > > > > > > drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’: > > > drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \ > > > to integer of different size [-Wpointer-to-int-cast] > > > pdata->phy_type = (int) id->data; > > > ^ > > > Signed-off-by: Felipe Balbi > > > --- > > > > > > all patches are on top of Ivan's 20 patch series. > > > > > > drivers/usb/phy/phy-msm-usb.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c > > > index 9dc7918..c9963c8 100644 > > > --- a/drivers/usb/phy/phy-msm-usb.c > > > +++ b/drivers/usb/phy/phy-msm-usb.c > > > @@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg) > > > motg->pdata = pdata; > > > > > > id = of_match_device(msm_otg_dt_match, &pdev->dev); > > > - pdata->phy_type = (int) id->data; > > > + pdata->phy_type = (unsigned long int) id->data; > > > > Probably cast to enum msm_usb_phy_type will be better. > > will do. commit fe8ef54c824e5b01192462ef82861e65f57d299c Author: Felipe Balbi Date: Wed Apr 30 11:33:04 2014 -0500 usb: phy: msm: cast to unsigned long int this solves the following build warning found when running compile tests. drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’: drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \ to integer of different size [-Wpointer-to-int-cast] pdata->phy_type = (int) id->data; ^ Signed-off-by: Felipe Balbi diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 9dc7918..591b406 100644 --- a/drivers/usb/phy/phy-msm-usb.c +++ b/drivers/usb/phy/phy-msm-usb.c @@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg) motg->pdata = pdata; id = of_match_device(msm_otg_dt_match, &pdev->dev); - pdata->phy_type = (int) id->data; + pdata->phy_type = (enum msm_usb_phy_type) id->data; motg->link_rst = devm_reset_control_get(&pdev->dev, "link"); if (IS_ERR(motg->link_rst))