From patchwork Wed Jul 27 08:43:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Guo X-Patchwork-Id: 594489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8BFFC04A68 for ; Wed, 27 Jul 2022 08:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbiG0Inp (ORCPT ); Wed, 27 Jul 2022 04:43:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbiG0Ino (ORCPT ); Wed, 27 Jul 2022 04:43:44 -0400 Received: from unicom146.biz-email.net (unicom146.biz-email.net [210.51.26.146]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07E9C45F45; Wed, 27 Jul 2022 01:43:40 -0700 (PDT) Received: from ([60.208.111.195]) by unicom146.biz-email.net ((D)) with ASMTP (SSL) id WHT00133; Wed, 27 Jul 2022 16:43:33 +0800 Received: from Jtjnmail201613.home.langchao.com (10.100.2.13) by Jtjnmail201617.home.langchao.com (10.100.2.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Wed, 27 Jul 2022 16:43:34 +0800 Received: from Jtjnmail201613.home.langchao.com ([fe80::b8bf:393:bebe:1197]) by Jtjnmail201613.home.langchao.com ([fe80::b8bf:393:bebe:1197%12]) with mapi id 15.01.2507.009; Wed, 27 Jul 2022 16:43:34 +0800 From: =?eucgb2312_cn?b?QW5keSBHdW8gKLn5zsCx8yk=?= To: "b-liu@ti.com" , "gregkh@linuxfoundation.org" CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , =?eucgb2312_cn?b?QW5keSBHdW8gKLn5zsCx8yk=?= Subject: [PATCH v2] usb: musb: Fix musb_gadget.c rxstate may cause request->buf overflow problems Thread-Topic: [PATCH v2] usb: musb: Fix musb_gadget.c rxstate may cause request->buf overflow problems Thread-Index: AdihlK58/c/eW9hwTTW0SyWnHPS6PQ== Date: Wed, 27 Jul 2022 08:43:34 +0000 Message-ID: <200f38d3e3eb44ec8ec8f8e9f210f131@inspur.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.180.162.69] MIME-Version: 1.0 tUid: 20227271643336f712e09a47c5a0103143d9517a653c2 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: guoweibin when the rxstate function executes the 'goto buffer_aint_mapped' code branch, it will always copy the fifocnt bytes data to request->buf, which may cause request->buf out of bounds. for Ethernet-over-USB will cause skb_over_panic when a packet larger than mtu is recived. Fix it by add the length check : fifocnt = min_t(unsigned, request->length - request->actual, fifocnt); Signed-off-by: guoweibin --- v2: -fix format error drivers/usb/musb/musb_gadget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 51274b87f46c..4ad5a1f31d7e 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/drivers/usb/musb/musb_gadget.c @@ -760,6 +760,7 @@ static void rxstate(struct musb *musb, struct musb_request *req) musb_writew(epio, MUSB_RXCSR, csr); buffer_aint_mapped: + fifo_count = min_t(unsigned, request->length - request->actual, fifo_count); musb_read_fifo(musb_ep->hw_ep, fifo_count, (u8 *) (request->buf + request->actual)); request->actual += fifo_count;