| Message ID | 1616482975-17841-1-git-send-email-chunfeng.yun@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,01/13] dt-bindings: usb: mtk-xhci: support property usb2-lpm-disable | expand |
Hello! On 23.03.2021 10:02, Chunfeng Yun wrote: > Add support common property usb2-lpm-disable ^ for > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> [...] MBR, Sergei
On Tue, Mar 23, 2021 at 03:02:43PM +0800, Chunfeng Yun wrote: > Add support common property usb2-lpm-disable > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v2: no changes > --- > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > index 14f40efb3b22..2246d29a5e4e 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > @@ -103,6 +103,10 @@ properties: > description: supports USB3.0 LPM > type: boolean > > + usb2-lpm-disable: > + description: disable USB2 HW LPM > + type: boolean Already has a type. Don't redefine here. Just 'usb2-lpm-disable: true' and make sure usb-xhci.yaml is referenced. > + > imod-interval-ns: > description: > Interrupt moderation interval value, it is 8 times as much as that > -- > 2.18.0 >
On Tue, 23 Mar 2021 15:02:44 +0800, Chunfeng Yun wrote: > These two HW of wakeup don't follow MediaTek internal IPM rule, > both use a specific way, like as early revision of mt8173. > > Due to the index 2 already used by many DTS, it's better to keep > it unchanged for backward compatibility, treat specific ones without > following IPM rule as revision 1.x, meanwhile reserve 3~99 for > later revisions with following the IPM rule. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v2: modify revision format > --- > .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, 23 Mar 2021 15:02:45 +0800, Chunfeng Yun wrote: > These two HW of wakeup don't follow MediaTek internal IPM rule, > and both use a specific way, like as early revision of mt8173. > > Due to the index 2 already used by many DTS, it's better to keep > it unchanged for backward compatibility, treat specific ones without > following IPM rule as revision 1.x, meanwhile reserve 3~99 for > later revision that following the IPM rule. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v2: modify revision format > --- > .../devicetree/bindings/usb/mediatek,mtu3.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sat, 2021-03-27 at 11:24 -0600, Rob Herring wrote: > On Tue, Mar 23, 2021 at 03:02:43PM +0800, Chunfeng Yun wrote: > > Add support common property usb2-lpm-disable > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > v2: no changes > > --- > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > > index 14f40efb3b22..2246d29a5e4e 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > > @@ -103,6 +103,10 @@ properties: > > description: supports USB3.0 LPM > > type: boolean > > > > + usb2-lpm-disable: > > + description: disable USB2 HW LPM > > + type: boolean > > Already has a type. Don't redefine here. Just 'usb2-lpm-disable: true' > and make sure usb-xhci.yaml is referenced. Ok, thanks > > > + > > imod-interval-ns: > > description: > > Interrupt moderation interval value, it is 8 times as much as that > > -- > > 2.18.0 > >
On 23/03/2021 08:02, Chunfeng Yun wrote: > Use wakeup control register offset exactly, and update revision > number > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v2: modify revision format > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 80519a145f13..9ea84d636556 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -874,7 +874,7 @@ > clocks = <&infracfg CLK_INFRA_UNIPRO_SCK>, > <&infracfg CLK_INFRA_USB>; > clock-names = "sys_ck", "ref_ck"; > - mediatek,syscon-wakeup = <&pericfg 0x400 0>; > + mediatek,syscon-wakeup = <&pericfg 0x420 101>; applied to v5.12-next/dts64 Thanks > #address-cells = <2>; > #size-cells = <2>; > ranges; >
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml index 14f40efb3b22..2246d29a5e4e 100644 --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml @@ -103,6 +103,10 @@ properties: description: supports USB3.0 LPM type: boolean + usb2-lpm-disable: + description: disable USB2 HW LPM + type: boolean + imod-interval-ns: description: Interrupt moderation interval value, it is 8 times as much as that
Add support common property usb2-lpm-disable Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v2: no changes --- Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 ++++ 1 file changed, 4 insertions(+)