From patchwork Mon Oct 12 19:24:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 54811 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by patches.linaro.org (Postfix) with ESMTPS id 6C2F023001 for ; Mon, 12 Oct 2015 19:25:03 +0000 (UTC) Received: by lbwr8 with SMTP id r8sf73879401lbw.0 for ; Mon, 12 Oct 2015 12:25:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:content-type:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=dJx9nhcHAqHH1bwnsBejj5Hff3K5E8VZvdDVlS06OKk=; b=aDkN+Tpy8J1e/uDuF1bB24Ry6b4/6b4JIcnDdSTm1tjTkjYkFJcDww8Ksxr5R20h5w fcPEl/n55va40H6f36i/cq106TMZ7/cqvbj7OlpPFpXMFMJ+ZWRi1qKPVtbOFhiKlNc5 X2xZ6WB6b7DQGffjA80xe49wMD/RykWeja1+XFb+GyCFKgXSvU2azR7a1enxmeGNIMBd cB4+oFcdUcNEl1VQ+qPfVt/8/K8TiUTjisiy3CkKTyUz3KNY5gvedB6lygnEgVLIttY2 d3GcZJBhZ7lH1J7xgJeIgMLfMvCN2uv1dswjYXrgjQ2ax6KTceLPuWWwcxvyRsKtG1nH GOnQ== X-Gm-Message-State: ALoCoQmqHW1Ox3/MD3Kilwj1kwLBxyeQ5JJlG8+j0Tj8d5Remw+Nv/iceVi5lcirqr0zV4RFW12f X-Received: by 10.180.10.135 with SMTP id i7mr3272249wib.2.1444677901763; Mon, 12 Oct 2015 12:25:01 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.29.148 with SMTP id d142ls515242lfd.27.gmail; Mon, 12 Oct 2015 12:25:01 -0700 (PDT) X-Received: by 10.112.200.202 with SMTP id ju10mr12834609lbc.97.1444677901580; Mon, 12 Oct 2015 12:25:01 -0700 (PDT) Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com. [209.85.217.179]) by mx.google.com with ESMTPS id k75si12316062lfg.19.2015.10.12.12.25.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 12:25:01 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) client-ip=209.85.217.179; Received: by lbbk10 with SMTP id k10so40762867lbb.0 for ; Mon, 12 Oct 2015 12:25:01 -0700 (PDT) X-Received: by 10.112.64.72 with SMTP id m8mr12816314lbs.41.1444677901425; Mon, 12 Oct 2015 12:25:01 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1715804lbq; Mon, 12 Oct 2015 12:25:00 -0700 (PDT) X-Received: by 10.66.235.194 with SMTP id uo2mr29123043pac.41.1444677900457; Mon, 12 Oct 2015 12:25:00 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dr3si28307572pbc.193.2015.10.12.12.25.00; Mon, 12 Oct 2015 12:25:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbbJLTY6 (ORCPT + 4 others); Mon, 12 Oct 2015 15:24:58 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52209 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbbJLTY6 (ORCPT ); Mon, 12 Oct 2015 15:24:58 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id t9CJOvHs029423 for ; Mon, 12 Oct 2015 14:24:57 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id t9CJOv3p010433 for ; Mon, 12 Oct 2015 14:24:57 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.224.2; Mon, 12 Oct 2015 14:24:57 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id t9CJOu1N013466; Mon, 12 Oct 2015 14:24:57 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Felipe Balbi Subject: [PATCH] Revert "usb: dwc3: gadget: remove unnecessary _irqsave()" Date: Mon, 12 Oct 2015 14:24:49 -0500 Message-ID: <1444677889-4758-1-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.5.3 MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This reverts commit 70f3a9caa11665e9f9aace581d85d8483716a4c8. That commit was causing a lockdep splat with g_ether and that was interfering with proper functionality. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index cca806e09e5b..81bfb9ad1e2e 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2642,15 +2642,16 @@ static irqreturn_t dwc3_process_event_buf(struct dwc3 *dwc, u32 buf) static irqreturn_t dwc3_thread_interrupt(int irq, void *_dwc) { struct dwc3 *dwc = _dwc; + unsigned long flags; irqreturn_t ret = IRQ_NONE; int i; - spin_lock(&dwc->lock); + spin_lock_irqsave(&dwc->lock, flags); for (i = 0; i < dwc->num_event_buffers; i++) ret |= dwc3_process_event_buf(dwc, i); - spin_unlock(&dwc->lock); + spin_unlock_irqrestore(&dwc->lock, flags); return ret; }