From patchwork Mon Sep 28 20:19:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 54211 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f200.google.com (mail-wi0-f200.google.com [209.85.212.200]) by patches.linaro.org (Postfix) with ESMTPS id 6A80522B1E for ; Mon, 28 Sep 2015 20:20:00 +0000 (UTC) Received: by wisv5 with SMTP id v5sf45356548wis.0 for ; Mon, 28 Sep 2015 13:19:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe; bh=jvjGExYlxhKGlHiCNX3WKFDNndhzfy4vzY5NTe49R54=; b=GbbBSB99UKAcoVNY8vCWWP3WeMB9j4kJgwb5LEq89lEfJCAuRQi4K0F/gyWR9t2zjU uUi5suSmu3y3p/ICvxloEuM4vEzRqUNWBiS0kTZWlfQ5LoOXNf51b3b0eX12O4jG2fi7 7jGaqKcgqS/GEJMy2/PQpYT2TVMhRn/4iHCjlZipXRnR0d8fIdIRhm8fnjjQEOhp2e/k uzOVD/rX5v9WQ2XX8NMlsFXyoi3u0VNqv5xjqQxpqb6TaMsfhe8HvaTv70K9bSaTcs7T KBN0Feotq0u+i+nBaaqHD8wmywhRRRXs+NHKBSFkp+w4MUBOGpgTM45zVr463wFufw4T vDSw== X-Gm-Message-State: ALoCoQlJJRL8ECzRnqWJ75n+yZyqZL5QUL87aKnrfKwlm3acGfXjVFNlbD9nF4SZOw+QL0KXAgA6 X-Received: by 10.180.160.146 with SMTP id xk18mr3182062wib.3.1443471598775; Mon, 28 Sep 2015 13:19:58 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.164.135 with SMTP id n129ls365457lfe.7.gmail; Mon, 28 Sep 2015 13:19:58 -0700 (PDT) X-Received: by 10.152.21.74 with SMTP id t10mr6025655lae.107.1443471598627; Mon, 28 Sep 2015 13:19:58 -0700 (PDT) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com. [209.85.215.54]) by mx.google.com with ESMTPS id i8si9134281lam.54.2015.09.28.13.19.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Sep 2015 13:19:58 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) client-ip=209.85.215.54; Received: by labzv5 with SMTP id zv5so28757481lab.1 for ; Mon, 28 Sep 2015 13:19:58 -0700 (PDT) X-Received: by 10.25.150.199 with SMTP id y190mr4083377lfd.35.1443471598476; Mon, 28 Sep 2015 13:19:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1751346lbq; Mon, 28 Sep 2015 13:19:57 -0700 (PDT) X-Received: by 10.50.164.135 with SMTP id yq7mr6228698igb.28.1443471595997; Mon, 28 Sep 2015 13:19:55 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e62si13949338iod.102.2015.09.28.13.19.55; Mon, 28 Sep 2015 13:19:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbbI1UTy (ORCPT + 4 others); Mon, 28 Sep 2015 16:19:54 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:38588 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbbI1UTx (ORCPT ); Mon, 28 Sep 2015 16:19:53 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id t8SKJqs0030278 for ; Mon, 28 Sep 2015 15:19:52 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id t8SKJqh5019738 for ; Mon, 28 Sep 2015 15:19:52 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.224.2; Mon, 28 Sep 2015 15:19:52 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id t8SKJpuW015277; Mon, 28 Sep 2015 15:19:51 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Felipe Balbi Subject: [PATCH 3/3] usb: dwc3: gadget: remove unnecessary _irqsave() Date: Mon, 28 Sep 2015 15:19:44 -0500 Message-ID: <1443471584-21683-3-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.5.0.GIT In-Reply-To: <1443471584-21683-1-git-send-email-balbi@ti.com> References: <1443471584-21683-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We *know* our threads executes with our IRQs disabled. We really don't need to use the _irqsave() variant of spin_lock(). Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 81bfb9ad1e2e..cca806e09e5b 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2642,16 +2642,15 @@ static irqreturn_t dwc3_process_event_buf(struct dwc3 *dwc, u32 buf) static irqreturn_t dwc3_thread_interrupt(int irq, void *_dwc) { struct dwc3 *dwc = _dwc; - unsigned long flags; irqreturn_t ret = IRQ_NONE; int i; - spin_lock_irqsave(&dwc->lock, flags); + spin_lock(&dwc->lock); for (i = 0; i < dwc->num_event_buffers; i++) ret |= dwc3_process_event_buf(dwc, i); - spin_unlock_irqrestore(&dwc->lock, flags); + spin_unlock(&dwc->lock); return ret; }