From patchwork Wed Jul 16 10:22:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Baldyga X-Patchwork-Id: 33717 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D562120CA0 for ; Wed, 16 Jul 2014 10:23:41 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id la4sf1903552vcb.6 for ; Wed, 16 Jul 2014 03:23:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=DUl40jx2Mlg0uulCsi6WCnWLRXa6xQTGt0MxcDhaOFs=; b=Rj691IDcOPxkipBdldKQJgwjch7NeMoPzsN22mWPeXtuJIphCFqI5SxyFAlt2efYQv 2M1ZBrG10Ye3IfVq04zZNobDsLekvUaZhASt6qQSU2AKfnB/Q0EXthxo97FaBlYpgmeM ZQDqRfhsmptAdf8YnwK1J+FmH5vQDlj/I7oXEro5IhNcxUELp39OfFyqFEqE/rc5zZ5Q PLgJ/fWtzGlbCXKc9InOCZHWf1Wy2oy3X9nesMusXHjF2ShP2Us+qrCnZyufi3qcURtH QZ+/uXBgpFGvu2shnFRCLH/uNKzAYm/uZKF9819YYXngFnWA4klvmcebyyxUbGCqNFRx 2+vA== X-Gm-Message-State: ALoCoQkey3MPnG6GfQFxnZ3kgOTfH3XKJKLX1lbVkbOzrjzrtfHEI+FcxWon3DSxiJwVsbwirZuH X-Received: by 10.236.142.20 with SMTP id h20mr11939220yhj.12.1405506221361; Wed, 16 Jul 2014 03:23:41 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.27.54 with SMTP id 51ls355104qgw.41.gmail; Wed, 16 Jul 2014 03:23:41 -0700 (PDT) X-Received: by 10.220.160.67 with SMTP id m3mr6168550vcx.56.1405506221279; Wed, 16 Jul 2014 03:23:41 -0700 (PDT) Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180]) by mx.google.com with ESMTPS id fw8si8063649vdc.60.2014.07.16.03.23.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Jul 2014 03:23:41 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.180 as permitted sender) client-ip=209.85.220.180; Received: by mail-vc0-f180.google.com with SMTP id ij19so1203407vcb.11 for ; Wed, 16 Jul 2014 03:23:41 -0700 (PDT) X-Received: by 10.52.248.146 with SMTP id ym18mr23123353vdc.8.1405506221215; Wed, 16 Jul 2014 03:23:41 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp285344vcb; Wed, 16 Jul 2014 03:23:40 -0700 (PDT) X-Received: by 10.70.61.103 with SMTP id o7mr9578601pdr.134.1405506220028; Wed, 16 Jul 2014 03:23:40 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rn1si14089807pbc.172.2014.07.16.03.23.39; Wed, 16 Jul 2014 03:23:39 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932812AbaGPKXb (ORCPT + 28 others); Wed, 16 Jul 2014 06:23:31 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:18062 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932735AbaGPKX1 (ORCPT ); Wed, 16 Jul 2014 06:23:27 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N8S002W6VIN1T50@mailout3.samsung.com>; Wed, 16 Jul 2014 19:23:11 +0900 (KST) X-AuditID: cbfee61b-f79f86d00000144c-66-53c6528f25f2 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 0A.68.05196.F8256C35; Wed, 16 Jul 2014 19:23:11 +0900 (KST) Received: from AMDC2122.DIGITAL.local ([106.120.53.17]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N8S00MJHVHJNH00@mmp2.samsung.com>; Wed, 16 Jul 2014 19:23:11 +0900 (KST) From: Robert Baldyga To: balbi@ti.com Cc: paulz@synopsys.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, andrzej.p@samsung.com, Robert Baldyga Subject: [PATCH v2 08/12] usb: dwc2/gadget: do not call disconnect method in pullup Date: Wed, 16 Jul 2014 12:22:26 +0200 Message-id: <1405506150-16185-9-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1405506150-16185-1-git-send-email-r.baldyga@samsung.com> References: <1405506150-16185-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJLMWRmVeSWpSXmKPExsVy+t9jQd3+oGPBBncnSlrMetnOYnHwfr1F 8+L1bBaXd81hs1i0rJXZYu2Ru+wW26dMZ7J4cHgnuwOHx/65a9g9+rasYvTYsv8zo8fxG9uZ PD5vkgtgjeKySUnNySxLLdK3S+DKOHPzIEvBPLaKK01XWRoYF7F2MXJySAiYSCw8uIkdwhaT uHBvPVsXIxeHkMB0Rok1j9ZAOe1MEj9PXwTrYBPQkdjyfQIjiC0iICCx/sUldpAiZoETjBId /y+wgSSEBUIlln48yAxiswioSrTOagRr4BVwlVjTfA5qnZzEyWOTwYZyCrhJrHndDBYXAqo5 vm4Z0wRG3gWMDKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxggPsmfQOxlUNFocYBTgYlXh4 N4QcDRZiTSwrrsw9xCjBwawkwuvgfyxYiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/BVutAIYH0 xJLU7NTUgtQimCwTB6dUA+Pm3vlhWvvWaS5o9BHwv+5S/Cp636xfxz+ujzki38dz40cXR8Va ljb71qjWVZOnn7n/8K5W80Kxomlhn9bERjIVu//oPh5e57AxNaeOxWHa1JlPzY61bdpmd6Ru 2b7JTCbrBF81rg3hs7ec13HPrMs/o5JpyoQws6habk6NCX+3qNQHlJ/fVqfEUpyRaKjFXFSc CACgibI7LAIAAA== Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 2220882..def4900 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2945,7 +2945,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }