| Message ID | 20250331215720.19692-1-alex.vinarskis@gmail.com |
|---|---|
| Headers | show |
| Series | X1E Asus Zenbook A14 support | expand |
On Mon, 31 Mar 2025 23:53:34 +0200, Aleksandrs Vinarskis wrote: > Introduce support for the mentioned laptop. > > Particular device exists in two model numbers: > * UX3407QA: X1P-42-100 or X1-26-100 (as tested) > * UX3407RA: X1E-78-100 > > Mostly similar to other X1-based laptops. Notable differences are: > * Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA > and Qualcomm FastConnect 7800 on UX3407RA > * USB Type-C retimers are Parade PS8833, appear to behave identical > to Parade PS8830 > * gpio90 is TZ protected > > Document new Parade PS883x variant. Move pcie6a_phy's compatible change > from X1P-42-100's dtsi to be CRD specific, at it seems it does not > apply to all machines - on X1-26-100 phy times-out when using new x1p > compatible. > > When comparing device firmware between UX3407QA, UX3407RA, it seems > that only ADSP firmware is different, CDSP and GPU firmware appears to > be the same. (At least assuming the GPU firmware name in both cases is > `qcdxkmsuc8380.mbn`). Since at least some blobs are different betweeen > X1E and X1/X1P, define new firmware directory for `qcom/x1p42100`. This > also makes it easier for distros to automatically extract firmware from > Windows and place all blobs for the model under the same path. If/When > firmware blobs make it to linux-firmware, same blobs can be easily > symlinked between `qcom/x1e80100` and `qcom/x1p42100`. > > Qualcomm FastConnect 6900 on UX3407QA did not work out of the box, and > additionally required both newer firmware and patches to `board-2.bin`. > I added a short how-to [1], as it is not exactly trivial. > > ACPI dumps can be found on aarch64-laptops' github [2]. HWids on > dtbloader's github [3]. > > [1] https://github.com/alexVinarskis/linux-x1e80100-zenbook-a14?tab=readme-ov-file#wcn688x-wifi > [2] https://github.com/aarch64-laptops/build/pull/134/files > [3] https://github.com/TravMurav/dtbloader/pull/4/files > > Aleksandrs Vinarskis (6): > arm64: dts: qcom: move pcie6a type change from X1P42100 to > X1P42100-crd > usb: typec: Add Parade PS8833 Type-C Retimer variant > dt-bindings: usb: Add Parade PS8833 Type-C retimer variant > dt-bindings: arm: qcom: Add Asus Zenbook A14 > firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14 > arm64: dts: qcom: Add support for X1-based Asus Zenbook A14 > > .../devicetree/bindings/arm/qcom.yaml | 2 + > .../bindings/usb/parade,ps8830.yaml | 1 + > arch/arm64/boot/dts/qcom/Makefile | 2 + > arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi | 1251 +++++++++++++++++ > .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 45 + > .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 48 + > arch/arm64/boot/dts/qcom/x1p42100-crd.dts | 4 + > arch/arm64/boot/dts/qcom/x1p42100.dtsi | 4 - > drivers/firmware/qcom/qcom_scm.c | 2 + > drivers/usb/typec/mux/ps883x.c | 1 + > 10 files changed, 1356 insertions(+), 4 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts > create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts > > -- > 2.45.2 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: attempting to guess base-commit... Base: tags/next-20250331 (exact match) If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250331215720.19692-1-alex.vinarskis@gmail.com: arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfacmn-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddaon-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddwlcx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddwlmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa0p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p2-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('bt-en-sleep' was unexpected) from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfacmn-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddaon-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddwlcx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddwlmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddbtcmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa0p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p2-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: bluetooth: 'vddrfa1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('bt-en-sleep' was unexpected) from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
On 31/03/2025 23:53, Aleksandrs Vinarskis wrote: > Appears to behave similarly to Parade PS8830. Found on some Qualcomm > Snapdragon X1 devices, such as Asus Zenbook A14. > > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> Looks compatible, so express it with fallback. Best regards, Krzysztof
On Tue, 1 Apr 2025 at 12:19, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > > On 3/31/25 11:53 PM, Aleksandrs Vinarskis wrote: > > It appears at least on some devices (Asus Zenbook A14, x1-26-100) change > > of pcie6a_phy's compatible breaks the controller. Move compatible change > > from generic x1p42100.dtsi to CRD's specific x1p42100-crd.dts instead. > > > > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> > > --- > > arch/arm64/boot/dts/qcom/x1p42100-crd.dts | 4 ++++ > > arch/arm64/boot/dts/qcom/x1p42100.dtsi | 4 ---- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1p42100-crd.dts b/arch/arm64/boot/dts/qcom/x1p42100-crd.dts > > index cf07860a63e9..a2a212b31556 100644 > > --- a/arch/arm64/boot/dts/qcom/x1p42100-crd.dts > > +++ b/arch/arm64/boot/dts/qcom/x1p42100-crd.dts > > @@ -15,3 +15,7 @@ / { > > model = "Qualcomm Technologies, Inc. X1P42100 CRD"; > > compatible = "qcom,x1p42100-crd", "qcom,x1p42100"; > > }; > > + > > +&pcie6a_phy { > > + compatible = "qcom,x1p42100-qmp-gen4x4-pcie-phy"; > > +}; > > diff --git a/arch/arm64/boot/dts/qcom/x1p42100.dtsi b/arch/arm64/boot/dts/qcom/x1p42100.dtsi > > index 27f479010bc3..4424a8708d39 100644 > > --- a/arch/arm64/boot/dts/qcom/x1p42100.dtsi > > +++ b/arch/arm64/boot/dts/qcom/x1p42100.dtsi > > @@ -37,10 +37,6 @@ &pcie3 { > > num-lanes = <4>; > > }; > > > > -&pcie6a_phy { > > - compatible = "qcom,x1p42100-qmp-gen4x4-pcie-phy"; > > -}; > > > This is not correct. The hardware is different in all SoCs, not just the > ones put in the CRD. > > You're probably missing this change [1], please test it out and leave a t-b > if it's confirmed working for you. Thanks for the pointer, with the missing peace it indeed works now! Left t-b. Will drop this change on re-spin later today. Thanks for the review, Alex > > Konrad > > [1] https://lore.kernel.org/linux-arm-msm/4c7059a0-46a0-424d-9068-60894c6cec1c@quicinc.com/T/#m9675593a62b2334ab2afd4269da6938464a03fa6
Introduce support for the mentioned laptop. Particular device exists in two model numbers: * UX3407QA: X1P-42-100 or X1-26-100 (as tested) * UX3407RA: X1E-78-100 Mostly similar to other X1-based laptops. Notable differences are: * Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA and Qualcomm FastConnect 7800 on UX3407RA * USB Type-C retimers are Parade PS8833, appear to behave identical to Parade PS8830 * gpio90 is TZ protected Document new Parade PS883x variant. Move pcie6a_phy's compatible change from X1P-42-100's dtsi to be CRD specific, at it seems it does not apply to all machines - on X1-26-100 phy times-out when using new x1p compatible. When comparing device firmware between UX3407QA, UX3407RA, it seems that only ADSP firmware is different, CDSP and GPU firmware appears to be the same. (At least assuming the GPU firmware name in both cases is `qcdxkmsuc8380.mbn`). Since at least some blobs are different betweeen X1E and X1/X1P, define new firmware directory for `qcom/x1p42100`. This also makes it easier for distros to automatically extract firmware from Windows and place all blobs for the model under the same path. If/When firmware blobs make it to linux-firmware, same blobs can be easily symlinked between `qcom/x1e80100` and `qcom/x1p42100`. Qualcomm FastConnect 6900 on UX3407QA did not work out of the box, and additionally required both newer firmware and patches to `board-2.bin`. I added a short how-to [1], as it is not exactly trivial. ACPI dumps can be found on aarch64-laptops' github [2]. HWids on dtbloader's github [3]. [1] https://github.com/alexVinarskis/linux-x1e80100-zenbook-a14?tab=readme-ov-file#wcn688x-wifi [2] https://github.com/aarch64-laptops/build/pull/134/files [3] https://github.com/TravMurav/dtbloader/pull/4/files Aleksandrs Vinarskis (6): arm64: dts: qcom: move pcie6a type change from X1P42100 to X1P42100-crd usb: typec: Add Parade PS8833 Type-C Retimer variant dt-bindings: usb: Add Parade PS8833 Type-C retimer variant dt-bindings: arm: qcom: Add Asus Zenbook A14 firmware: qcom: scm: Allow QSEECOM on Asus Zenbook A14 arm64: dts: qcom: Add support for X1-based Asus Zenbook A14 .../devicetree/bindings/arm/qcom.yaml | 2 + .../bindings/usb/parade,ps8830.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 2 + arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi | 1251 +++++++++++++++++ .../dts/qcom/x1e80100-asus-zenbook-a14.dts | 45 + .../dts/qcom/x1p42100-asus-zenbook-a14.dts | 48 + arch/arm64/boot/dts/qcom/x1p42100-crd.dts | 4 + arch/arm64/boot/dts/qcom/x1p42100.dtsi | 4 - drivers/firmware/qcom/qcom_scm.c | 2 + drivers/usb/typec/mux/ps883x.c | 1 + 10 files changed, 1356 insertions(+), 4 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/x1-zenbook-a14.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-asus-zenbook-a14.dts create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dts