From patchwork Thu Nov 7 19:29:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Pandit-Subedi X-Patchwork-Id: 841686 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7DD1125D6 for ; Thu, 7 Nov 2024 19:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731007895; cv=none; b=KR8pnfMYzi2P1/bJKTu5uP8WmgLA1GHeq76aS5tryOefgRCGimU+GmcfnzN9t/W4DA0NR2BB63d8pomGleS6jSM0jfHXNsQbZSs/vQOwyrVYmrVIxrraGBjXaOQGSdSEzvtGCcPUCHAjBp50W9zowTWIeSDpbB9pDnRpmPb7TL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731007895; c=relaxed/simple; bh=FhVtDKAHLNobaF3Xr7MJKIpcbXekOH7CtAljMKvTH6s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=liropENwASLAFJyhgQO1HUIRJCBC2MUGrhlSXU3uZCWHcsrKMS+aWhhU8DOcZax6eUcRw0N4qVWiCPn5NB28tEe2esSq8iPfj//jufNP/2ABxJbYN1LikctzRaStW8LSV9V84xu0TP3zecodh0W9I2orKTkX5gD5Z34OnlwqW0o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=oTthrFLj; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oTthrFLj" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2e2eb9dde40so1081931a91.0 for ; Thu, 07 Nov 2024 11:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1731007893; x=1731612693; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hbvSClt+dAXUM1kgWg8I5q9vyT6fSjbN1Ij//6r0NEI=; b=oTthrFLjxQ4Wkc6O4vxIf8kr2X3q4wRMAT9adKQzxRe8tm4r4AlgWyIEb5vpkoDZQf LjyrIYV736lZ0bnHUgsMqeKGw0k0lDWnZXksat1lyKGkPXUXeJX23irry424C5urqWXc u33lzg5mgFD3Jh/xmch1yODDHdbzrKC8oHxjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731007893; x=1731612693; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hbvSClt+dAXUM1kgWg8I5q9vyT6fSjbN1Ij//6r0NEI=; b=O2X38Ij96ByZ4/tDOSAPJqIaQ3GABTwoGiAp7Iku7myq5DCO86gCo5+KkY4bTz8BLN 4oqXSlsJC1GxBSJD6Nx+TxSwpkgx8S8U3n2Vp6TN7yPrMw74V2crVwrCi/3eJ0jZ8sqX dAVpbmdXW0s53B0RGdD0fXoxycdolRF43kzxG14FJHkk86m9KzAw78Ov0kdsgzwnicg6 l9ZLaoTsa2UHRdSU71i+oPh7fGVRfZ3pqAIFp5E6OQw+hJHrK7qAoRoQHqSTb/hTmKSl Z8Mo5/eyk93h/gU4tZm7yn0+BTAC68dal6fzIUQH6tSzp6jTRo1edOhth78Romba/a5G RRHg== X-Forwarded-Encrypted: i=1; AJvYcCUn5AD5RKsabZV/kOr6FlYTzadXIcEsk81TA0GRzgG7KeG6JoH972D1I4kXwvfF5vU+X+wOS6Gka7k=@vger.kernel.org X-Gm-Message-State: AOJu0YwrJI2wc9tdg0Dwikzguqugez21jawtL4fO8MScCaYkcPR00/W8 bHm0uAiVymI00T5ShC9gAK5UuyV1lO4vHLNIjX4yWO8lzW+FEvsNuUJW7jTDYw== X-Google-Smtp-Source: AGHT+IEbLiBW3PaYgjufhiOm00mstGi5fV/4ArJUPxEYJmyYx8kjZqmIWOQFXW/GQR4cVKjQcYgHcw== X-Received: by 2002:a17:90a:e7cb:b0:2e2:e8fc:e0dd with SMTP id 98e67ed59e1d1-2e9b1748ba3mr394578a91.35.1731007892871; Thu, 07 Nov 2024 11:31:32 -0800 (PST) Received: from localhost (198.103.247.35.bc.googleusercontent.com. [35.247.103.198]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2e9a5f8f4e2sm2071802a91.26.2024.11.07.11.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 11:31:32 -0800 (PST) From: Abhishek Pandit-Subedi To: heikki.krogerus@linux.intel.com, tzungbi@kernel.org, linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: jthies@google.com, akuchynski@google.com, pmalani@chromium.org, dmitry.baryshkov@linaro.org, Abhishek Pandit-Subedi , Benson Leung , Greg Kroah-Hartman , Guenter Roeck , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/7] Thunderbolt and DP altmode support for cros-ec-typec Date: Thu, 7 Nov 2024 11:29:53 -0800 Message-ID: <20241107193021.2690050-1-abhishekpandit@chromium.org> X-Mailer: git-send-email 2.47.0.277.g8800431eea-goog Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Heikki, Tzung-Bi et al, This patch series adds support for alternate mode entry for the cros-ec-typec driver for Displayport and Thunderbolt. Thunderbolt support is added by adapting an RFC Heikki had posted previously: https://lore.kernel.org/linux-usb/20191230152857.43917-1-heikki.krogerus@linux.intel.com/ A few comments on the series: * The cros-ec interface will not accept any VDOs/VDMs so we simply ignore any configurations we are passed (i.e. DPConfigure). This means the sysfs control of DP lanes won't work. * ChromeOS has two modes of operation for alt-modes: entirely EC driven or AP-driven from userspace (via the typec daemon). Thus, we don't expect the kernel alt-mode drivers to auto-enter modes in all cases. This series allows auto-enter for displayport but disables it for TBT for this reason. This was tested with a ChromeOS Brya device using kernel 6.6 and built with allmodconfig for linux-usb. Thanks, Abhishek Changes in v3: - Removed mode from altmode device ids - Updated modalias for typecd bus to remove mode - Re-ordered to start of series - Revert rename of TYPEC_TBT_MODE - Remove mode from typec_device_id - Use port.active instead of introducing auto-enter field - Introduce inactive field to typec_altmode_desc to set default value for active. - Always make port 'active' field writable - Refactored typec_altmode_dp_data per review request - Removed unused vdm operations during altmode registration - Fix usage of TBT sid and mode. - Removed unused vdm operations during altmode registration - Set port.inactive = true instead of auto-enter. Changes in v2: - Update altmode_match to ignore mode entirely - Also apply the same behavior to typec_match - Use and add missing TBT_CABLE_ROUNDED - Pass struct typec_thunderbolt_data to typec_altmode_notify - Rename TYPEC_TBT_MODE to USB_TYPEC_TBT_MODE - Use USB_TYPEC_TBT_SID and USB_TYPEC_TBT_MODE for device id - Change module license to GPL due to checkpatch warning - Refactored displayport into cros_typec_altmode.c to extract common implementation between altmodes - Refactored thunderbolt support into cros_typec_altmode.c - Only disable auto-enter for Thunderbolt - Update commit message to clearly indicate the need for userspace intervention to enter TBT mode Abhishek Pandit-Subedi (6): usb: typec: Only use SVID for matching altmodes usb: typec: Check port is active before enter mode on probe platform/chrome: cros_ec_typec: Update partner altmode active platform/chrome: cros_ec_typec: Displayport support platform/chrome: cros_ec_typec: Thunderbolt support platform/chrome: cros_ec_typec: Disable tbt on port Heikki Krogerus (1): usb: typec: Add driver for Thunderbolt 3 Alternate Mode MAINTAINERS | 3 + drivers/platform/chrome/Makefile | 7 + drivers/platform/chrome/cros_ec_typec.c | 47 ++- drivers/platform/chrome/cros_ec_typec.h | 1 + drivers/platform/chrome/cros_typec_altmode.c | 360 +++++++++++++++++++ drivers/platform/chrome/cros_typec_altmode.h | 48 +++ drivers/usb/typec/altmodes/Kconfig | 9 + drivers/usb/typec/altmodes/Makefile | 2 + drivers/usb/typec/altmodes/displayport.c | 9 +- drivers/usb/typec/altmodes/nvidia.c | 2 +- drivers/usb/typec/altmodes/thunderbolt.c | 312 ++++++++++++++++ drivers/usb/typec/bus.c | 6 +- drivers/usb/typec/class.c | 9 +- include/linux/usb/typec.h | 2 + include/linux/usb/typec_tbt.h | 1 + scripts/mod/devicetable-offsets.c | 1 - scripts/mod/file2alias.c | 4 +- 17 files changed, 793 insertions(+), 30 deletions(-) create mode 100644 drivers/platform/chrome/cros_typec_altmode.c create mode 100644 drivers/platform/chrome/cros_typec_altmode.h create mode 100644 drivers/usb/typec/altmodes/thunderbolt.c Reviewed-by: Heikki Krogerus Reviewed-by: Heikki Krogerus