From patchwork Thu Jun 6 09:03:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Carrasco X-Patchwork-Id: 802570 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2137.outbound.protection.outlook.com [40.107.22.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A55B15DBA0; Thu, 6 Jun 2024 09:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664655; cv=fail; b=PmgoMAfJGihAhkgUnvcoWAZ5s3A8kTXD0DGwanYFdmU5hc3xLlBQoZTjb+gb+elxNOq56dekrcFhqzTXqTOl2tFzrrW5V4YtQxY3anP1cLmVFQv+fEV1aYTjjBd6KlFMLm5BgQ4lZ3wTAqDc7hik+OdFlqIdvPYXN20Oa9mqK0g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664655; c=relaxed/simple; bh=ID7YG32TeXSAXxZJNLninYZh2bWpM9/iyN1Cc4WXRxk=; h=From:Subject:Date:Message-Id:Content-Type:To:Cc:MIME-Version; b=KqwVVK7P2/KyAXboP2K9oVP6Ol2q2QdIsXUDfAWs7CH0AY5xM8EH3WNYqsyHdllUzruw6SXWOUgbNe4TP1rMsk/CWsLLG/A2mLB2HSk81H6NXaMEoL8fag6pG4Y1a9lMC6y62SXp3YAsLcUuc3o/zGWbqaJMVzsYEwkcMr9dOCU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wolfvision.net; spf=pass smtp.mailfrom=wolfvision.net; dkim=pass (1024-bit key) header.d=wolfvision.net header.i=@wolfvision.net header.b=AD4+u4YS; arc=fail smtp.client-ip=40.107.22.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wolfvision.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wolfvision.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=wolfvision.net header.i=@wolfvision.net header.b="AD4+u4YS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N6ymenLIwI5nhxrNhBrUJaZJ8M89BhoTb/ha6clT/MjF5ewjQ4RxiFhZQR9LgN+YIXClrzDt87gWQCQjf5GgFUw5JkINnZQ2dcDssEaKvJJEJhreC7VV9ntXQGeRuXlBAKSFp/2xrFaJBB6ut9l9RtgKNQPxZNoE0TGj6/yrhcf4xzHVPuIxSK7oRonnzeZI4QQ9X1wT596dWVKUs5UKWvMqF44i5qBC9JXXxvr05LmaFhGxrt9uAHCFXSO7FoEPH2wjx4jhRMUNsLKDwVemOxTAzxXNR006J93Pw/k20427WaWfJ/AwEbh8gkuQbUV8Ah9s4AUiM8LPIC4/RYW3yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pVZ0JUFz3CVufc2+crB/U2g6Wz+sjwpyecsLlOCUacc=; b=LOUlPazOI6ZOhzNCTVToLugwNjuHb5w6J+0ZlhemF7u8PqmD+HwO331QA3nzTiBDmau1+InT/Mrm8JLsX5U+pQzOTftL6l7Nuchdu0tXlEf1q+VFgCnpDUntcOD42BI+9GwMWWNIeM155xidr90Ig1s8haG+Z3Ou2ko7wlDNh8fPjHeYaGPIihwnXmYte/ts8fwT6oQPYzX6fWXM2dyICfjZAsry8wD+83LX86B48qXgdXXnzk/kUWzIqHUgsFMSb3qDXf1a2TrzKXprLKPcKjG23mrP05ATkKVf3lWTS9qEu4JhpUFQNI4n2x7HLnj82sqyqkGpqdrqvEjq6SlnOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wolfvision.net; dmarc=pass action=none header.from=wolfvision.net; dkim=pass header.d=wolfvision.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfvision.net; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVZ0JUFz3CVufc2+crB/U2g6Wz+sjwpyecsLlOCUacc=; b=AD4+u4YSAr1anwAl3/Mj3BVgtiXEP83jF3VwSS5RRKsavXZPK7fowSKApcgyuc8ti6tMBBg0Yb13HVI6tHgDGDSGTtr60BMHd6qDWx5RuRwf5f4+w4RGI5TusUN9tN8IS4CZS6loVi7323S9oqcujQIartbm/gXMSI/QDOyrPjs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wolfvision.net; Received: from VE1PR08MB4974.eurprd08.prod.outlook.com (2603:10a6:803:111::15) by DB9PR08MB9513.eurprd08.prod.outlook.com (2603:10a6:10:459::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Thu, 6 Jun 2024 09:04:03 +0000 Received: from VE1PR08MB4974.eurprd08.prod.outlook.com ([fe80::a08:11be:8709:f5e1]) by VE1PR08MB4974.eurprd08.prod.outlook.com ([fe80::a08:11be:8709:f5e1%4]) with mapi id 15.20.7633.033; Thu, 6 Jun 2024 09:04:03 +0000 From: Javier Carrasco Subject: [PATCH 0/3] usb: typec: tipd: minor improvements in the firmware update code Date: Thu, 06 Jun 2024 11:03:54 +0200 Message-Id: <20240606-tps6598x_fw_update_log-v1-0-2b5b8369a0ba@wolfvision.net> X-B4-Tracking: v=1; b=H4sIAHp7YWYC/x3MTQqAIBBA4avErBNUKqqrRMiUYw1EifYH0d2Tl t/ivQciBaYIbfZAoJMjb2uCyjMYZ1wnEmyTQUtdyEqWYvexKpv6Nu4yh7e4k1m2SSirauUQBz0 gpNgHcnz/465/3w/Af41KaAAAAA== To: Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , Julia Lawall X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1717664643; l=1261; i=javier.carrasco@wolfvision.net; s=20240320; h=from:subject:message-id; bh=ID7YG32TeXSAXxZJNLninYZh2bWpM9/iyN1Cc4WXRxk=; b=RXflbzd8qwBw9FTWCQ177u6b6qQM4DmLCDI1IjA0MDKs3ZzF34Pk7R1T0qrKT3jRrKBpnvJIu NCTyUqekVrFA6x4xa95Nk21jRSajVRFgNUfkk7cO3d6mt0Of9EK6qb3 X-Developer-Key: i=javier.carrasco@wolfvision.net; a=ed25519; pk=Vxk2/0sGIxM8rsKnceszFuSuHVfQwa1Yo8+is7BX2nY= X-ClientProxiedBy: VI1PR07CA0310.eurprd07.prod.outlook.com (2603:10a6:800:130::38) To VE1PR08MB4974.eurprd08.prod.outlook.com (2603:10a6:803:111::15) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR08MB4974:EE_|DB9PR08MB9513:EE_ X-MS-Office365-Filtering-Correlation-Id: 856275c7-dbbe-4023-b90c-08dc86079cc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|366007|1800799015|52116005|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?DC536XYjxF3ZOyZt8OmzY8U9KfeYMEE?= =?utf-8?q?UGFlobyXjzKUuZexI7uwyXbyvxkLFKNkXN7WRjGmFIrAeSonnhkMhJewSsiMuYbfE?= =?utf-8?q?2U9oHY8nDaKb6pZcRsXzC6miHzn+Xy0aHD5SxsdKU7hkxDAeecB49ST3XVl+fhbYE?= =?utf-8?q?lNqaB8M0nrvEroPdc552cbZVDGEQFaZ+E3tti2ANDyF2WUtN6wy5+0q/Cfrw7LAya?= =?utf-8?q?Z1Xa1SjZM61H4XILm0BWssuZj+J3IThh1AM3z3jZMOhcBELDgpIyVokzBnt15POZB?= =?utf-8?q?MuwZv5lzkdyKN/+055LXmdH5Kx6eo3dX1njULAZrJRkiqIu6Bq+zaSuYvD/+KDSYm?= =?utf-8?q?5PqaMOhya+CBg5stTG0GmI9GbLzH2Jk6+sp6GUL1QIvHesOci8tfxZKc5OA0+f81C?= =?utf-8?q?3XkCBt6ZqS8pablPYiPgBgpLgIyKm9z72VhWjV1r/kX4UKQXitI1vhIZwgwoa0IOa?= =?utf-8?q?ATUmvbPhqqNawzPm1djEI3rphJud39isf6oFOCJdBQRfMCI5OjO74bQzdntBCB4cK?= =?utf-8?q?v9EhWP8gUsGd1VHLg3ob5OBqjR8SV2PDclUG2BRrkuOc2YlxdDa8Sef6COFJ4I+Pr?= =?utf-8?q?N1tJVVBbWOjCm/I8xiGFcTN/LpgtPqlCOgc6u2T/SkzuXhOUfDg2fuG8Vq2re8MhS?= =?utf-8?q?1YeT94SqPh6L7GlF7LqLryTJHOyY0Og0Wowy9sTI5NTSmZlEiFYYBcys7Um/8N/ce?= =?utf-8?q?Ud2/cWRAN1BUXcVtNjiA6OmE0KJbDtvlNwOZ4rXuaR/nem5hA1wI4qgmJ4y9RC0LB?= =?utf-8?q?2ZkjJQzwGXBp0uI8VlBBxZVZt3rsjJWoWYWKu+1exbblo5VaB+3lDu2sDa7ieacl8?= =?utf-8?q?yBbSiX48UiQKZe9CA2QcKW9KfUxdgJFdYEn3TyCL8NwCs5o87P03/Zl+9vV5zMIew?= =?utf-8?q?+NxJKWIDm52D2vXGEW+5pbVbNBq+URM57wMGZd7LIRikhJrcxBeAWkZAKV6h5ZlVh?= =?utf-8?q?YYBpuVXSardb5v2paMOe0tywJcRP9T11s8u5qpfOvCxOQSOGZOxj6cXyAdVhD97cz?= =?utf-8?q?I8LONJarZvrzkk/6cNYeCCh3nDlPbBs3Yh1hBcAc/zrjOP8j+K1xk59rYF0yZ1PD2?= =?utf-8?q?8sWejQPIXOt5DJTSXBeEzJRZoLZ6fBq1aZpde8IPFJcjH9xeC/oqejk2YbLFb0tL7?= =?utf-8?q?c7gAhPgTHknJJvUv5Wk//CvLrB3TPRFYo/LiJLHbg91ONnpRMc+AUMxx4h0P7y3fJ?= =?utf-8?q?dKHNig/np1m+BNbjzPI9s6WIu6xqyJo/r0sYXlMu+zfUN6x6tWWpVi7Krz1OtJGe8?= =?utf-8?q?SGtYAw77sIRh8AJh9b7gBmNGxVJX8Ry86vad1OU7IEQXZJljcPldUdg8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4974.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(52116005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5+4rWsQlkCd0Bd+wkPT9SmcRkjmh?= =?utf-8?q?+r0XhUNEgZkbhhYdlczqHrpUsCcz6SNUHb26t3oKxssuKVXmVDpJLcWELYtcKwTeE?= =?utf-8?q?hKc8c3O5fb/DvsLSfsLTUD18I8gdL3hO5kFN0DjaaIshyeNJT2kQbejMA1s/gvXmE?= =?utf-8?q?cUPJ5e4+C/q7wh4NAF0QqcfE6PzWY4LDjIucR+oImQ/v7TjvmtHW7NapgT6L6r3ef?= =?utf-8?q?SBqoZMorxICr4KhDyX97aN+hRY0W8uMqzQ/pNRtqMEc+eIozQLBA/KVufFXwrr0rZ?= =?utf-8?q?dFZ/SFQSp/CXVP8ffPMC07GmlIsfwq4vqdlLpNLDoEyJPqH3F6cjaYEqUPuUs8yZd?= =?utf-8?q?jTKRkt8VLRJipko0ZMjce8kyXuLka6I6N/j78WqSRsbk2Sp5H5i5z8AQADRAKdi4v?= =?utf-8?q?i9W8m8ID0IfpwgRJgqBsSmItuNtXZHk/wqyibKq0UjiRLmBCFfpMtS7VZSYW7bpAB?= =?utf-8?q?GVWeTWPJjQ4zoC/cN6CV1Fqk1UADPN3Lbm9zBxs0LwTYnHH79NDqIXnnqprGW8/Yk?= =?utf-8?q?5vMRUmV33qDQcNV7vxMHZndHM3OBkOlxGVPtcmXTaS3N03G0+cKy6tU+7BzZ/Ao5Z?= =?utf-8?q?8LP4Wjh15C+9o65vUAs+8ZF+gdXbheQIsFYBqSM8WDUCWUQmi7KBYXeiPCSKlTjq6?= =?utf-8?q?aD8Yn874T/BnCEt6sSSm1pXskqWPBP1tlc6bzkqLzmGo5PfjWMGubz/B3z+XnXQsw?= =?utf-8?q?Rj/htJh+xDCMGP2mLJ7boIJBHOIgifLddPBLJ2xq7Ph5RbORmFlh8L7M0AedXiaut?= =?utf-8?q?KAQspgHc3/LrAnq47N9MDac0gtytU70ni9tUs9v5GKK45TH5PAoLymZfrRRSQP54I?= =?utf-8?q?0b+EXzfhufvkKguMEIkDbMCRIT7SDEqE2JopV+tXjrlL/Wt1kwroe9talvsczM7nY?= =?utf-8?q?tlOaryNM7ge5L+xKs3O8ikvaj2arb6a2l8EWZL7zbvAcorSW/+Upl96IdzUmpHpGj?= =?utf-8?q?pDf1Mi2S8YH0dIE83tcJGuRADE2J+/IjpZJ8dtTyQ4ki8s2+ltsr8p9D7FwsnI2Dr?= =?utf-8?q?x6b1qRV3r8hR/sc3R9LwOLdbManEZyp1zhfT1DOlNnOQ4CSHFcnjaQ+iZ51d/ImYl?= =?utf-8?q?E3Kdwg87ddl07g2cDCch972ESKfY4eRjcpHPJGeHRWN0536pvXjRClkditzxGZ/Et?= =?utf-8?q?8bF0nea3xeUb4B3AUZRoWVZpKTB8eRm7qFjRJr1WFy936/yzMi1+x9PBNFDF/B3SB?= =?utf-8?q?x5goNJXZ6XTNqeF3ecO8Yke6kIGwz6jG4WZstBwCcICXCBscQDat9yibspD9hsVDw?= =?utf-8?q?EPPCUZ+PsjK2Ppdj76dupukF0/YUMqDSUEpCDQ6Bk8MJO9K+7JWSTpqdyi5oGZgMo?= =?utf-8?q?jOBzFfxkRkE+4PQjbfZw5S8vl2R/NIRZc9Rv76yQbCgAgvDvodClpwjfZ7+li7WGC?= =?utf-8?q?iPA6F7sVf69Toyt6FOiS1apQjMjeSA/D5LZII+CkPiRmk6E3tKwb3vU3HqqU3sASH?= =?utf-8?q?PimqGoP6p5AtZHhvbFSnyfZnqMftVnWQc95y0mqRBSV94/ZmXoDISiYwInvoIaxpI?= =?utf-8?q?pTGOG0366e6h0cMfq4J0ekt24zkwHpFbHw=3D=3D?= X-OriginatorOrg: wolfvision.net X-MS-Exchange-CrossTenant-Network-Message-Id: 856275c7-dbbe-4023-b90c-08dc86079cc0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 09:04:03.3301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IkCvwTHuMuwBHZVRZowskuI+VYeSP0o543DVUKeg5FlP2Rd/jAiAzy5p87r6aJ6sPVT8QSm4Y5DYCEeb/paOOEB8o4WXQ1cDgPD4LZbq37Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9513 This series makes some minor modifications to the firmware update mechanism, mainly (but not only) for the tps6598x variant. The modifications are the following: 1. Use a single call to read the "firmware-name" property. The current implementations (tps25750 and tps6598x) of the firmware update mechanism read that property, even though tps_request_firmware() already does it. 2. Provide the same information via error logs for the both implementations (firmware name and size missing in tps6598x). 3. Minor code cleanup found by Coccinelle (min() instead of if...else). The series has been tested with a TPS65987DDHRSHR. Signed-off-by: Javier Carrasco --- Javier Carrasco (3): usb: typec: tipd: drop second firmware name read usb: typec: tipd: add error log to provide firmware name and size usb: typec: tipd: use min() to set tps6598x firmware packet size drivers/usb/typec/tipd/core.c | 33 ++++++++++++--------------------- 1 file changed, 12 insertions(+), 21 deletions(-) --- base-commit: 234cb065ad82915ff8d06ce01e01c3e640b674d2 change-id: 20240605-tps6598x_fw_update_log-1d181faab2ba Best regards,