| Message ID | 20240224-dwc3-v3-0-2535fcee7f08@outlook.com |
|---|---|
| Headers | show |
| Series | usb: dwc3: add glue driver for Hi3798MV200 | expand |
On 24/02/2024 13:10, Yang Xiwen via B4 Relay wrote: > +required: > + - compatible > + - ranges > + - '#address-cells' > + - '#size-cells' > + - clocks > + - clock-names > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + usb { > + compatible = "hisilicon,hi3798mv200-dwc3"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; You missed to implement my comments. *ONLY WITH* them: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi3798MV200 uses DWC3 with a few more clocks and a dedicated reset. Note xhci-histb.c can also be used. But since it's DWC3 in fact, trying to support it with the help of DWC3 framework seems a better solution. Hi3798CV200 can also try to migrate to this driver too. Thus we can remove xhci-histb.c in the future. Signed-off-by: Yang Xiwen <forbidden405@outlook.com> --- Changes in v3: - binding: remove example address - binding: remove reg (Krzysztof) - binding: rearrange required (Krzysztof) - binding: put additionalProperties after required (Krzysztof) - binding: indent properly (Krzysztof) - Link to v2: https://lore.kernel.org/r/20240224-dwc3-v2-0-8e4fcd757175@outlook.com Changes in v2: - remove histb-clock.h as it's deprecated. - fix bot error (Rob Herring) - add a dummy reg property to make simple-bus parent node happy. (duplicate with subnode, not used in driver) - Link to v1: https://lore.kernel.org/r/20240224-dwc3-v1-0-7ffb2e2baa73@outlook.com --- Yang Xiwen (2): dt-bindings: usb: add hisilicon,hi3798mv200-dwc3 usb: dwc3: of-simple: Add compatible for hi3798mv200 DWC3 controller .../bindings/usb/hisilicon,hi3798mv200-dwc3.yaml | 99 ++++++++++++++++++++++ drivers/usb/dwc3/dwc3-of-simple.c | 1 + 2 files changed, 100 insertions(+) --- base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d change-id: 20240217-dwc3-697828b480aa Best regards,