| Message ID | 20240130-pmi632-typec-v3-0-b05fe44f0a51@linaro.org |
|---|---|
| Headers | show |
| Series | usb: typec: qcom-pmic-typec: enable support for PMI632 PMIC | expand |
On Tue Jan 30, 2024 at 8:32 PM CET, Dmitry Baryshkov wrote: > The Qualcomm PMI632 PMIC (found on Qualcomm Robotics RB2 platform) > doesn't support USB Power Delivery. However this PMIC still supports > handling of the Type-C port (orientation detection, etc). Reuse exiting > qcom-pmic-typec driver to support Type-C related functionality of this > PMIC. Use this to enable USB-C connector support on the RB2 platform. Hi Dmitry, In case you send a new revision you can drop my Tested-by on the RB2 patches since it's a different platform, and the tag on the dt-bindings patches also don't make too much sense I think? Thanks! Regards Luca > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Changes in v3: > - Added constraints to qcom,pmic-typec / reg property (Krzysztof) > - Dropped merged TCPM and Qualcomm PHY patches > - Link to v2: https://lore.kernel.org/r/20240113-pmi632-typec-v2-0-182d9aa0a5b3@linaro.org > > Changes in v2: > - Split qcom_pmic_typec_pdphy_set_roles() changes to separate patch > (Konrad) > - Simplified devm_kzalloc / sizeof() argument (Konrad) > - Made start / stop callbacks mandatory (Bryan) > - Reworked Type-C port handling into a backend similar to PD PHY (Bryan) > - Made more qcom-pmic-typec data static const (Bryan) > - Squashed usbc PHY single-lane removal patch (Konrad) > - Further usbc PHY cleanup (Konrad) > - Fixed order of DT properties in pmi632.dtsi (Konrad) > - Instead of specifying bogus PDOs for the port, specify pd-disable and > typec-power-opmode properties for the connector > - Moved orientation-switch / usb-dual-role properties to sm6115.dtsi > (Konrad) > - Linked usb_dwc3_ss and usb_qmpphy_usb_ss_in > - Link to v1: https://lore.kernel.org/r/20240113-pmi632-typec-v1-0-de7dfd459353@linaro.org > > --- > Dmitry Baryshkov (5): > dt-bindings: regulator: qcom,usb-vbus-regulator: add support for PMI632 > dt-bindings: usb: qcom,pmic-typec: add support for the PMI632 block > usb: typec: qcom-pmic-typec: add support for PMI632 PMIC > arm64: dts: qcom: pmi632: define USB-C related blocks > arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling > > Vladimir Zapolskiy (1): > arm64: dts: qcom: sm6115: drop pipe clock selection > > .../regulator/qcom,usb-vbus-regulator.yaml | 9 ++- > .../devicetree/bindings/usb/qcom,pmic-typec.yaml | 32 ++++++++- > arch/arm64/boot/dts/qcom/pmi632.dtsi | 30 ++++++++ > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 50 +++++++++++++- > arch/arm64/boot/dts/qcom/sm6115.dtsi | 44 +++++++++++- > drivers/usb/typec/tcpm/qcom/Makefile | 3 +- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 30 ++++++-- > .../usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.h | 2 + > .../typec/tcpm/qcom/qcom_pmic_typec_pdphy_stub.c | 80 ++++++++++++++++++++++ > 9 files changed, 266 insertions(+), 14 deletions(-) > --- > base-commit: 41d66f96d0f15a0a2ad6fa2208f6bac1a66cbd52 > change-id: 20240112-pmi632-typec-4c7533092387 > > Best regards,
On Wed, Feb 07, 2024 at 11:54:50AM +0200, Dmitry Baryshkov wrote: > On Tue, 30 Jan 2024 at 21:33, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > The PMI632 PMIC support Type-C port handling, but lacks USB > > PowerDelivery support. The TCPM requires all callbacks to be provided > > by the implementation. Implement a special, 'stub' Qcom PD PHY > > implementation to enable the PMI632 support. > > > > Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > Tested-by: Luca Weiss <luca.weiss@fairphone.com> # sdm632-fairphone-fp3 > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Heikki, Gunter, Gret, is there anything left on my side to get these patches in? Nothing from me. Do you want Greg to pick these? thanks,
On Thu, 8 Feb 2024 at 13:54, Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > On Wed, Feb 07, 2024 at 11:54:50AM +0200, Dmitry Baryshkov wrote: > > On Tue, 30 Jan 2024 at 21:33, Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > The PMI632 PMIC support Type-C port handling, but lacks USB > > > PowerDelivery support. The TCPM requires all callbacks to be provided > > > by the implementation. Implement a special, 'stub' Qcom PD PHY > > > implementation to enable the PMI632 support. > > > > > > Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > > Tested-by: Luca Weiss <luca.weiss@fairphone.com> # sdm632-fairphone-fp3 > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Heikki, Gunter, Gret, is there anything left on my side to get these patches in? > > Nothing from me. Do you want Greg to pick these? Yes, please.
On Tue, 30 Jan 2024 21:32:53 +0200, Dmitry Baryshkov wrote: > The Qualcomm PMI632 PMIC (found on Qualcomm Robotics RB2 platform) > doesn't support USB Power Delivery. However this PMIC still supports > handling of the Type-C port (orientation detection, etc). Reuse exiting > qcom-pmic-typec driver to support Type-C related functionality of this > PMIC. Use this to enable USB-C connector support on the RB2 platform. > > > [...] Applied, thanks! [4/6] arm64: dts: qcom: pmi632: define USB-C related blocks commit: f69b3e40f46e8cf568809eb05a2e07bfea45b672 [5/6] arm64: dts: qcom: sm6115: drop pipe clock selection commit: 7e3a1f6470f7243c81156d2ead60f87da1184225 [6/6] arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling commit: a06a2f12f9e2fa9628a942efd916cf388b19c6ce Best regards,
The Qualcomm PMI632 PMIC (found on Qualcomm Robotics RB2 platform) doesn't support USB Power Delivery. However this PMIC still supports handling of the Type-C port (orientation detection, etc). Reuse exiting qcom-pmic-typec driver to support Type-C related functionality of this PMIC. Use this to enable USB-C connector support on the RB2 platform. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes in v3: - Added constraints to qcom,pmic-typec / reg property (Krzysztof) - Dropped merged TCPM and Qualcomm PHY patches - Link to v2: https://lore.kernel.org/r/20240113-pmi632-typec-v2-0-182d9aa0a5b3@linaro.org Changes in v2: - Split qcom_pmic_typec_pdphy_set_roles() changes to separate patch (Konrad) - Simplified devm_kzalloc / sizeof() argument (Konrad) - Made start / stop callbacks mandatory (Bryan) - Reworked Type-C port handling into a backend similar to PD PHY (Bryan) - Made more qcom-pmic-typec data static const (Bryan) - Squashed usbc PHY single-lane removal patch (Konrad) - Further usbc PHY cleanup (Konrad) - Fixed order of DT properties in pmi632.dtsi (Konrad) - Instead of specifying bogus PDOs for the port, specify pd-disable and typec-power-opmode properties for the connector - Moved orientation-switch / usb-dual-role properties to sm6115.dtsi (Konrad) - Linked usb_dwc3_ss and usb_qmpphy_usb_ss_in - Link to v1: https://lore.kernel.org/r/20240113-pmi632-typec-v1-0-de7dfd459353@linaro.org --- Dmitry Baryshkov (5): dt-bindings: regulator: qcom,usb-vbus-regulator: add support for PMI632 dt-bindings: usb: qcom,pmic-typec: add support for the PMI632 block usb: typec: qcom-pmic-typec: add support for PMI632 PMIC arm64: dts: qcom: pmi632: define USB-C related blocks arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling Vladimir Zapolskiy (1): arm64: dts: qcom: sm6115: drop pipe clock selection .../regulator/qcom,usb-vbus-regulator.yaml | 9 ++- .../devicetree/bindings/usb/qcom,pmic-typec.yaml | 32 ++++++++- arch/arm64/boot/dts/qcom/pmi632.dtsi | 30 ++++++++ arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 50 +++++++++++++- arch/arm64/boot/dts/qcom/sm6115.dtsi | 44 +++++++++++- drivers/usb/typec/tcpm/qcom/Makefile | 3 +- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 30 ++++++-- .../usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.h | 2 + .../typec/tcpm/qcom/qcom_pmic_typec_pdphy_stub.c | 80 ++++++++++++++++++++++ 9 files changed, 266 insertions(+), 14 deletions(-) --- base-commit: 41d66f96d0f15a0a2ad6fa2208f6bac1a66cbd52 change-id: 20240112-pmi632-typec-4c7533092387 Best regards,