| Message ID | 20231117173650.21161-1-johan+linaro@kernel.org |
|---|---|
| Headers | show |
| Series | USB: dwc3: qcom: fix resource leaks on probe deferral | expand |
On 17.11.2023 18:36, Johan Hovold wrote: > When reviewing the recently submitted series which reworks the dwc3 qcom > glue implementation [1], I noticed that the driver's tear down handling > is currently broken, something which can lead to memory leaks and > potentially use-after-free issues on probe deferral and on driver > unbind. > > Let's get this sorted before reworking driver. > > Note that the last patch has only been compile tested as I don't have > access to a sdm845 device. > > Johan I'll sound like a broken record, but: is there anyone in the world that is actively benefiting from this failed experiment of using the ACPI tables that were shipped with these SoCs? There are so so so many shortcomings associated with it due to how Windows drivers on these platforms know waaaay too much and largely use ACPI to "bind driver x" and I simply think it doesn't make sense to continue carrying this code forward given little use and no testing. Konrad
On Sat, Nov 18, 2023 at 1:38 AM Johan Hovold <johan+linaro@kernel.org> wrote: > > Make sure to free the "urs" platform device, which is created for some > ACPI platforms, on probe errors and on driver unbind. > > Compile-tested only. > > Fixes: c25c210f590e ("usb: dwc3: qcom: add URS Host support for sdm845 ACPI boot") > Cc: Shawn Guo <shawn.guo@linaro.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Acked-by: Shawn Guo <shawn.guo@linaro.org>
On Fri, Nov 17, 2023 at 06:36:49PM +0100, Johan Hovold wrote: > Make sure to remove the software node also on (ACPI) probe errors to > avoid leaking the underlying resources. > > Note that the software node is only used for ACPI probe so the driver > unbind tear down is updated to match probe. > > Fixes: 8dc6e6dd1bee ("usb: dwc3: qcom: Constify the software node") > Cc: stable@vger.kernel.org # 5.12 > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/dwc3/dwc3-qcom.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 00c3021b43ce..0703f9b85cda 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -932,10 +932,12 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > interconnect_exit: > dwc3_qcom_interconnect_exit(qcom); > depopulate: > - if (np) > + if (np) { > of_platform_depopulate(&pdev->dev); > - else > + } else { > + device_remove_software_node(&qcom->dwc3->dev); > platform_device_del(qcom->dwc3); > + } > platform_device_put(qcom->dwc3); > clk_disable: > for (i = qcom->num_clocks - 1; i >= 0; i--) { > @@ -955,11 +957,12 @@ static void dwc3_qcom_remove(struct platform_device *pdev) > struct device *dev = &pdev->dev; > int i; > > - device_remove_software_node(&qcom->dwc3->dev); > - if (np) > + if (np) { > of_platform_depopulate(&pdev->dev); > - else > + } else { > + device_remove_software_node(&qcom->dwc3->dev); > platform_device_del(qcom->dwc3); > + } > platform_device_put(qcom->dwc3); > > for (i = qcom->num_clocks - 1; i >= 0; i--) { > -- > 2.41.0
On Mon, Nov 20, 2023 at 05:53:10PM +0100, Johan Hovold wrote: > On Mon, Nov 20, 2023 at 09:22:54AM -0600, Andrew Halaney wrote: > > On Sat, Nov 18, 2023 at 12:47:30AM +0100, Konrad Dybcio wrote: > > > On 17.11.2023 18:36, Johan Hovold wrote: > > > > When reviewing the recently submitted series which reworks the dwc3 qcom > > > > glue implementation [1], I noticed that the driver's tear down handling > > > > is currently broken, something which can lead to memory leaks and > > > > potentially use-after-free issues on probe deferral and on driver > > > > unbind. > > > > > > > > Let's get this sorted before reworking driver. > > > > > > > > Note that the last patch has only been compile tested as I don't have > > > > access to a sdm845 device. > > > > I'll sound like a broken record, but: > > > > > > is there anyone in the world that is actively benefiting from this failed > > > experiment of using the ACPI tables that were shipped with these SoCs? > > > > > > There are so so so many shortcomings associated with it due to how Windows > > > drivers on these platforms know waaaay too much and largely use ACPI to > > > "bind driver x" and I simply think it doesn't make sense to continue > > > carrying this code forward given little use and no testing. > > > For what it is worth, I have agreed with your opinion on this every time > > I've read it. I am not the target audience of the question, but I'll at > > least give my personal (interpreted: uneducated? undesired?) opinion > > that the ACPI support in here adds little value and extra burden. > > > > Of course that topic is a bit independent of this series, but I'd be > > curious if a patchset removing the support would be welcomed or not by > > maintainers, so I'm stirring the pot by replying here :) > > I agree that if we can remove the ACPI hacks in here, we should try do > so (e.g. given that no one really uses it anymore). > > As Andrew already mentioned, that is a separate issue not directly > related to this series, though. > > Removing it before reworking the dwc3 binding [1] and adding multiport > support [2] should simplify both of those series quite a bit, however. > > Johan > > [1] https://lore.kernel.org/all/20231016-dwc3-refactor-v1-0-ab4a84165470@quicinc.com/ > [2] https://lore.kernel.org/all/20231007154806.605-1-quic_kriskura@quicinc.com/ > So should I apply this series now or not? confused, greg k-h
On Tue, Nov 21, 2023 at 03:21:34PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 20, 2023 at 05:53:10PM +0100, Johan Hovold wrote: > > On Mon, Nov 20, 2023 at 09:22:54AM -0600, Andrew Halaney wrote: > > > On Sat, Nov 18, 2023 at 12:47:30AM +0100, Konrad Dybcio wrote: > > > > On 17.11.2023 18:36, Johan Hovold wrote: > > > > > When reviewing the recently submitted series which reworks the dwc3 qcom > > > > > glue implementation [1], I noticed that the driver's tear down handling > > > > > is currently broken, something which can lead to memory leaks and > > > > > potentially use-after-free issues on probe deferral and on driver > > > > > unbind. > > > > > > > > > > Let's get this sorted before reworking driver. > > > > > > > > > > Note that the last patch has only been compile tested as I don't have > > > > > access to a sdm845 device. > > > > > > I'll sound like a broken record, but: > > > > > > > > is there anyone in the world that is actively benefiting from this failed > > > > experiment of using the ACPI tables that were shipped with these SoCs? > > I agree that if we can remove the ACPI hacks in here, we should try do > > so (e.g. given that no one really uses it anymore). > > > > As Andrew already mentioned, that is a separate issue not directly > > related to this series, though. > > > > Removing it before reworking the dwc3 binding [1] and adding multiport > > support [2] should simplify both of those series quite a bit, however. > > [1] https://lore.kernel.org/all/20231016-dwc3-refactor-v1-0-ab4a84165470@quicinc.com/ > > [2] https://lore.kernel.org/all/20231007154806.605-1-quic_kriskura@quicinc.com/ > > > > So should I apply this series now or not? Please do. Removing ACPI support should be done later if that's at all possible. Johan
On Tue, Nov 21, 2023 at 04:04:03PM +0100, Johan Hovold wrote: > On Tue, Nov 21, 2023 at 03:21:34PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 20, 2023 at 05:53:10PM +0100, Johan Hovold wrote: > > > On Mon, Nov 20, 2023 at 09:22:54AM -0600, Andrew Halaney wrote: > > > > On Sat, Nov 18, 2023 at 12:47:30AM +0100, Konrad Dybcio wrote: > > > > > On 17.11.2023 18:36, Johan Hovold wrote: > > > > > > When reviewing the recently submitted series which reworks the dwc3 qcom > > > > > > glue implementation [1], I noticed that the driver's tear down handling > > > > > > is currently broken, something which can lead to memory leaks and > > > > > > potentially use-after-free issues on probe deferral and on driver > > > > > > unbind. > > > > > > > > > > > > Let's get this sorted before reworking driver. > > > > > > > > > > > > Note that the last patch has only been compile tested as I don't have > > > > > > access to a sdm845 device. > > > > > > > > I'll sound like a broken record, but: > > > > > > > > > > is there anyone in the world that is actively benefiting from this failed > > > > > experiment of using the ACPI tables that were shipped with these SoCs? > > > > I agree that if we can remove the ACPI hacks in here, we should try do > > > so (e.g. given that no one really uses it anymore). > > > > > > As Andrew already mentioned, that is a separate issue not directly > > > related to this series, though. > > > > > > Removing it before reworking the dwc3 binding [1] and adding multiport > > > support [2] should simplify both of those series quite a bit, however. > > > > [1] https://lore.kernel.org/all/20231016-dwc3-refactor-v1-0-ab4a84165470@quicinc.com/ > > > [2] https://lore.kernel.org/all/20231007154806.605-1-quic_kriskura@quicinc.com/ > > > > > > > So should I apply this series now or not? > > Please do. Removing ACPI support should be done later if that's at all > possible. Great, now queued up, thanks. greg k-h