mbox series

[v4,0/3] usb: misc: onboard_usb_hub: add support for Cypress HX3 USB 3.0 family

Message ID 20230620-hx3-v4-0-e56b3c6db60b@skidata.com
Headers show
Series usb: misc: onboard_usb_hub: add support for Cypress HX3 USB 3.0 family | expand

Message

Benjamin Bara June 21, 2023, 6:04 p.m. UTC
Hi!

This series adds support for the Cypress HX3 USB 3.0 family (2/3). For
now, it just contains the USB-related aspects and ignores the option to
connect it via i2c (3/3).

As the HX3 family operates with two power supplies, multiple power
supply support is implemented (1/3).

Thanks & best regards,
Benjamin

---
Changes in v4:
- 1/3: set num_supplies=1 for the existing hubs
- 1/3: drop duplicate num_supplies in onboard_hub struct
- 1/3: clarify connection between supply_names and MAX_SUPPLIES
- Link to v3: https://lore.kernel.org/r/20230620-hx3-v3-0-2acbc03ca949@skidata.com

Changes in v3:
- 1/3: fix nits mentioned by Matthias
- Link to v2: https://lore.kernel.org/r/20230620-hx3-v2-0-76a53434c713@skidata.com

Changes in v2:
- don't re-order by VID/PID (thanks to Matthias)
- 1/3: replace (err != 0) with (err)
- Link to v1: https://lore.kernel.org/r/20230620-hx3-v1-0-3a649b34c85b@skidata.com

---
Benjamin Bara (3):
      usb: misc: onboard-hub: support multiple power supplies
      usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family
      dt-bindings: usb: Add binding for Cypress HX3 USB 3.0 family

 .../devicetree/bindings/usb/cypress,hx3.yaml       | 77 ++++++++++++++++++++++
 drivers/usb/misc/onboard_usb_hub.c                 | 45 ++++++++++---
 drivers/usb/misc/onboard_usb_hub.h                 | 14 ++++
 3 files changed, 128 insertions(+), 8 deletions(-)
---
base-commit: 45a3e24f65e90a047bef86f927ebdc4c710edaa1
change-id: 20230620-hx3-cb935b4fdd76

Best regards,

Comments

Rob Herring (Arm) June 22, 2023, 2:07 a.m. UTC | #1
On Wed, 21 Jun 2023 20:04:05 +0200, Benjamin Bara wrote:
> From: Benjamin Bara <benjamin.bara@skidata.com>
> 
> The HX3 family comes in different variants (up to 4 USB 3.0 ports;
> multi-TT), e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x.
> 
> This initial version of the binding only describes USB related aspects
> of the HX3 family, it does not cover the option of connecting the
> controller as an i2c slave.
> 
> Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>
> ---
>  .../devicetree/bindings/usb/cypress,hx3.yaml       | 77 ++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>