From patchwork Sun Jan 15 11:41:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna Kurapati X-Patchwork-Id: 643088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECE0C63797 for ; Sun, 15 Jan 2023 11:42:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231160AbjAOLmP (ORCPT ); Sun, 15 Jan 2023 06:42:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjAOLmN (ORCPT ); Sun, 15 Jan 2023 06:42:13 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB54EB760; Sun, 15 Jan 2023 03:42:12 -0800 (PST) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30FBg3HE000406; Sun, 15 Jan 2023 11:42:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=QVGdFZQoRLNxb5d+IsUWvu/Wu8swlbUVjNpTmkB7Y/A=; b=Bri4p+GfWrfeceOs8nT7or4pEDlpZr+1L6For2ahFKNBS+hUTaX0lqJhUM9gh0kkSRj8 5H8qO+dElPk/29ByLxUkkbmbZoZjbOVEoGF/1yetR7l5pm2mhIfJQKOQTl7vNfJ3xn0H Smol45Yrix+gzkDbbJ8U+Ip3A+ZJ7Cml/e4uKtKmD0SIneuWhcXawpTYGPrk8LBHyKbR fjVz94r4SFBXVldw3n1dsabHJ+g5MQn+aBZJ7uAtUqoy0ywAQ+TYjxkyIYITo0UFj7Xz XwgiKsKsDz5l2cX69adp8hBKnPZB4nic6gbAyPQX1jH6NfIiCXi3pjGP7u13zUzHW5Gc tA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n3hrwa37k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Jan 2023 11:42:03 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30FBg2bu012989 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Jan 2023 11:42:02 GMT Received: from hu-kriskura-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 15 Jan 2023 03:41:56 -0800 From: Krishna Kurapati To: Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , "Andy Gross" , Bjorn Andersson , "Konrad Dybcio" , Rob Herring , Krzysztof Kozlowski , Felipe Balbi CC: , , , , , , , , , Krishna Kurapati Subject: [RFC v4 0/5] Add multiport support for DWC3 controllers Date: Sun, 15 Jan 2023 17:11:41 +0530 Message-ID: <20230115114146.12628-1-quic_kriskura@quicinc.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 51XIz8H_9laBrMtF_nEC2TlkgLgqfp76 X-Proofpoint-ORIG-GUID: 51XIz8H_9laBrMtF_nEC2TlkgLgqfp76 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-15_07,2023-01-13_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1011 malwarescore=0 suspectscore=0 mlxlogscore=667 impostorscore=0 spamscore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301150089 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Currently the DWC3 driver supports only single port controller which requires at most two PHYs ie HS and SS PHYs. There are SoCs that has DWC3 controller with multiple ports that can operate in host mode. Some of the port supports both SS+HS and other port supports only HS mode. This change primarily refactors the Phy logic in core driver to allow multiport support with Generic Phy's. Chananges have been tested on QCOM SoC SA8295P which has 4 ports (2 are HS+SS capable and 2 are HS only capable). Changes in v4: Added DT support for SA8295p. Changes in v3: Incase any PHY init fails, then clear/exit the PHYs that are already initialized. Changes in v2: Changed dwc3_count_phys to return the number of PHY Phandles in the node. This will be used now in dwc3_extract_num_phys to increment num_usb2_phy and num_usb3_phy. Added new parameter "ss_idx" in dwc3_core_get_phy_ny_node and changed its structure such that the first half is for HS-PHY and second half is for SS-PHY. In dwc3_core_get_phy, for multiport controller, only if SS-PHY phandle is present, pass proper SS_IDX else pass -1. Link to v3: https://lore.kernel.org/all/1654709787-23686-1-git-send-email-quic_harshq@quicinc.com/#r Link to v2: https://lore.kernel.org/all/1653560029-6937-1-git-send-email-quic_harshq@quicinc.com/#r Krishna Kurapati (5): dt-bindings: usb: Add bindings to support multiport properties usb: dwc3: core: Refactor PHY logic to support Multiport Controller usb: dwc3: core: Do not setup event buffers for host only controllers usb: dwc3: qcom: Add multiport controller support for qcom wrapper arm: dts: msm: Add multiport controller node for usb .../devicetree/bindings/usb/snps,dwc3.yaml | 42 ++- arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 49 +++ arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 60 ++++ drivers/usb/dwc3/core.c | 325 +++++++++++++----- drivers/usb/dwc3/core.h | 15 +- drivers/usb/dwc3/drd.c | 14 +- drivers/usb/dwc3/dwc3-qcom.c | 28 +- 7 files changed, 429 insertions(+), 104 deletions(-)