| Message ID | 20221014095148.2063669-1-peng.fan@oss.nxp.com |
|---|---|
| Headers | show |
| Series | dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml | expand |
On 16/10/2022 23:17, Xu Yang wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Saturday, October 15, 2022 10:53 PM >> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>; gregkh@linuxfoundation.org; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de; Xu Yang <xu.yang_2@nxp.com> >> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>; >> Peng Fan <peng.fan@nxp.com> >> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema >> >> Caution: EXT Email >> >> On 14/10/2022 05:51, Peng Fan (OSS) wrote: >>> From: Peng Fan <peng.fan@nxp.com> >>> >>> Convert usbmisc-imx to DT schema format. >>> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>> --- >>> .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 +++++++++++++++++++ >>> .../devicetree/bindings/usb/usbmisc-imx.txt | 18 ------- >>> 2 files changed, 52 insertions(+), 18 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml >>> delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt >>> >>> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml >> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml >>> new file mode 100644 >>> index 000000000000..c83ffb6729b5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml >>> @@ -0,0 +1,52 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: >> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi >> sc.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C686ea1d3bc2b4c6 >> fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi >> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gNwMbGsiuMS1zgvbgATYAY70gv2nIhX%2F >> 16IxiSYBf3s%3D&reserved=0 >>> +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta- >> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C68 >> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA >> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jJUP5aKNkfkAefhNQL9almV >> Gqzn8cTNyjcRlZMOZwRk%3D&reserved=0 >>> + >>> +title: Freescale i.MX non-core registers >> >> You sent v2 before we finished this topic. Is it correct? Even if TXT >> had such title, let's don't keep the wrong name. >> >> If it is non-core registers, why it is in USB? Why it is an usb-misc device? > > The chipidea's doc has a more clear explanation about core and non-core > registers as follow: > > "There are two kinds of registers in the USB module: USB core registers > and USB non-core registers. USB core registers are used to control USB > core functions, and more independent of USB features. Each USB controller > core has its own core registers. USB non-core registers are additional > to USB core registers, and more dependent on USB features. i.MX series > products vary in non-core registers." > > So we have named it like this. "Freescale i.MX non-core registers" implies this hardware is about i.MX registers. i.MX like for all SoCs. What you wrote now, about USB registers - quite different. However if you describe here registers, not some device, usually it's place is not USB... And actually all devices are bunch of registers, right? So everything should be called registers? Name is poor choice, so please find more appropriate one matching real purpose of this block. Best regards, Krzysztof
From: Peng Fan <peng.fan@nxp.com> v2: patch order changed, usbmisc-imx moved to first Add Xu Yang as maintainer Typo fix Not define properties within if/then/else Set additionalProperties to false Drop duplicated compatibles Fix checkpatch issue For pinctrl-names: I think there is restrictin in allOf, so not list items Add fsl,usbmisc: ref Define items for mux-control-names Rename usbmisc-imx.yaml to fsl,usbmisc.yaml Hope I not miss any comments Note: there will still be dtbs_check failure if run with only a single patch, with this patchset applied, there is no related dtbs_check failure. This patchset is to convert ci-hdrc-usb2 and usbmisc-imx to yaml format. There are compatible strings not landed in binding doc, but in device tree, so run dtbs_check on the single yaml convertion patch will report dtbs_check failure. If apply the whole patchset, there will be no failure. Peng Fan (6): dt-bindings: usb: usbmisc-imx: convert to DT schema dt-bindings: usb: usbmisc-imx: add clocks property dt-bindings: usb: usbmisc-imx: add more i.MX compatible dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format dt-bindings: usb: ci-hdrc-usb2: add i.MX53/6SLL/UL compatible dt-bindings: usb: ci-hdrc-usb2: add i.MX8DXL/M[M,N] support .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 158 -------- .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 357 ++++++++++++++++++ .../devicetree/bindings/usb/fsl,usbmisc.yaml | 67 ++++ .../devicetree/bindings/usb/usbmisc-imx.txt | 18 - 4 files changed, 424 insertions(+), 176 deletions(-) delete mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt