mbox series

[v2,0/2] usb: dwc3: revert OTG changes for Intel Merrifield

Message ID 20220927155332.10762-1-andriy.shevchenko@linux.intel.com
Headers show
Series usb: dwc3: revert OTG changes for Intel Merrifield | expand

Message

Andy Shevchenko Sept. 27, 2022, 3:53 p.m. UTC
As agreed with the author, the v5.19 change is going to be reverted by
this series, so we will collaborate on a new one in the future that
brings no regressions.

Changelog v2:
- added Cc: stable@ and Fixes tags (Greg)
- rewritten cover letter to point out what the version is touched and
  what the decision made with the author of the original change (Greg)
- fixed the placement of one piece of code (Andrey)
- added Tested-by tags (Ferry)

Andy Shevchenko (2):
  Revert "USB: fixup for merge issue with "usb: dwc3: Don't switch OTG
    -> peripheral if extcon is present""
  Revert "usb: dwc3: Don't switch OTG -> peripheral if extcon is
    present"

 drivers/usb/dwc3/core.c | 50 +----------------------------------------
 drivers/usb/dwc3/drd.c  | 50 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 49 deletions(-)

Comments

Andrey Smirnov Oct. 17, 2022, 9:29 p.m. UTC | #1
On Tue, Sep 27, 2022 at 8:53 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> As agreed with the author, the v5.19 change is going to be reverted by
> this series, so we will collaborate on a new one in the future that
> brings no regressions.
>
> Changelog v2:
> - added Cc: stable@ and Fixes tags (Greg)
> - rewritten cover letter to point out what the version is touched and
>   what the decision made with the author of the original change (Greg)
> - fixed the placement of one piece of code (Andrey)
> - added Tested-by tags (Ferry)
>
> Andy Shevchenko (2):
>   Revert "USB: fixup for merge issue with "usb: dwc3: Don't switch OTG
>     -> peripheral if extcon is present""
>   Revert "usb: dwc3: Don't switch OTG -> peripheral if extcon is
>     present"
>

To spare everyone the need to read extra long thread in
[PATCH v2 2/2] Revert "usb: dwc3: Don't switch OTG -> peripheral if
extcon is present"

NAK, on the whole series. The regression doesn't repro on my
Edison/Merriefield setup and doesn't repro on the original reporter's
HW with my build, so it's very much unclear what's going on and what
the problem is and until it is the revert doesn't seem warranted.
Please don't apply this.

>  drivers/usb/dwc3/core.c | 50 +----------------------------------------
>  drivers/usb/dwc3/drd.c  | 50 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 51 insertions(+), 49 deletions(-)
>
> --
> 2.35.1
>
Thinh Nguyen Oct. 17, 2022, 10:22 p.m. UTC | #2
On Mon, Oct 17, 2022, Andrey Smirnov wrote:
> On Tue, Sep 27, 2022 at 8:53 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > As agreed with the author, the v5.19 change is going to be reverted by
> > this series, so we will collaborate on a new one in the future that
> > brings no regressions.
> >
> > Changelog v2:
> > - added Cc: stable@ and Fixes tags (Greg)
> > - rewritten cover letter to point out what the version is touched and
> >   what the decision made with the author of the original change (Greg)
> > - fixed the placement of one piece of code (Andrey)
> > - added Tested-by tags (Ferry)
> >
> > Andy Shevchenko (2):
> >   Revert "USB: fixup for merge issue with "usb: dwc3: Don't switch OTG
> >     -> peripheral if extcon is present""
> >   Revert "usb: dwc3: Don't switch OTG -> peripheral if extcon is
> >     present"
> >
> 
> To spare everyone the need to read extra long thread in
> [PATCH v2 2/2] Revert "usb: dwc3: Don't switch OTG -> peripheral if
> extcon is present"
> 
> NAK, on the whole series. The regression doesn't repro on my
> Edison/Merriefield setup and doesn't repro on the original reporter's
> HW with my build, so it's very much unclear what's going on and what
> the problem is and until it is the revert doesn't seem warranted.
> Please don't apply this.
> 

Thanks for your tests. The series was already applied. It's a bit messy,
but it seems like we need to revert series as there are already reports
that this it already breaks other setups.

Thanks,
Thinh