mbox series

[0/6] xhci features and fixes for usb-next

Message ID 20220921123450.671459-1-mathias.nyman@linux.intel.com
Headers show
Series xhci features and fixes for usb-next | expand

Message

Mathias Nyman Sept. 21, 2022, 12:34 p.m. UTC 
Hi Greg

Some xhci features and fixes for usb-next.
Both fixing some possible memory leaks that are too late for usb-linus,
and simple code cleanups for usb-next

Thanks
-Mathias

Jianglei Nie (1):
  usb: host: xhci: Fix potential memory leak in xhci_alloc_stream_info()

Mario Limonciello (1):
  xhci: Don't show warning for reinit on known broken suspend

Mathias Nyman (3):
  xhci: show fault reason for a failed enable slot command
  xhci: remove unused command member from struct xhci_hcd struct
  xhci: remove unused lpm_failed_dev member from struct xhci_hcd

Rafael Mendonca (1):
  xhci: dbc: Fix memory leak in xhci_alloc_dbc()

 drivers/usb/host/xhci-dbgcap.c | 2 +-
 drivers/usb/host/xhci-mem.c    | 7 ++++++-
 drivers/usb/host/xhci.c        | 6 ++++--
 drivers/usb/host/xhci.h        | 3 ---
 4 files changed, 11 insertions(+), 7 deletions(-)

Comments

Greg KH Sept. 22, 2022, 12:08 p.m. UTC | #1 
On Wed, Sep 21, 2022 at 03:34:44PM +0300, Mathias Nyman wrote:
> Hi Greg
> 
> Some xhci features and fixes for usb-next.
> Both fixing some possible memory leaks that are too late for usb-linus,
> and simple code cleanups for usb-next

Did you miss this one:
	https://lore.kernel.org/r/20220915011134.58400-1-liulongfang@huawei.com

or was there some issue with it?

thanks,

greg k-h
Mathias Nyman Sept. 22, 2022, 12:43 p.m. UTC | #2 
On 22.9.2022 15.08, Greg KH wrote:
> On Wed, Sep 21, 2022 at 03:34:44PM +0300, Mathias Nyman wrote:
>> Hi Greg
>>
>> Some xhci features and fixes for usb-next.
>> Both fixing some possible memory leaks that are too late for usb-linus,
>> and simple code cleanups for usb-next
> 
> Did you miss this one:
> 	https://lore.kernel.org/r/20220915011134.58400-1-liulongfang@huawei.com
> 
> or was there some issue with it?

Got distracted while looking at it.

Can be added but probably not that useful.

In a host controller error (HCE) case all host activity stops, so it would
make more sense to check HCE bit in timeout cases than in interrupt handler.

-Mathias
Greg KH Sept. 22, 2022, 12:52 p.m. UTC | #3 
On Thu, Sep 22, 2022 at 03:43:04PM +0300, Mathias Nyman wrote:
> On 22.9.2022 15.08, Greg KH wrote:
> > On Wed, Sep 21, 2022 at 03:34:44PM +0300, Mathias Nyman wrote:
> > > Hi Greg
> > > 
> > > Some xhci features and fixes for usb-next.
> > > Both fixing some possible memory leaks that are too late for usb-linus,
> > > and simple code cleanups for usb-next
> > 
> > Did you miss this one:
> > 	https://lore.kernel.org/r/20220915011134.58400-1-liulongfang@huawei.com
> > 
> > or was there some issue with it?
> 
> Got distracted while looking at it.
> 
> Can be added but probably not that useful.
> 
> In a host controller error (HCE) case all host activity stops, so it would
> make more sense to check HCE bit in timeout cases than in interrupt handler.

Ok, no worries, I'll drop it from my review queue, but you should
respond to the patch submission with this information.

thanks,

greg k-h