mbox series

[v3,0/3] rndis_host: handle bogus MAC addresses in ZTE RNDIS devices

Message ID 20220413014416.2306843-1-lech.perczak@gmail.com
Headers show
Series rndis_host: handle bogus MAC addresses in ZTE RNDIS devices | expand

Message

Lech Perczak April 13, 2022, 1:44 a.m. UTC 
When porting support of ZTE MF286R to OpenWrt [1], it was discovered,
that its built-in LTE modem fails to adjust its target MAC address,
when a random MAC address is assigned to the interface, due to detection of
"locally-administered address" bit. This leads to dropping of ingress
trafficat the host. The modem uses RNDIS as its primary interface,
with some variants exposing both of them simultaneously.

Then it was discovered, that cdc_ether driver contains a fixup for that
exact issue, also appearing on CDC ECM interfaces.
I discussed how to proceed with that with Bjørn Mork at OpenWrt forum [3],
with the first approach would be to trust the locally-administered MAC
again, and add a quirk for the problematic ZTE devices, as suggested by
Kristian Evensen. before [4], but reusing the fixup from cdc_ether looks
like a safer and more generic solution.

Finally, according to Bjørn's suggestion. limit the scope of bogus MAC
addressdetection to ZTE devices, the same way as it is done in cdc_ether,
as this trait wasn't really observed outside of ZTE devices.
Do that for both flavours of RNDIS devices, with interface classes
02/02/ff and e0/01/03, as both types are reported by different modems.

[1] https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=7ac8da00609f42b8aba74b7efc6b0d055b7cef3e
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bfe9b9d2df669a57a95d641ed46eb018e204c6ce
[3] https://forum.openwrt.org/t/problem-with-modem-in-zte-mf286r/120988
[4] https://lore.kernel.org/all/CAKfDRXhDp3heiD75Lat7cr1JmY-kaJ-MS0tt7QXX=s8RFjbpUQ@mail.gmail.com/T/

Cc: Bjørn Mork <bjorn@mork.no>
Cc: Kristian Evensen <kristian.evensen@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>

v3: Fixed wrong identifier commit description and whitespace in patch 2.

v2: ensure that MAC fixup is applied to all Ethernet frames in RNDIS
batch, by introducing a driver flag, and integrating the fixup inside
rndis_rx_fixup().

Lech Perczak (3):
  cdc_ether: export usbnet_cdc_zte_rx_fixup
  rndis_host: enable the bogus MAC fixup for ZTE devices from cdc_ether
  rndis_host: limit scope of bogus MAC address detection to ZTE devices

 drivers/net/usb/cdc_ether.c    |  3 ++-
 drivers/net/usb/rndis_host.c   | 47 +++++++++++++++++++++++++++++++---
 include/linux/usb/rndis_host.h |  1 +
 include/linux/usb/usbnet.h     |  1 +
 4 files changed, 47 insertions(+), 5 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 14, 2022, 1:30 p.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 13 Apr 2022 03:44:13 +0200 you wrote:
> When porting support of ZTE MF286R to OpenWrt [1], it was discovered,
> that its built-in LTE modem fails to adjust its target MAC address,
> when a random MAC address is assigned to the interface, due to detection of
> "locally-administered address" bit. This leads to dropping of ingress
> trafficat the host. The modem uses RNDIS as its primary interface,
> with some variants exposing both of them simultaneously.
> 
> [...]

Here is the summary with links:
  - [v3,1/3] cdc_ether: export usbnet_cdc_zte_rx_fixup
    https://git.kernel.org/netdev/net-next/c/64b97df995f0
  - [v3,2/3] rndis_host: enable the bogus MAC fixup for ZTE devices from cdc_ether
    https://git.kernel.org/netdev/net-next/c/36e747972d8b
  - [v3,3/3] rndis_host: limit scope of bogus MAC address detection to ZTE devices
    https://git.kernel.org/netdev/net-next/c/171cfae6b78c

You are awesome, thank you!