mbox series

[0/1] USB: usbfs: replace atomic64 accesses by spinlock

Message ID 20220208204858.3406-1-ingo.rohloff@lauterbach.com
Headers show
Series USB: usbfs: replace atomic64 accesses by spinlock | expand

Message

Ingo Rohloff Feb. 8, 2022, 8:48 p.m. UTC 
patch for f_fs.c:
> > > > + atomic64_sub(amount, &ffs->mmap_mem_usage);    

Greg KH:
> > > Why not use a real lock instead of trying to do a fake one with
> > > this atomic variable?

Ingo:
> > I just took the code from "drivers/usb/core/devio.c",
> > "usbfs_increase_memory_usage()".
> > ...
> > You are of course right: You can easily use a lock here and this
> > makes the intention of the code a lot clearer I guess.
> > 
> > I will modify the patch accordingly.  

Alan Stern:
> If you also feel like making a similar change to the code in devio.c,
> it would be welcome.

Ingo Rohloff (1):
  USB: usbfs: Use a spinlock instead of atomic accesses to tally used
    memory.

 drivers/usb/core/devio.c | 35 ++++++++++++++++++++++++-----------
 1 file changed, 24 insertions(+), 11 deletions(-)