From patchwork Thu Aug 26 11:14:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 503624 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8485AC432BE for ; Thu, 26 Aug 2021 11:14:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DEA5610A1 for ; Thu, 26 Aug 2021 11:14:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241887AbhHZLPZ (ORCPT ); Thu, 26 Aug 2021 07:15:25 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:34888 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233961AbhHZLPY (ORCPT ); Thu, 26 Aug 2021 07:15:24 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 17QBEVOK023451; Thu, 26 Aug 2021 06:14:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1629976471; bh=Rm6viFhQnwzHijJ6vB5Rhbtxd/A4Bh8mIogxI7joTB4=; h=From:To:CC:Subject:Date; b=tAipZCfQezZi0V0dyoDNlRWY6hfdZ2LWa//hRSr1gMUy0DOHCDblhtWKb10gCDaGM R6WYksxcP8C1e0jylGn3g64K5DkbmCCYQZRxJXWg4a1xl2RjYv5fFnYbo0gPuyih+o RmdcAphz6NEoXPoxJJ+B1WLDZfwtLyS+/eXQQzfk= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 17QBEVKD129141 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 26 Aug 2021 06:14:31 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 26 Aug 2021 06:14:31 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 26 Aug 2021 06:14:31 -0500 Received: from a0393678-lt.ent.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 17QBERXf053369; Thu, 26 Aug 2021 06:14:28 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , Mathias Nyman , Alan Stern CC: , , , Kishon Vijay Abraham I , Subject: [PATCH v2 0/3] Fix cold plugged USB device on certain PCIe USB cards Date: Thu, 26 Aug 2021 16:44:23 +0530 Message-ID: <20210826111426.751-1-kishon@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Cold plugged USB device was not detected on certain PCIe USB cards (like Inateck card connected to AM64 EVM or connected to J7200 EVM). Re-plugging the USB device always gets it enumerated. This issue was discussed in https://lore.kernel.org/r/772e4001-178e-4918-032c-6e625bdded24@ti.com and https://bugzilla.kernel.org/show_bug.cgi?id=214021 So the suggested solution is to register both root hubs along with the second hcd for xhci. RFC Patch series can be found at [1] v1 Patch series can be found at [3] Changes from RFC: 1) Mathias identified potential issues with the RFC patch [2] and suggested the solution to use HCD flags. This series implements it. Changes from v1: 1) Fixed code comments pointed out by Alan Stern 2) Renamed the HCD flag variable to "HCD_FLAG_DEFER_RH_REGISTER" from "HCD_FLAG_DEFER_PRI_RH_REGISTER" [1] -> https://lore.kernel.org/linux-usb/20210824105302.25382-1-kishon@ti.com/ [2] -> https://lore.kernel.org/linux-usb/06693934-28f2-d59e-b004-62cabd3f9e8e@linux.intel.com [3] -> https://lore.kernel.org/r/20210825105132.10420-1-kishon@ti.com Kishon Vijay Abraham I (3): usb: core: hcd: Modularize HCD stop configuration in usb_stop_hcd() usb: core: hcd: Add support for deferring roothub registration xhci: Set HCD flag to defer primary roothub registration drivers/usb/core/hcd.c | 66 +++++++++++++++++++++++++++-------------- drivers/usb/host/xhci.c | 1 + include/linux/usb/hcd.h | 2 ++ 3 files changed, 47 insertions(+), 22 deletions(-)