From patchwork Sun May 23 01:58:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Tso X-Patchwork-Id: 446784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A69B2C4707F for ; Sun, 23 May 2021 01:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73D5A610A6 for ; Sun, 23 May 2021 01:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231510AbhEWCAh (ORCPT ); Sat, 22 May 2021 22:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231495AbhEWCAh (ORCPT ); Sat, 22 May 2021 22:00:37 -0400 Received: from mail-qk1-x749.google.com (mail-qk1-x749.google.com [IPv6:2607:f8b0:4864:20::749]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34C22C061574 for ; Sat, 22 May 2021 18:59:11 -0700 (PDT) Received: by mail-qk1-x749.google.com with SMTP id g184-20020a3784c10000b02902e385de9adaso21877506qkd.3 for ; Sat, 22 May 2021 18:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=gkLitXCysUfPWd1vthRlHismljQQpCoyX2uioWTbGjo=; b=KjZuLOik6YzwXXxa1/EGmSJC68v+G+P4alXalcix6F2kB8rJTil1Qa1OY1SD6fA2A9 YHgN0IwOakQ3mZ+1deUHzZG05SPQ8w1OdAcEog0BTVDPtECfM/Do6Yd+qi/M0LrD8vsv vOLXON93oX3l4pGDqvMBFWRJqXW/VRA1XFNzAQ1jdJFrcQJFnHapK1U3ihVLRsXOsZSX USXC7EwSA1y+FW7+Am2aoUUh9N8c0cXZtz8sove1zpo1df0ftsuCK9H5Gsqy87RynH9r QcUILM/HIp2IIbCRm1Q/s+P9Izl+mBCZcmdSJ+MNn10RY2HlA8LapBv58D51ZRv6aPsX EpQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=gkLitXCysUfPWd1vthRlHismljQQpCoyX2uioWTbGjo=; b=MkJprJe2khlJRsVC1HSzkDzvwyXFjfojHBeGhyZ5vLrzvtzF9g7cJlSPcyNvW+qUls vlLg5Iv3H3+sjDOJ1gyX5ftT7JC4n7dd7c5aFei5r9VzvGJTUuQPPybpLlsp+l1iBZ8L yHMO1PIlrLkwBQ1O76cLV2rAh3PRM8V4EBJMU5NV+DKgYjO6YU1Z+4MfOo7EvhBw8gZo +Ugk3iwqAxAqwpJRE9zgeI+nqrARZJ3N7D+/66PhI6cJGRAzCN3oSjMGeAQdtjy1dUAm sUyN0VcVK1Zx/71ZNPWoJiB2EGflD2W2H2NvmTL8ijL8ZgDWhkVR+zTy/cc+Ye5KYED4 WrqQ== X-Gm-Message-State: AOAM5337PWdycWPdlFKZECtIV7FLSRI0v9P6SiWrgscW4x3uyyOfqo0v NguXkhZ1ftOVlyX0zus9Znu5wlAAfVDW X-Google-Smtp-Source: ABdhPJxU6qBBICdn+ZuNNsyj44M2wrpMAmLYiIJ80G8W/9X4uKYj4Qnyq+6HybDfxKhjZ/tNXmzJy6uusDXt X-Received: from kyletso.ntc.corp.google.com ([2401:fa00:fc:202:7015:3f20:3a0c:ecc2]) (user=kyletso job=sendgmr) by 2002:a05:6214:288:: with SMTP id l8mr21751315qvv.21.1621735150088; Sat, 22 May 2021 18:59:10 -0700 (PDT) Date: Sun, 23 May 2021 09:58:53 +0800 Message-Id: <20210523015855.1785484-1-kyletso@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.31.1.818.g46aad6cb9e-goog Subject: [PATCH v2 0/2] Fix some VDM AMS handling From: Kyle Tso To: linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, Kyle Tso Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Changes since v1: ----------------- usb: typec: tcpm: Properly interrupt VDM AMS - fix the bug reported by "kernel test robot " - add Reviewed-by: tag from Guenter usb: typec: tcpm: Respond Not_Supported if no snk_vdo - no changes in code - add Reviewed-by: tag from Guenter v1 cover letter: ---------------- usb: typec: tcpm: Properly interrupt VDM AMS - If VDM AMS is interrupted by Messages other than VDM, the current VDM AMS should be finished before handling the just arrived request. I add intercept code in the beginning of the handler of the three types of requests (control/data/extended) to ensure that the AMS is finished first. usb: typec: tcpm: Respond Not_Supported if no snk_vdo - The snk_vdo is for the responses to incoming VDM Discover Identity. If there is no data in snk_vdo, it means that the port doesn't even support it. According to PD3 Spec "Table 6-64 Response to an incoming VDM", the port should send Not_Supported Message as the response. For PD2 cases, it is defined in PD2 Spec "Table 6-41 Applicability of Structured VDM Commands - Note 3" that the port should "Ignore" the command. Kyle Tso (2): usb: typec: tcpm: Properly interrupt VDM AMS usb: typec: tcpm: Respond Not_Supported if no snk_vdo drivers/usb/typec/tcpm/tcpm.c | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)