mbox series

[0/6] USB: serial: buffer-callback clean ups

Message ID 20210519092006.9775-1-johan@kernel.org
Headers show
Series USB: serial: buffer-callback clean ups | expand

Message

Johan Hovold May 19, 2021, 9:20 a.m. UTC 
This series clean up a few things related to the chars_in_buffer and
write_room callbacks that were found during review of the recent
conversion to have these callbacks return an unsigned int.

Johan


Johan Hovold (6):
  USB: serial: digi_acceleport: reduce chars_in_buffer over-reporting
  USB: serial: digi_acceleport: add chars_in_buffer locking
  USB: serial: io_edgeport: drop buffer-callback sanity checks
  USB: serial: mos7720: drop buffer-callback sanity checks
  USB: serial: mos7840: drop buffer-callback return-value comments
  USB: serial: drop irq-flags initialisations

 drivers/usb/serial/digi_acceleport.c | 34 ++++++++++++++--------------
 drivers/usb/serial/io_edgeport.c     | 27 +---------------------
 drivers/usb/serial/metro-usb.c       | 12 +++++-----
 drivers/usb/serial/mos7720.c         | 17 ++------------
 drivers/usb/serial/mos7840.c         |  5 ----
 drivers/usb/serial/quatech2.c        |  2 +-
 6 files changed, 27 insertions(+), 70 deletions(-)

Comments

Greg KH May 21, 2021, 12:22 p.m. UTC | #1 
On Wed, May 19, 2021 at 11:20:00AM +0200, Johan Hovold wrote:
> This series clean up a few things related to the chars_in_buffer and

> write_room callbacks that were found during review of the recent

> conversion to have these callbacks return an unsigned int.

> 

> Johan

> 

> 

> Johan Hovold (6):

>   USB: serial: digi_acceleport: reduce chars_in_buffer over-reporting

>   USB: serial: digi_acceleport: add chars_in_buffer locking

>   USB: serial: io_edgeport: drop buffer-callback sanity checks

>   USB: serial: mos7720: drop buffer-callback sanity checks

>   USB: serial: mos7840: drop buffer-callback return-value comments

>   USB: serial: drop irq-flags initialisations

> 

>  drivers/usb/serial/digi_acceleport.c | 34 ++++++++++++++--------------

>  drivers/usb/serial/io_edgeport.c     | 27 +---------------------

>  drivers/usb/serial/metro-usb.c       | 12 +++++-----

>  drivers/usb/serial/mos7720.c         | 17 ++------------

>  drivers/usb/serial/mos7840.c         |  5 ----

>  drivers/usb/serial/quatech2.c        |  2 +-

>  6 files changed, 27 insertions(+), 70 deletions(-)


Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold May 21, 2021, 1:48 p.m. UTC | #2 
On Fri, May 21, 2021 at 02:22:26PM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 19, 2021 at 11:20:00AM +0200, Johan Hovold wrote:

> > This series clean up a few things related to the chars_in_buffer and

> > write_room callbacks that were found during review of the recent

> > conversion to have these callbacks return an unsigned int.

> > 

> > Johan

> > 

> > 

> > Johan Hovold (6):

> >   USB: serial: digi_acceleport: reduce chars_in_buffer over-reporting

> >   USB: serial: digi_acceleport: add chars_in_buffer locking

> >   USB: serial: io_edgeport: drop buffer-callback sanity checks

> >   USB: serial: mos7720: drop buffer-callback sanity checks

> >   USB: serial: mos7840: drop buffer-callback return-value comments

> >   USB: serial: drop irq-flags initialisations

> > 

> >  drivers/usb/serial/digi_acceleport.c | 34 ++++++++++++++--------------

> >  drivers/usb/serial/io_edgeport.c     | 27 +---------------------

> >  drivers/usb/serial/metro-usb.c       | 12 +++++-----

> >  drivers/usb/serial/mos7720.c         | 17 ++------------

> >  drivers/usb/serial/mos7840.c         |  5 ----

> >  drivers/usb/serial/quatech2.c        |  2 +-

> >  6 files changed, 27 insertions(+), 70 deletions(-)

> 

> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


Thanks for reviewing. Now applied.

Johan