| Message ID | 20210114145053.1952756-1-kyletso@google.com |
|---|---|
| Headers | show |
| Series | AMS, Collision Avoidance, and Protocol Error | expand |
Hi All, On 1/14/21 3:50 PM, Kyle Tso wrote: > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com > > "usb: typec: tcpm: AMS and Collision Avoidance" > - removed the signed-off > - modified the coding style suggested from Heikki > - added FR_SWAP AMS handling > > "usb: typec: tcpm: Protocol Error handling" > - removed the signed-off > - modified the coding style suggested from Heikki > - modified more coding style problems (line wrapping limit) > > "usb: typec: tcpm: Respond Wait if VDM state machine is running" > - no change I'm afraid that my testing of this patch-set has been delayed due to a 5.11 regression which I'm chasing down. I have put a task for this in my calendar for Wednesday Jan 20. Regards, Hans
Hi, On 1/14/21 3:50 PM, Kyle Tso wrote: > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com > > "usb: typec: tcpm: AMS and Collision Avoidance" > - removed the signed-off > - modified the coding style suggested from Heikki > - added FR_SWAP AMS handling > > "usb: typec: tcpm: Protocol Error handling" > - removed the signed-off > - modified the coding style suggested from Heikki > - modified more coding style problems (line wrapping limit) > > "usb: typec: tcpm: Respond Wait if VDM state machine is running" > - no change I've finally gotten around to testing this. I'm happy to report that the power-role swapping regression seen in one of the older versions of this patch-set is gone. So the entire series is: Tested-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > ------------------------------------------------------------------- > > Kyle Tso (3): > usb: typec: tcpm: AMS and Collision Avoidance > usb: typec: tcpm: Protocol Error handling > usb: typec: tcpm: Respond Wait if VDM state machine is running > > drivers/usb/typec/tcpm/tcpm.c | 1001 +++++++++++++++++++++++++++------ > include/linux/usb/pd.h | 2 + > include/linux/usb/tcpm.h | 4 + > 3 files changed, 829 insertions(+), 178 deletions(-) >
On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote: > Hi, > > On 1/14/21 3:50 PM, Kyle Tso wrote: > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com > > > > "usb: typec: tcpm: AMS and Collision Avoidance" > > - removed the signed-off > > - modified the coding style suggested from Heikki > > - added FR_SWAP AMS handling > > > > "usb: typec: tcpm: Protocol Error handling" > > - removed the signed-off > > - modified the coding style suggested from Heikki > > - modified more coding style problems (line wrapping limit) > > > > "usb: typec: tcpm: Respond Wait if VDM state machine is running" > > - no change > > I've finally gotten around to testing this. I'm happy to > report that the power-role swapping regression seen in one > of the older versions of this patch-set is gone. > > So the entire series is: > Tested-by: Hans de Goede <hdegoede@redhat.com> Thanks for testing and the review. Heikki, any thoughts? thanks, greg k-h
On Wed, Jan 20, 2021 at 06:17:35PM +0100, Greg KH wrote: > On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote: > > Hi, > > > > On 1/14/21 3:50 PM, Kyle Tso wrote: > > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com > > > > > > "usb: typec: tcpm: AMS and Collision Avoidance" > > > - removed the signed-off > > > - modified the coding style suggested from Heikki > > > - added FR_SWAP AMS handling > > > > > > "usb: typec: tcpm: Protocol Error handling" > > > - removed the signed-off > > > - modified the coding style suggested from Heikki > > > - modified more coding style problems (line wrapping limit) > > > > > > "usb: typec: tcpm: Respond Wait if VDM state machine is running" > > > - no change > > > > I've finally gotten around to testing this. I'm happy to > > report that the power-role swapping regression seen in one > > of the older versions of this patch-set is gone. > > > > So the entire series is: > > Tested-by: Hans de Goede <hdegoede@redhat.com> > > Thanks for testing and the review. > > Heikki, any thoughts? Looks good to me. Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> -- heikki
On 1/14/21 6:50 AM, Kyle Tso wrote: > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com > > "usb: typec: tcpm: AMS and Collision Avoidance" > - removed the signed-off > - modified the coding style suggested from Heikki > - added FR_SWAP AMS handling > > "usb: typec: tcpm: Protocol Error handling" > - removed the signed-off > - modified the coding style suggested from Heikki > - modified more coding style problems (line wrapping limit) > > "usb: typec: tcpm: Respond Wait if VDM state machine is running" > - no change > > ------------------------------------------------------------------- > > Kyle Tso (3): > usb: typec: tcpm: AMS and Collision Avoidance > usb: typec: tcpm: Protocol Error handling > usb: typec: tcpm: Respond Wait if VDM state machine is running > > drivers/usb/typec/tcpm/tcpm.c | 1001 +++++++++++++++++++++++++++------ > include/linux/usb/pd.h | 2 + > include/linux/usb/tcpm.h | 4 + > 3 files changed, 829 insertions(+), 178 deletions(-) > For the series: Reviewed-by: Guenter Roeck <linux@roeck-us.net> Guenter