mbox series

[0/2] Remove one more platform_device_add_properties() call

Message ID 20201123153148.52647-1-heikki.krogerus@linux.intel.com
Headers show
Series Remove one more platform_device_add_properties() call | expand

Message

Heikki Krogerus Nov. 23, 2020, 3:31 p.m. UTC 
Hi,

I originally introduced these as part of my series where I was
proposing PM ops for software nodes [1], but since that still needs
work, I'm sending these two separately.

So basically I'm only modifying dwc3-pci.c so it registers a software
node directly at this point. That will remove one more user of
platform_device_add_properties().

[1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@linux.intel.com/

thanks,

Heikki Krogerus (2):
  software node: Introduce device_add_software_node()
  usb: dwc3: pci: Register a software node for the dwc3 platform device

 drivers/base/swnode.c       | 69 ++++++++++++++++++++++++++++++++-----
 drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++-------------
 include/linux/property.h    |  3 ++
 3 files changed, 100 insertions(+), 33 deletions(-)

Comments

Rafael J. Wysocki Nov. 23, 2020, 5:06 p.m. UTC | #1 
On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> Hi,
>
> I originally introduced these as part of my series where I was
> proposing PM ops for software nodes [1], but since that still needs
> work, I'm sending these two separately.
>
> So basically I'm only modifying dwc3-pci.c so it registers a software
> node directly at this point. That will remove one more user of
> platform_device_add_properties().
>
> [1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@linux.intel.com/
>
> thanks,
>
> Heikki Krogerus (2):
>   software node: Introduce device_add_software_node()
>   usb: dwc3: pci: Register a software node for the dwc3 platform device
>
>  drivers/base/swnode.c       | 69 ++++++++++++++++++++++++++++++++-----
>  drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++-------------
>  include/linux/property.h    |  3 ++
>  3 files changed, 100 insertions(+), 33 deletions(-)
>
> --

These look good to me.

If you want me to take them, though, I need an ACK from the dwc3 side.
Heikki Krogerus Jan. 11, 2021, 12:56 p.m. UTC | #2 
On Fri, Dec 04, 2020 at 01:23:22PM +0200, Heikki Krogerus wrote:
> Hi Felipe,
> 
> On Mon, Nov 23, 2020 at 06:06:31PM +0100, Rafael J. Wysocki wrote:
> > On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus
> > <heikki.krogerus@linux.intel.com> wrote:
> > >
> > > Hi,
> > >
> > > I originally introduced these as part of my series where I was
> > > proposing PM ops for software nodes [1], but since that still needs
> > > work, I'm sending these two separately.
> > >
> > > So basically I'm only modifying dwc3-pci.c so it registers a software
> > > node directly at this point. That will remove one more user of
> > > platform_device_add_properties().
> > >
> > > [1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@linux.intel.com/
> > >
> > > thanks,
> > >
> > > Heikki Krogerus (2):
> > >   software node: Introduce device_add_software_node()
> > >   usb: dwc3: pci: Register a software node for the dwc3 platform device
> > >
> > >  drivers/base/swnode.c       | 69 ++++++++++++++++++++++++++++++++-----
> > >  drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++-------------
> > >  include/linux/property.h    |  3 ++
> > >  3 files changed, 100 insertions(+), 33 deletions(-)
> > >
> > > --
> > 
> > These look good to me.
> > 
> > If you want me to take them, though, I need an ACK from the dwc3 side.
> 
> Is this OK?

I think this went under you radar, so I'll resend these.

Br,