| Message ID | 20201106165805.31534-1-amelie.delaunay@st.com |
|---|---|
| Headers | show |
| Series | STUSB1600 support on STM32MP15xx-DKx | expand |
Hi Greg, gentle reminder for this patch, lost in the middle of a DT series (DT part already in stm32-next). Thanks and regards, Amelie On 11/6/20 5:58 PM, Amelie Delaunay wrote: > Device tree property is named typec-power-opmode, not power-opmode. > > Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family") > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/stusb160x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c > index 2a618f02f4f1..d21750bbbb44 100644 > --- a/drivers/usb/typec/stusb160x.c > +++ b/drivers/usb/typec/stusb160x.c > @@ -562,7 +562,7 @@ static int stusb160x_get_fw_caps(struct stusb160x *chip, > * Supported power operation mode can be configured through device tree > * else it is read from chip registers in stusb160x_get_caps. > */ > - ret = fwnode_property_read_string(fwnode, "power-opmode", &cap_str); > + ret = fwnode_property_read_string(fwnode, "typec-power-opmode", &cap_str); > if (!ret) { > ret = typec_find_pwr_opmode(cap_str); > /* Power delivery not yet supported */ >
On 11/27/20 2:07 PM, Greg Kroah-Hartman wrote: > On Fri, Nov 27, 2020 at 02:01:29PM +0100, Amelie DELAUNAY wrote: >> Hi Greg, >> >> gentle reminder for this patch, lost in the middle of a DT series (DT part >> already in stm32-next). > > Odd, I don't see this anymore, can you resend just this one so I can > apply it directly? Sure :) I rebase it and send it right now. Amelie
This series adds missing bindings for Type-C typec-power-opmode property and STUSB160x Type-C port controllers [1]. STUSB160x driver requires to get power operation mode via device tree, that's why this series also adds the optional DT property typec-power-opmode for usb-c-connector to select the power operation mode capability. Tested on stm32mp157c-dk2 [2], which has a Type-C connector managed by STUSB1600, and connected to USB OTG controller. [1] https://www.st.com/en/interfaces-and-transceivers/usb-type-c-and-power-delivery-controllers.html [2] https://www.st.com/en/evaluation-tools/stm32mp157c-dk2.html Amelie Delaunay (5): dt-bindings: connector: add typec-power-opmode property to usb-connector dt-bindings: usb: Add DT bindings for STUSB160x Type-C controller usb: typec: stusb160x: fix power-opmode property with typec-power-opmode ARM: dts: stm32: add STUSB1600 Type-C using I2C4 on stm32mp15xx-dkx ARM: multi_v7_defconfig: enable STUSB160X Type-C port controller support --- Changes in v5: - add additionalProperties to st,stusb160x yaml - add Heikki reviewed-by on stusb160x driver patch 3/5 Changes in v4: - power-opmode DT property renamed to typec-power-opmode and mutually exclusive condition with new-source-frs-typec-current added - Due to DT property renaming, patch 3/5 is added to update stusb160x driver. --- .../bindings/connector/usb-connector.yaml | 24 +++++ .../devicetree/bindings/usb/st,stusb160x.yaml | 87 +++++++++++++++++++ arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 7 ++ arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 30 +++++++ arch/arm/configs/multi_v7_defconfig | 2 + drivers/usb/typec/stusb160x.c | 2 +- 6 files changed, 151 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/usb/st,stusb160x.yaml