| Message ID | 20231125092137.2948-2-amit.kumar-mahapatra@amd.com |
|---|---|
| State | Accepted |
| Commit | 4ae08845db4c1f759b8382bc7527ab8249230e7f |
| Headers | show |
| Series | spi: Add support for stacked/parallel memories | expand |
On Sat, 25 Nov 2023 14:51:28 +0530, Amit Kumar Mahapatra wrote: > In preparation for adding multiple CS support for a device, set/get > functions were introduces accessing spi->chip_select in > 'commit 303feb3cc06a ("spi: Add APIs in spi core to set/get > spi->chip_select and spi->cs_gpiod")'. > Replace spi->chip_select with spi_get_chipselect() API. > > > [...] Applied, thanks! [01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select commit: dd636638446c87c95c5beddcd367d95ac6764c6c -- Lee Jones [李琼斯]
On Fri, Dec 01, 2023 at 09:57:36AM +0000, Lee Jones wrote: > On Sat, 25 Nov 2023 14:51:28 +0530, Amit Kumar Mahapatra wrote: > > In preparation for adding multiple CS support for a device, set/get > > functions were introduces accessing spi->chip_select in > > 'commit 303feb3cc06a ("spi: Add APIs in spi core to set/get > > spi->chip_select and spi->cs_gpiod")'. > > Replace spi->chip_select with spi_get_chipselect() API. > Applied, thanks! > [01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select > commit: dd636638446c87c95c5beddcd367d95ac6764c6c Is there a signed tag available for this - without this change the subsequent SPI changes introduce a build breakage.
On Fri, 01 Dec 2023, Mark Brown wrote: > On Fri, Dec 01, 2023 at 09:57:36AM +0000, Lee Jones wrote: > > On Sat, 25 Nov 2023 14:51:28 +0530, Amit Kumar Mahapatra wrote: > > > In preparation for adding multiple CS support for a device, set/get > > > functions were introduces accessing spi->chip_select in > > > 'commit 303feb3cc06a ("spi: Add APIs in spi core to set/get > > > spi->chip_select and spi->cs_gpiod")'. > > > Replace spi->chip_select with spi_get_chipselect() API. > > > Applied, thanks! > > > [01/10] mfd: tps6594: Use set/get APIs to access spi->chip_select > > commit: dd636638446c87c95c5beddcd367d95ac6764c6c > > Is there a signed tag available for this - without this change the > subsequent SPI changes introduce a build breakage. Not yet, but I can get around to making one.
On Thu, Dec 07, 2023 at 01:38:49PM +0000, Lee Jones wrote: > Good afternoon Mark, > > > Is there a signed tag available for this - without this change the > > subsequent SPI changes introduce a build breakage. > > The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86: > > Linux 6.7-rc1 (2023-11-12 16:19:07 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-spi-v6.8 > > for you to fetch changes up to 4ae08845db4c1f759b8382bc7527ab8249230e7f: > > mfd: tps6594: Use spi_get_chipselect() API to access spi->chip_select (2023-12-07 13:36:29 +0000) Thanks!
diff --git a/drivers/mfd/tps6594-spi.c b/drivers/mfd/tps6594-spi.c index f4b4f37f957f..24b72847e3f5 100644 --- a/drivers/mfd/tps6594-spi.c +++ b/drivers/mfd/tps6594-spi.c @@ -98,7 +98,7 @@ static int tps6594_spi_probe(struct spi_device *spi) spi_set_drvdata(spi, tps); tps->dev = dev; - tps->reg = spi->chip_select; + tps->reg = spi_get_chipselect(spi, 0); tps->irq = spi->irq; tps->regmap = devm_regmap_init(dev, NULL, spi, &tps6594_spi_regmap_config);
In preparation for adding multiple CS support for a device, set/get functions were introduces accessing spi->chip_select in 'commit 303feb3cc06a ("spi: Add APIs in spi core to set/get spi->chip_select and spi->cs_gpiod")'. Replace spi->chip_select with spi_get_chipselect() API. Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com> --- drivers/mfd/tps6594-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)