From patchwork Sat Sep 16 16:12:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 723879 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5915BC2BA12 for ; Sat, 16 Sep 2023 16:13:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbjIPQNO (ORCPT ); Sat, 16 Sep 2023 12:13:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238309AbjIPQMp (ORCPT ); Sat, 16 Sep 2023 12:12:45 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 145CACC6 for ; Sat, 16 Sep 2023 09:12:40 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhXuQ-0001Pa-Ix; Sat, 16 Sep 2023 18:12:38 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qhXuQ-006ngg-2j; Sat, 16 Sep 2023 18:12:38 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qhXuP-0028Lo-Pu; Sat, 16 Sep 2023 18:12:37 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown Cc: linux-spi@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] spi: Drop warning from spi_stop_queue() Date: Sat, 16 Sep 2023 18:12:35 +0200 Message-Id: <20230916161235.1050176-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=812; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=FxP0mdi2NzNYzO8HgyLC6cn0Nj2TIBXtUgnDY+xKTpg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlBdPyxIqZSM4Vp3fh0ndFJKru3HOR33pRxbSlO gMbsavNSMeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZQXT8gAKCRCPgPtYfRL+ TpehB/4mhAwTcipXvD4wSEN1VsdxgyDUoNQKf6b+CtTMUU30eXfqas5iX4wiB3AVJEK2ECoCmOn as6xdGjaFbmbXaAxxEs5eU9gxYSyoZiffQ+1zHWUJD/J2Asf3IjR86aZHnz+BXemiGmP8Bg64A5 8zqJzKsM8lg4Ws4+FzhHH935i1CXeFKsiF6oO32p67WfrM3ZyBvlOZ+GG4cbZbqkBpCpa2Ks8DO VLoDslU/C3jnbf5K4dcEO4QmSSgKB1FQOR2HeGcVsL3Tb2pllidkz4M9duWls0abxIsHmojlOe/ w8vMq0+M7XgV+4Eq3Z0m+mYL6meXERrbyxQd5hgj5XkmEmgi X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-spi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Both callers of spi_stop_queue() (i.e. spi_destroy_queue() and spi_controller_suspend()) already emit an error message if spi_stop_queue() fails. Another warning in this case isn't helpful, so drop it. Signed-off-by: Uwe Kleine-König --- drivers/spi/spi.c | 4 ---- 1 file changed, 4 deletions(-) base-commit: dfa449a58323de195773cf928d99db4130702bf7 diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 8d6304cb061e..ac518be34917 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2093,10 +2093,6 @@ static int spi_stop_queue(struct spi_controller *ctlr) spin_unlock_irqrestore(&ctlr->queue_lock, flags); - if (ret) { - dev_warn(&ctlr->dev, "could not stop message queue\n"); - return ret; - } return ret; }