diff mbox series

[06/16] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC

Message ID 20230106200809.330769-7-william.zhang@broadcom.com
State Superseded
Headers show
Series spi: bcm63xx-hsspi: driver and doc updates | expand

Commit Message

William Zhang Jan. 6, 2023, 8:07 p.m. UTC 
HSSPI controller uses big endian for the opcode in the message to the
controller ping pong buffer. Use cpu_to_be16 to properly handle the
endianness for both big and little endian host.

Fixes: 142168eba9dc ("spi: bcm63xx-hsspi: add bcm63xx HSSPI driver")
Signed-off-by: Kursad Oney <kursad.oney@broadcom.com>
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---

 drivers/spi/spi-bcm63xx-hsspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

kernel test robot Jan. 7, 2023, 7:44 a.m. UTC | #1 
Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on broonie-spi/for-next krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v6.2-rc2 next-20230106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230106200809.330769-7-william.zhang%40broadcom.com
patch subject: [PATCH 06/16] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC
config: alpha-randconfig-s052-20230106
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
        git checkout 8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=alpha SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned short [usertype] b @@     got restricted __be16 [usertype] @@
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     expected unsigned short [usertype] b
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     got restricted __be16 [usertype]

vim +197 drivers/spi/spi-bcm63xx-hsspi.c

   156	
   157	static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)
   158	{
   159		struct bcm63xx_hsspi *bs = spi_master_get_devdata(spi->master);
   160		unsigned int chip_select = spi->chip_select;
   161		u16 opcode = 0;
   162		int pending = t->len;
   163		int step_size = HSSPI_BUFFER_LEN;
   164		const u8 *tx = t->tx_buf;
   165		u8 *rx = t->rx_buf;
   166	
   167		bcm63xx_hsspi_set_clk(bs, spi, t->speed_hz);
   168		bcm63xx_hsspi_set_cs(bs, spi->chip_select, true);
   169	
   170		if (tx && rx)
   171			opcode = HSSPI_OP_READ_WRITE;
   172		else if (tx)
   173			opcode = HSSPI_OP_WRITE;
   174		else if (rx)
   175			opcode = HSSPI_OP_READ;
   176	
   177		if (opcode != HSSPI_OP_READ)
   178			step_size -= HSSPI_OPCODE_LEN;
   179	
   180		if ((opcode == HSSPI_OP_READ && t->rx_nbits == SPI_NBITS_DUAL) ||
   181		    (opcode == HSSPI_OP_WRITE && t->tx_nbits == SPI_NBITS_DUAL))
   182			opcode |= HSSPI_OP_MULTIBIT;
   183	
   184		__raw_writel(1 << MODE_CTRL_MULTIDATA_WR_SIZE_SHIFT |
   185			     1 << MODE_CTRL_MULTIDATA_RD_SIZE_SHIFT | 0xff,
   186			     bs->regs + HSSPI_PROFILE_MODE_CTRL_REG(chip_select));
   187	
   188		while (pending > 0) {
   189			int curr_step = min_t(int, step_size, pending);
   190	
   191			reinit_completion(&bs->done);
   192			if (tx) {
   193				memcpy_toio(bs->fifo + HSSPI_OPCODE_LEN, tx, curr_step);
   194				tx += curr_step;
   195			}
   196	
 > 197			__raw_writew(cpu_to_be16(opcode | curr_step), bs->fifo);
   198	
   199			/* enable interrupt */
   200			__raw_writel(HSSPI_PINGx_CMD_DONE(0),
   201				     bs->regs + HSSPI_INT_MASK_REG);
   202	
   203			/* start the transfer */
   204			__raw_writel(!chip_select << PINGPONG_CMD_SS_SHIFT |
   205				     chip_select << PINGPONG_CMD_PROFILE_SHIFT |
   206				     PINGPONG_COMMAND_START_NOW,
   207				     bs->regs + HSSPI_PINGPONG_COMMAND_REG(0));
   208	
   209			if (wait_for_completion_timeout(&bs->done, HZ) == 0) {
   210				dev_err(&bs->pdev->dev, "transfer timed out!\n");
   211				return -ETIMEDOUT;
   212			}
   213	
   214			if (rx) {
   215				memcpy_fromio(rx, bs->fifo, curr_step);
   216				rx += curr_step;
   217			}
   218	
   219			pending -= curr_step;
   220		}
   221	
   222		return 0;
   223	}
   224
kernel test robot Jan. 7, 2023, 9:21 p.m. UTC | #2 
Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on broonie-spi/for-next krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v6.2-rc2 next-20230106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230106200809.330769-7-william.zhang%40broadcom.com
patch subject: [PATCH 06/16] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC
config: microblaze-randconfig-s041-20230108
compiler: microblaze-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
        git checkout 8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned short [usertype] value @@     got restricted __be16 [usertype] @@
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     expected unsigned short [usertype] value
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     got restricted __be16 [usertype]

vim +197 drivers/spi/spi-bcm63xx-hsspi.c

   156	
   157	static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)
   158	{
   159		struct bcm63xx_hsspi *bs = spi_master_get_devdata(spi->master);
   160		unsigned int chip_select = spi->chip_select;
   161		u16 opcode = 0;
   162		int pending = t->len;
   163		int step_size = HSSPI_BUFFER_LEN;
   164		const u8 *tx = t->tx_buf;
   165		u8 *rx = t->rx_buf;
   166	
   167		bcm63xx_hsspi_set_clk(bs, spi, t->speed_hz);
   168		bcm63xx_hsspi_set_cs(bs, spi->chip_select, true);
   169	
   170		if (tx && rx)
   171			opcode = HSSPI_OP_READ_WRITE;
   172		else if (tx)
   173			opcode = HSSPI_OP_WRITE;
   174		else if (rx)
   175			opcode = HSSPI_OP_READ;
   176	
   177		if (opcode != HSSPI_OP_READ)
   178			step_size -= HSSPI_OPCODE_LEN;
   179	
   180		if ((opcode == HSSPI_OP_READ && t->rx_nbits == SPI_NBITS_DUAL) ||
   181		    (opcode == HSSPI_OP_WRITE && t->tx_nbits == SPI_NBITS_DUAL))
   182			opcode |= HSSPI_OP_MULTIBIT;
   183	
   184		__raw_writel(1 << MODE_CTRL_MULTIDATA_WR_SIZE_SHIFT |
   185			     1 << MODE_CTRL_MULTIDATA_RD_SIZE_SHIFT | 0xff,
   186			     bs->regs + HSSPI_PROFILE_MODE_CTRL_REG(chip_select));
   187	
   188		while (pending > 0) {
   189			int curr_step = min_t(int, step_size, pending);
   190	
   191			reinit_completion(&bs->done);
   192			if (tx) {
   193				memcpy_toio(bs->fifo + HSSPI_OPCODE_LEN, tx, curr_step);
   194				tx += curr_step;
   195			}
   196	
 > 197			__raw_writew(cpu_to_be16(opcode | curr_step), bs->fifo);
   198	
   199			/* enable interrupt */
   200			__raw_writel(HSSPI_PINGx_CMD_DONE(0),
   201				     bs->regs + HSSPI_INT_MASK_REG);
   202	
   203			/* start the transfer */
   204			__raw_writel(!chip_select << PINGPONG_CMD_SS_SHIFT |
   205				     chip_select << PINGPONG_CMD_PROFILE_SHIFT |
   206				     PINGPONG_COMMAND_START_NOW,
   207				     bs->regs + HSSPI_PINGPONG_COMMAND_REG(0));
   208	
   209			if (wait_for_completion_timeout(&bs->done, HZ) == 0) {
   210				dev_err(&bs->pdev->dev, "transfer timed out!\n");
   211				return -ETIMEDOUT;
   212			}
   213	
   214			if (rx) {
   215				memcpy_fromio(rx, bs->fifo, curr_step);
   216				rx += curr_step;
   217			}
   218	
   219			pending -= curr_step;
   220		}
   221	
   222		return 0;
   223	}
   224
kernel test robot Jan. 7, 2023, 9:52 p.m. UTC | #3 
Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on broonie-spi/for-next krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v6.2-rc2 next-20230106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230106200809.330769-7-william.zhang%40broadcom.com
patch subject: [PATCH 06/16] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC
config: sh-randconfig-s031-20230108
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
        git checkout 8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sh olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sh SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/spi/spi-bcm63xx-hsspi.c:197:17: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short volatile [usertype] @@     got restricted __be16 [usertype] @@
   drivers/spi/spi-bcm63xx-hsspi.c:197:17: sparse:     expected unsigned short volatile [usertype]
   drivers/spi/spi-bcm63xx-hsspi.c:197:17: sparse:     got restricted __be16 [usertype]

vim +197 drivers/spi/spi-bcm63xx-hsspi.c

   156	
   157	static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)
   158	{
   159		struct bcm63xx_hsspi *bs = spi_master_get_devdata(spi->master);
   160		unsigned int chip_select = spi->chip_select;
   161		u16 opcode = 0;
   162		int pending = t->len;
   163		int step_size = HSSPI_BUFFER_LEN;
   164		const u8 *tx = t->tx_buf;
   165		u8 *rx = t->rx_buf;
   166	
   167		bcm63xx_hsspi_set_clk(bs, spi, t->speed_hz);
   168		bcm63xx_hsspi_set_cs(bs, spi->chip_select, true);
   169	
   170		if (tx && rx)
   171			opcode = HSSPI_OP_READ_WRITE;
   172		else if (tx)
   173			opcode = HSSPI_OP_WRITE;
   174		else if (rx)
   175			opcode = HSSPI_OP_READ;
   176	
   177		if (opcode != HSSPI_OP_READ)
   178			step_size -= HSSPI_OPCODE_LEN;
   179	
   180		if ((opcode == HSSPI_OP_READ && t->rx_nbits == SPI_NBITS_DUAL) ||
   181		    (opcode == HSSPI_OP_WRITE && t->tx_nbits == SPI_NBITS_DUAL))
   182			opcode |= HSSPI_OP_MULTIBIT;
   183	
   184		__raw_writel(1 << MODE_CTRL_MULTIDATA_WR_SIZE_SHIFT |
   185			     1 << MODE_CTRL_MULTIDATA_RD_SIZE_SHIFT | 0xff,
   186			     bs->regs + HSSPI_PROFILE_MODE_CTRL_REG(chip_select));
   187	
   188		while (pending > 0) {
   189			int curr_step = min_t(int, step_size, pending);
   190	
   191			reinit_completion(&bs->done);
   192			if (tx) {
   193				memcpy_toio(bs->fifo + HSSPI_OPCODE_LEN, tx, curr_step);
   194				tx += curr_step;
   195			}
   196	
 > 197			__raw_writew(cpu_to_be16(opcode | curr_step), bs->fifo);
   198	
   199			/* enable interrupt */
   200			__raw_writel(HSSPI_PINGx_CMD_DONE(0),
   201				     bs->regs + HSSPI_INT_MASK_REG);
   202	
   203			/* start the transfer */
   204			__raw_writel(!chip_select << PINGPONG_CMD_SS_SHIFT |
   205				     chip_select << PINGPONG_CMD_PROFILE_SHIFT |
   206				     PINGPONG_COMMAND_START_NOW,
   207				     bs->regs + HSSPI_PINGPONG_COMMAND_REG(0));
   208	
   209			if (wait_for_completion_timeout(&bs->done, HZ) == 0) {
   210				dev_err(&bs->pdev->dev, "transfer timed out!\n");
   211				return -ETIMEDOUT;
   212			}
   213	
   214			if (rx) {
   215				memcpy_fromio(rx, bs->fifo, curr_step);
   216				rx += curr_step;
   217			}
   218	
   219			pending -= curr_step;
   220		}
   221	
   222		return 0;
   223	}
   224
kernel test robot Jan. 7, 2023, 11:23 p.m. UTC | #4 
Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on broonie-spi/for-next krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v6.2-rc2 next-20230106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230106200809.330769-7-william.zhang%40broadcom.com
patch subject: [PATCH 06/16] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC
config: sparc-randconfig-s051-20230108
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
        git checkout 8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned short [usertype] w @@     got restricted __be16 [usertype] @@
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     expected unsigned short [usertype] w
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     got restricted __be16 [usertype]

vim +197 drivers/spi/spi-bcm63xx-hsspi.c

   156	
   157	static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)
   158	{
   159		struct bcm63xx_hsspi *bs = spi_master_get_devdata(spi->master);
   160		unsigned int chip_select = spi->chip_select;
   161		u16 opcode = 0;
   162		int pending = t->len;
   163		int step_size = HSSPI_BUFFER_LEN;
   164		const u8 *tx = t->tx_buf;
   165		u8 *rx = t->rx_buf;
   166	
   167		bcm63xx_hsspi_set_clk(bs, spi, t->speed_hz);
   168		bcm63xx_hsspi_set_cs(bs, spi->chip_select, true);
   169	
   170		if (tx && rx)
   171			opcode = HSSPI_OP_READ_WRITE;
   172		else if (tx)
   173			opcode = HSSPI_OP_WRITE;
   174		else if (rx)
   175			opcode = HSSPI_OP_READ;
   176	
   177		if (opcode != HSSPI_OP_READ)
   178			step_size -= HSSPI_OPCODE_LEN;
   179	
   180		if ((opcode == HSSPI_OP_READ && t->rx_nbits == SPI_NBITS_DUAL) ||
   181		    (opcode == HSSPI_OP_WRITE && t->tx_nbits == SPI_NBITS_DUAL))
   182			opcode |= HSSPI_OP_MULTIBIT;
   183	
   184		__raw_writel(1 << MODE_CTRL_MULTIDATA_WR_SIZE_SHIFT |
   185			     1 << MODE_CTRL_MULTIDATA_RD_SIZE_SHIFT | 0xff,
   186			     bs->regs + HSSPI_PROFILE_MODE_CTRL_REG(chip_select));
   187	
   188		while (pending > 0) {
   189			int curr_step = min_t(int, step_size, pending);
   190	
   191			reinit_completion(&bs->done);
   192			if (tx) {
   193				memcpy_toio(bs->fifo + HSSPI_OPCODE_LEN, tx, curr_step);
   194				tx += curr_step;
   195			}
   196	
 > 197			__raw_writew(cpu_to_be16(opcode | curr_step), bs->fifo);
   198	
   199			/* enable interrupt */
   200			__raw_writel(HSSPI_PINGx_CMD_DONE(0),
   201				     bs->regs + HSSPI_INT_MASK_REG);
   202	
   203			/* start the transfer */
   204			__raw_writel(!chip_select << PINGPONG_CMD_SS_SHIFT |
   205				     chip_select << PINGPONG_CMD_PROFILE_SHIFT |
   206				     PINGPONG_COMMAND_START_NOW,
   207				     bs->regs + HSSPI_PINGPONG_COMMAND_REG(0));
   208	
   209			if (wait_for_completion_timeout(&bs->done, HZ) == 0) {
   210				dev_err(&bs->pdev->dev, "transfer timed out!\n");
   211				return -ETIMEDOUT;
   212			}
   213	
   214			if (rx) {
   215				memcpy_fromio(rx, bs->fifo, curr_step);
   216				rx += curr_step;
   217			}
   218	
   219			pending -= curr_step;
   220		}
   221	
   222		return 0;
   223	}
   224
kernel test robot Jan. 11, 2023, 6:33 a.m. UTC | #5 
Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on broonie-spi/for-next krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v6.2-rc3 next-20230111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230106200809.330769-7-william.zhang%40broadcom.com
patch subject: [PATCH 06/16] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC
config: arc-randconfig-s032-20230110
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review William-Zhang/dt-bindings-spi-Convert-bcm63xx-hsspi-bindings-to-json-schema/20230107-042320
        git checkout 8a82a44b50d88a27e55065e9f1bd75f0fccf479a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arc SHELL=/bin/bash drivers/spi/ sound/soc/codecs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned short [usertype] s @@     got restricted __be16 [usertype] @@
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     expected unsigned short [usertype] s
   drivers/spi/spi-bcm63xx-hsspi.c:197:30: sparse:     got restricted __be16 [usertype]

vim +197 drivers/spi/spi-bcm63xx-hsspi.c

   156	
   157	static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)
   158	{
   159		struct bcm63xx_hsspi *bs = spi_master_get_devdata(spi->master);
   160		unsigned int chip_select = spi->chip_select;
   161		u16 opcode = 0;
   162		int pending = t->len;
   163		int step_size = HSSPI_BUFFER_LEN;
   164		const u8 *tx = t->tx_buf;
   165		u8 *rx = t->rx_buf;
   166	
   167		bcm63xx_hsspi_set_clk(bs, spi, t->speed_hz);
   168		bcm63xx_hsspi_set_cs(bs, spi->chip_select, true);
   169	
   170		if (tx && rx)
   171			opcode = HSSPI_OP_READ_WRITE;
   172		else if (tx)
   173			opcode = HSSPI_OP_WRITE;
   174		else if (rx)
   175			opcode = HSSPI_OP_READ;
   176	
   177		if (opcode != HSSPI_OP_READ)
   178			step_size -= HSSPI_OPCODE_LEN;
   179	
   180		if ((opcode == HSSPI_OP_READ && t->rx_nbits == SPI_NBITS_DUAL) ||
   181		    (opcode == HSSPI_OP_WRITE && t->tx_nbits == SPI_NBITS_DUAL))
   182			opcode |= HSSPI_OP_MULTIBIT;
   183	
   184		__raw_writel(1 << MODE_CTRL_MULTIDATA_WR_SIZE_SHIFT |
   185			     1 << MODE_CTRL_MULTIDATA_RD_SIZE_SHIFT | 0xff,
   186			     bs->regs + HSSPI_PROFILE_MODE_CTRL_REG(chip_select));
   187	
   188		while (pending > 0) {
   189			int curr_step = min_t(int, step_size, pending);
   190	
   191			reinit_completion(&bs->done);
   192			if (tx) {
   193				memcpy_toio(bs->fifo + HSSPI_OPCODE_LEN, tx, curr_step);
   194				tx += curr_step;
   195			}
   196	
 > 197			__raw_writew(cpu_to_be16(opcode | curr_step), bs->fifo);
   198	
   199			/* enable interrupt */
   200			__raw_writel(HSSPI_PINGx_CMD_DONE(0),
   201				     bs->regs + HSSPI_INT_MASK_REG);
   202	
   203			/* start the transfer */
   204			__raw_writel(!chip_select << PINGPONG_CMD_SS_SHIFT |
   205				     chip_select << PINGPONG_CMD_PROFILE_SHIFT |
   206				     PINGPONG_COMMAND_START_NOW,
   207				     bs->regs + HSSPI_PINGPONG_COMMAND_REG(0));
   208	
   209			if (wait_for_completion_timeout(&bs->done, HZ) == 0) {
   210				dev_err(&bs->pdev->dev, "transfer timed out!\n");
   211				return -ETIMEDOUT;
   212			}
   213	
   214			if (rx) {
   215				memcpy_fromio(rx, bs->fifo, curr_step);
   216				rx += curr_step;
   217			}
   218	
   219			pending -= curr_step;
   220		}
   221	
   222		return 0;
   223	}
   224
diff mbox series

Patch

diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
index b871fd810d80..63682c8ff955 100644
--- a/drivers/spi/spi-bcm63xx-hsspi.c
+++ b/drivers/spi/spi-bcm63xx-hsspi.c
@@ -194,7 +194,7 @@  static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)
 			tx += curr_step;
 		}
 
-		__raw_writew(opcode | curr_step, bs->fifo);
+		__raw_writew(cpu_to_be16(opcode | curr_step), bs->fifo);
 
 		/* enable interrupt */
 		__raw_writel(HSSPI_PINGx_CMD_DONE(0),