From patchwork Mon Feb 21 04:32:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 545203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5793C433EF for ; Mon, 21 Feb 2022 04:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbiBUEd0 (ORCPT ); Sun, 20 Feb 2022 23:33:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241006AbiBUEdY (ORCPT ); Sun, 20 Feb 2022 23:33:24 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC1041CFDF for ; Sun, 20 Feb 2022 20:33:01 -0800 (PST) Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id EEA3B82F5E; Mon, 21 Feb 2022 05:32:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1645417979; bh=r1QBjT3wGnh9NYJ917En+5d+6QOyFYnCH35Ft4gba1o=; h=From:To:Cc:Subject:Date:From; b=fwYg6RmmM25gnDqdtDuvCpR1sZ9eZ9MJLUOj50exAj/cpf8yAEFiNTK0FrkS0vx5q 2FzUf4FyhjZ3tZXbXJZ84P9rJ6lF3kOgx2/7WdP0RxMitFtwQy5/gIVPAez8jlH5AE RnXnX9yV4OHPAGlvz67KrrxSJBlC8O5nckoXw+qttG8bqjqcHCUAQ53QNNaqQ5EXiT zsNsFbjFxPHy+qoYG721zeFgIy0noLbAOfBTWcdj/Ka4w6MM+O3pmPS+KoQu6A+eEA QzwbWSgXT4zTcncrqOUlTTSDA+1sR70IXhZiMRsa989KSyYuiQQohLZDYO3yX3kYNv TukTpbLpfwK0Q== From: Marek Vasut To: linux-spi@vger.kernel.org Cc: Marek Vasut , Dinh Nguyen , Pratyush Yadav Subject: [PATCH] [RFC] spi: cadence-quadspi: Disable DAC on SoCFPGA Date: Mon, 21 Feb 2022 05:32:38 +0100 Message-Id: <20220221043238.295369-1-marex@denx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On SoCFPGA Gen5, DAC memcpy_fromio() in cqspi_direct_read_execute() leads to data abort, disable DAC to avoid triggering it: Unhandled fault: imprecise external abort (0x1406) at 0x0400d3e9 [0400d3e9] *pgd=00000000 Signed-off-by: Marek Vasut Cc: Dinh Nguyen Cc: Pratyush Yadav --- drivers/spi/spi-cadence-quadspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index b808c94641fa6..65f2c2449be09 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1870,7 +1870,7 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = { }; static const struct cqspi_driver_platdata socfpga_qspi = { - .quirks = CQSPI_NO_SUPPORT_WR_COMPLETION, + .quirks = CQSPI_DISABLE_DAC_MODE | CQSPI_NO_SUPPORT_WR_COMPLETION, }; static const struct cqspi_driver_platdata versal_ospi = {