| Message ID | 20210726140001.24820-3-nikita.shubin@maquefel.me |
|---|---|
| State | New |
| Headers | show |
| Series | arm: ep93xx: CCF conversion | expand |
Hello Mark, On 26/07/2021 18:51, Mark Brown wrote: > On Mon, Jul 26, 2021 at 04:59:50PM +0300, Nikita Shubin wrote: >> From: Alexander Sverdlin <alexander.sverdlin@gmail.com> >> >> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch >> to Common Clock Framework, otherwise the following is visible: > Acked-by: Mark Brown <broonie@kernel.org> It looks like we didn't manage to bring the whole series as one lot to any maintainer and two patches were applied to two different trees. Could you please take this one to your tree as well? >> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:1011 clk_core_enable+0x9c/0xbc >> Enabling unprepared ep93xx-spi.0 >> ... >> Hardware name: Cirrus Logic EDB9302 Evaluation Board >> ... >> clk_core_enable >> clk_core_enable_lock >> ep93xx_spi_prepare_hardware > Please think hard before including complete backtraces in upstream > reports, they are very large and contain almost no useful information > relative to their size so often obscure the relevant content in your > message. If part of the backtrace is usefully illustrative (it often is > for search engines if nothing else) then it's usually better to pull out > the relevant sections. Yes, I noted your comment first time and this was already stripped version of the backtrace, but please feel free to strip it even harder if you take the patch. Thank you for the review, -- Alex.
Hello Mark, On Mon, 2021-07-26 at 17:51 +0100, Mark Brown wrote: > > From: Alexander Sverdlin <alexander.sverdlin@gmail.com> > > > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch > > to Common Clock Framework, otherwise the following is visible: > > Acked-by: Mark Brown <broonie@kernel.org> would you take the patch to a tree of yours, please? -- Alexander Sverdlin.
On Mon, 2021-09-13 at 23:36 +0200, Alexander Sverdlin wrote: > > > From: Alexander Sverdlin <alexander.sverdlin@gmail.com> > > > > > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch > > > to Common Clock Framework, otherwise the following is visible: > > > > Acked-by: Mark Brown <broonie@kernel.org> > > would you take the patch to a tree of yours, please? Please ignore this request, I've mixed up the patches, sorry! -- Alexander Sverdlin.
On Mon, Sep 13, 2021 at 11:36:30PM +0200, Alexander Sverdlin wrote: > On Mon, 2021-07-26 at 17:51 +0100, Mark Brown wrote: > > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch > > > to Common Clock Framework, otherwise the following is visible: > > Acked-by: Mark Brown <broonie@kernel.org> > would you take the patch to a tree of yours, please? What's the story with the dependencies?
diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index aa676559d273..5896a7b2fade 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -550,7 +550,7 @@ static int ep93xx_spi_prepare_hardware(struct spi_master *master) u32 val; int ret; - ret = clk_enable(espi->clk); + ret = clk_prepare_enable(espi->clk); if (ret) return ret; @@ -570,7 +570,7 @@ static int ep93xx_spi_unprepare_hardware(struct spi_master *master) val &= ~SSPCR1_SSE; writel(val, espi->mmio + SSPCR1); - clk_disable(espi->clk); + clk_disable_unprepare(espi->clk); return 0; }