| Message ID | 20200717135424.2442271-13-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | c894c265a43ecba365f5a061cf44f739fa639f9d |
| Headers | show |
| Series | Rid W=1 warnings in SPI | expand |
On 17/07/2020 14:54:22+0100, Lee Jones wrote: > The only way this driver can be probed by MFD via its parent device. > > No other reference to 'microchip,at91sam9g45-usart-spi' exists in the kernel. > > Fixes the following W=1 kernel build warning(s): > > drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] > 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { > | ^~~~~~~~~~~~~~~~~~~~~ > > Cc: Radu Pirea <radu_nicolae.pirea@upb.ro> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Ludovic Desroches <ludovic.desroches@microchip.com> > Suggested-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/spi/spi-at91-usart.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c > index 88033422a42ae..8c8352625d232 100644 > --- a/drivers/spi/spi-at91-usart.c > +++ b/drivers/spi/spi-at91-usart.c > @@ -681,13 +681,6 @@ static const struct dev_pm_ops at91_usart_spi_pm_ops = { > at91_usart_spi_runtime_resume, NULL) > }; > > -static const struct of_device_id at91_usart_spi_dt_ids[] = { > - { .compatible = "microchip,at91sam9g45-usart-spi"}, > - { /* sentinel */} > -}; > - > -MODULE_DEVICE_TABLE(of, at91_usart_spi_dt_ids); > - > static struct platform_driver at91_usart_spi_driver = { > .driver = { > .name = "at91_usart_spi", > -- > 2.25.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c index 88033422a42ae..8c8352625d232 100644 --- a/drivers/spi/spi-at91-usart.c +++ b/drivers/spi/spi-at91-usart.c @@ -681,13 +681,6 @@ static const struct dev_pm_ops at91_usart_spi_pm_ops = { at91_usart_spi_runtime_resume, NULL) }; -static const struct of_device_id at91_usart_spi_dt_ids[] = { - { .compatible = "microchip,at91sam9g45-usart-spi"}, - { /* sentinel */} -}; - -MODULE_DEVICE_TABLE(of, at91_usart_spi_dt_ids); - static struct platform_driver at91_usart_spi_driver = { .driver = { .name = "at91_usart_spi",
The only way this driver can be probed by MFD via its parent device. No other reference to 'microchip,at91sam9g45-usart-spi' exists in the kernel. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Radu Pirea <radu_nicolae.pirea@upb.ro> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Ludovic Desroches <ludovic.desroches@microchip.com> Suggested-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/spi/spi-at91-usart.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.25.1