From patchwork Wed Jul 15 15:06:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235595 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp703146ilg; Wed, 15 Jul 2020 08:07:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJws22t+1R7A5tJJsIXMAcW6f2VFJPLyR6Pgq1bZe1sYWg9sKpWcq0T2eB8V73Q5h1ZL8doE X-Received: by 2002:a17:907:20d1:: with SMTP id qq17mr9798921ejb.214.1594825648485; Wed, 15 Jul 2020 08:07:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594825648; cv=none; d=google.com; s=arc-20160816; b=rTgHfvGKLXT8S/WKkfTRfghONWRi0l2imxHYSThmNvl7c4Ctv4uEC+CCo7KPHUeVU4 IzkKzbcy5yctZ3AqyyqMvvz6iNoA0JsOt0h0RgJFdv3famiob1M7MQ/C6uYJL/qwMOQL Vx6Ni7NjZRvJ8W3NI08DuRyRZC8MkMGz58yilmjx/hriK8LcckXW0cvlbW/7bDyfSDbL NvA8mQ13GwjYHiTLKmMIgKan4O2H73zyLHTgN6+WWBF/pBlPXiENcmCXJeIEnuLU9TGa wBiDV0eTAxttCiGdKoRQDy+tMufnL5ZXR2PUjtHQIsVGc+td9NdxdKUbkHz+C4JUjOqn W7fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=JKntyGVHbj2lYFntRmdYADLDcpqUDg2zT5Sa2hQ8po7Qbilo+56zWIyXNfyYFDevjl 6hqfcTKc05797SAY4nxuW0/fzNR/yyXeTu9Qild40hEn+In1hXjmlEL5hSnBAUsXsv/W bcQ9Wdpe3JHnvYTpsURQ5C68ugSrr0OXfb2T5yV4nXLCHtnBiyrqbx4yhsLolkgIjRv4 QPVDZLVre7ESYvY65edZa8XukLpy5iWVezqifen/Ga05ykBd5VQ8ZW+8tBepdAca2lqc +ewFJqoZeoJezeEnriiaiyciG7ZfwI0k9Mvvk4vWtRwaAt8eU8Mml5rFhTY7pcsSQMC3 USvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EzXgoWXV; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bf28si1525471edb.312.2020.07.15.08.07.28; Wed, 15 Jul 2020 08:07:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EzXgoWXV; spf=pass (google.com: domain of linux-spi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbgGOPGv (ORCPT + 2 others); Wed, 15 Jul 2020 11:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727991AbgGOPGv (ORCPT ); Wed, 15 Jul 2020 11:06:51 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5AC9C061755 for ; Wed, 15 Jul 2020 08:06:50 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f18so3132237wrs.0 for ; Wed, 15 Jul 2020 08:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=EzXgoWXVHcblT299CWnFjUwu/qW4z3MCPe2EO1ynFgOADXo0wZ1hvqbPWrfz+tOefw VGGaZd5/muef9MzYyk6NIpaostukgfsY74ELsVkuN6ZdvEB4Q+J3btO58zC484dxcoC7 jdl2m8vMVMOlhrc0xvsq55kzBXJ5aF9Ckq4TuG+MIDJ1ZJj6LFV9hfXvWgNz1PXIwh49 MUqAgaDi/6eYeqRV8KEZqdndWwgVFN1ZaurPwYdAdUUE+bXE3Muc8Q15gmfSdAC/ponK qbDU08/zyrkSq5o8cqOTCtjTrlhrRS3BvWbyXMb9T00Bv3omHZ4gOBBlEwEJwx5mkh5h kQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=aaXbYKD2wd92wFt2TWJAAV18aWBKDpuYeSuMvOooa3klGP0wV5XhEFuUBdCqZar9V4 qNhyoDl0+mxBUfYtSQRdAHECyZ+u1FD+bNbyt2s/AVTHJmVIUqq02PipNZlyzP00vwjb YAimxOU0Gz/RfqulsZbQGBnOKDgXwCkDBoBk1KX6LAnZyr34BtYpLmU4uFgO9CQLleKw PB8hEItMYZO8+rNj39YWIQP34It9L1LZGrx+1FzUp5qgWTwXCSOPcmvKCa46Z5ReCNPB 7X+qWsOiQxrviwCeCJTgRoy67aUQmF2B+a6Ke+1uz/+GiTW07se1/8e8EzLJciyliqhO lJqw== X-Gm-Message-State: AOAM533noU5rznT3FFyAhFkq/jZKNQFQpyS6SL1jSy18WKBithC5Ku9g pc5tr+rebqJozXQDQlBc6/IZLvBrOyQ= X-Received: by 2002:a5d:4a42:: with SMTP id v2mr11024451wrs.33.1594825609431; Wed, 15 Jul 2020 08:06:49 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:48 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones Subject: [PATCH 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data' Date: Wed, 15 Jul 2020 16:06:29 +0100 Message-Id: <20200715150632.409077-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data' Signed-off-by: Lee Jones --- drivers/spi/spi-topcliff-pch.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index d7ea6af74743e..baadd380cb297 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl { /** * struct pch_spi_data - Holds the SPI channel specific details * @io_remap_addr: The remapped PCI base address + * @io_base_addr: Base address * @master: Pointer to the SPI master structure * @work: Reference to work queue handler * @wait: Wait queue for waking up upon receiving an @@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl { * transfer * @rx_index: Receive data count; for bookkeeping during * transfer - * @tx_buff: Buffer for data to be transmitted - * @rx_index: Buffer for Received data + * @pkt_tx_buff: Buffer for data to be transmitted + * @pkt_rx_buff: Buffer for received data * @n_curnt_chip: The chip number that this SPI driver currently * operates on * @current_chip: Reference to the current chip that this SPI @@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl { * @board_dat: Reference to the SPI device data structure * @plat_dev: platform_device structure * @ch: SPI channel number + * @dma: Local DMA information + * @use_dma: True if DMA is to be used * @irq_reg_sts: Status of IRQ registration + * @save_total_len: Save length while data is being transferred */ struct pch_spi_data { void __iomem *io_remap_addr;