From patchwork Mon Jan 9 10:36:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 90384 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp15547qgi; Mon, 9 Jan 2017 02:37:02 -0800 (PST) X-Received: by 10.84.167.2 with SMTP id c2mr188856170plb.56.1483958222594; Mon, 09 Jan 2017 02:37:02 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si88410789ply.163.2017.01.09.02.37.02 for ; Mon, 09 Jan 2017 02:37:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-spi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-spi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-spi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935473AbdAIKhA (ORCPT ); Mon, 9 Jan 2017 05:37:00 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:11091 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759007AbdAIKg1 (ORCPT ); Mon, 9 Jan 2017 05:36:27 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OJI00L0GDGOLM10@mailout3.w1.samsung.com>; Mon, 09 Jan 2017 10:36:24 +0000 (GMT) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170109103623eucas1p10b3bea3d83d1db6ebd0375e7c5b5006e~YFBsf5oGe0279702797eucas1p1z; Mon, 9 Jan 2017 10:36:23 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id DA.B4.30614.7A763785; Mon, 9 Jan 2017 10:36:23 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170109103623eucas1p2f728e8ae5e1304fd3e06e2038edbdbf8~YFBr02Uuc2778127781eucas1p2P; Mon, 9 Jan 2017 10:36:23 +0000 (GMT) X-AuditID: cbfec7f1-f793f6d000007796-06-587367a754d6 Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id BF.A0.10233.F9763785; Mon, 9 Jan 2017 10:36:15 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OJI00IC0DGHZB70@eusync1.samsung.com>; Mon, 09 Jan 2017 10:36:22 +0000 (GMT) From: Marek Szyprowski To: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Andi Shyti , Mark Brown , Sylwester Nawrocki , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Inki Dae , Javier Martinez Canillas Subject: [PATCH RESEND] spi: s3c64xx: Don't request/release DMA channels for each SPI transfer Date: Mon, 09 Jan 2017 11:36:10 +0100 Message-id: <1483958170-17270-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsWy7djP87rL04sjDJa0qltsP/KM1WLjjPWs FlMfPmGzmHR/AovFm7drmCzOn9/AbjHj/D4mi8aPN9kt1h65y25x+E07qwOXx6ZVnWweW/rv snv0bVnF6PF5k1wASxSXTUpqTmZZapG+XQJXxu/eY8wFO1Qrrr+7zNjAuF++i5GTQ0LAROLl /rtsELaYxIV764FsLg4hgaWMEi+ONDBDOJ+BnNV9rDAd7z9PYgaxhQSWMUo07TaHKGpgknjy 5wELSIJNwFCi620X2FgRAQeJpgfnwMYyC9xmklg+dy1YQlggQaJr3g+wqSwCqhIrr04Es3kF PCTaV3QzQmyTkzh5bDIrSLOEwHM2if5V/4CaOYAcWYlNB5ghalwkFh1ZB2ULS7w6voUdwpaR uDy5mwXC7ge6tFUbwp7BKHHuLS+EbS1x+PhFsL3MAnwSk7ZNZ4YYzyvR0SYEUeIh0bVzNwtE 2FFixXoNiN9jJVa03GWfwCi9gJFhFaNIamlxbnpqsZFecWJucWleul5yfu4mRmDknv53/OMO xvcnrA4xCnAwKvHwTvAqihBiTSwrrsw9xCjBwawkwnshtThCiDclsbIqtSg/vqg0J7X4EKM0 B4uSOO+eBVfChQTSE0tSs1NTC1KLYLJMHJxSDYzM4r+Fg5qU06/x1W6ac4LxxOoZp5wurGBh /vcsTj5ridrTmXwJW2NXVvQyblGdW3AyeXFDT46AfJWj0xouSw3N7QsU2sNkyjpWTvv/VpnF sktg8hTR7ZzT6vYtr963n/16vNqC5pUFT40zz77+Jsj7h1s9R+iQvd5f9fesYn99rlW55W1y bVNiKc5INNRiLipOBAAUU4z82AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsVy+t/xy7rz04sjDHa+ZbLYfuQZq8XGGetZ LaY+fMJmMen+BBaLN2/XMFmcP7+B3WLG+X1MFo0fb7JbrD1yl93i8Jt2Vgcuj02rOtk8tvTf Zffo27KK0ePzJrkAlig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWy xJxSIM/IAA04OAe4Byvp2yW4ZfzuPcZcsEO14vq7y4wNjPvluxg5OSQETCTef57EDGGLSVy4 t56ti5GLQ0hgCaPE+qPH2EESQgJNTBLfjoAVsQkYSnS97WIDsUUEHCSaHpwDa2AWuM8kcb6t hwkkISyQINE17wcriM0ioCqx8upEMJtXwEOifUU3I8Q2OYmTxyazTmDkXsDIsIpRJLW0ODc9 t9hIrzgxt7g0L10vOT93EyMwYLcd+7llB2PXu+BDjAIcjEo8vBO8iiKEWBPLiitzDzFKcDAr ifBeSC2OEOJNSaysSi3Kjy8qzUktPsRoCrR8IrOUaHI+MJrySuINTQzNLQ2NjC0szI2MlMR5 p364Ei4kkJ5YkpqdmlqQWgTTx8TBKdXAaNH+/otm0p8koWcvDPw4NwZ5HrL8WTt305/3X7as mGvao/39ZMR3AWGLftsTddk1309qSsVEnReeLfvYPvHKv4Bz9uJrl2979C+3RqKVp2vqwyWN r/UcjuybaK3y2OHlzWWHfxz7JbSy/jefpPM3oW9HVb1kYq9dWbvNM6O4bN6s6OMTQ/l4OZVY ijMSDbWYi4oTAWjqBqduAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170109103623eucas1p2f728e8ae5e1304fd3e06e2038edbdbf8 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170109103623eucas1p2f728e8ae5e1304fd3e06e2038edbdbf8 X-RootMTR: 20170109103623eucas1p2f728e8ae5e1304fd3e06e2038edbdbf8 References: Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Requesting a DMA channel might be a time consuming operation, so there is no need to acquire and release DMA channel for each SPI transfer. DMA channels can be requested during driver probe and kept all the time, also because there are no shared nor dynamically allocated channels on Samsung S3C/S5P/Exynos platforms. While moving dma_requrest_slave_channel calls, lets switch to dma_request_slave_channel_reason(), which returns error codes on failure, which can be properly propagated to the caller (this for example defers SPI probe when DMA controller is not yet available). Signed-off-by: Marek Szyprowski Reviewed-by: Andi Shyti Tested-by: Andi Shyti Reviewed-by: Krzysztof Kozlowski --- This patch depends on commit 6f8dc9d481759b428a8cb6a17b83821451415ba9 ("spi: s3c64xx: Do not use platform_data for DMA parameters"), which is already in Linux v4.10-rc1 and came there through dma-engine tree. For merging to spi-next tree, it requires merging first v4.10-rc1. Resend reason: - collected tags - added information about patch dependency --- drivers/spi/spi-s3c64xx.c | 57 ++++++++++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 28 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 28dfdce4beae..849ee82483e4 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -341,43 +341,16 @@ static void s3c64xx_spi_set_cs(struct spi_device *spi, bool enable) static int s3c64xx_spi_prepare_transfer(struct spi_master *spi) { struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(spi); - struct device *dev = &sdd->pdev->dev; if (is_polling(sdd)) return 0; - /* Acquire DMA channels */ - sdd->rx_dma.ch = dma_request_slave_channel(dev, "rx"); - if (!sdd->rx_dma.ch) { - dev_err(dev, "Failed to get RX DMA channel\n"); - return -EBUSY; - } spi->dma_rx = sdd->rx_dma.ch; - - sdd->tx_dma.ch = dma_request_slave_channel(dev, "tx"); - if (!sdd->tx_dma.ch) { - dev_err(dev, "Failed to get TX DMA channel\n"); - dma_release_channel(sdd->rx_dma.ch); - return -EBUSY; - } spi->dma_tx = sdd->tx_dma.ch; return 0; } -static int s3c64xx_spi_unprepare_transfer(struct spi_master *spi) -{ - struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(spi); - - /* Free DMA channels */ - if (!is_polling(sdd)) { - dma_release_channel(sdd->rx_dma.ch); - dma_release_channel(sdd->tx_dma.ch); - } - - return 0; -} - static bool s3c64xx_spi_can_dma(struct spi_master *master, struct spi_device *spi, struct spi_transfer *xfer) @@ -1094,7 +1067,6 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) master->prepare_transfer_hardware = s3c64xx_spi_prepare_transfer; master->prepare_message = s3c64xx_spi_prepare_message; master->transfer_one = s3c64xx_spi_transfer_one; - master->unprepare_transfer_hardware = s3c64xx_spi_unprepare_transfer; master->num_chipselect = sci->num_cs; master->dma_alignment = 8; master->bits_per_word_mask = SPI_BPW_MASK(32) | SPI_BPW_MASK(16) | @@ -1161,6 +1133,24 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) } } + if (!is_polling(sdd)) { + /* Acquire DMA channels */ + sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev, + "rx"); + if (IS_ERR(sdd->rx_dma.ch)) { + dev_err(&pdev->dev, "Failed to get RX DMA channel\n"); + ret = PTR_ERR(sdd->rx_dma.ch); + goto err_disable_io_clk; + } + sdd->tx_dma.ch = dma_request_slave_channel_reason(&pdev->dev, + "tx"); + if (IS_ERR(sdd->tx_dma.ch)) { + dev_err(&pdev->dev, "Failed to get TX DMA channel\n"); + ret = PTR_ERR(sdd->tx_dma.ch); + goto err_release_tx_dma; + } + } + pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_active(&pdev->dev); @@ -1206,6 +1196,12 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); + if (!is_polling(sdd)) + dma_release_channel(sdd->rx_dma.ch); +err_release_tx_dma: + if (!is_polling(sdd)) + dma_release_channel(sdd->tx_dma.ch); +err_disable_io_clk: clk_disable_unprepare(sdd->ioclk); err_disable_src_clk: clk_disable_unprepare(sdd->src_clk); @@ -1226,6 +1222,11 @@ static int s3c64xx_spi_remove(struct platform_device *pdev) writel(0, sdd->regs + S3C64XX_SPI_INT_EN); + if (!is_polling(sdd)) { + dma_release_channel(sdd->rx_dma.ch); + dma_release_channel(sdd->tx_dma.ch); + } + clk_disable_unprepare(sdd->ioclk); clk_disable_unprepare(sdd->src_clk);