From patchwork Tue Mar 25 19:29:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 27087 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f198.google.com (mail-ie0-f198.google.com [209.85.223.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9E03120062 for ; Tue, 25 Mar 2014 19:29:32 +0000 (UTC) Received: by mail-ie0-f198.google.com with SMTP id to1sf3297550ieb.9 for ; Tue, 25 Mar 2014 12:29:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:date :message-id:subject:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=FYAm0ywS7lLj6atDz2PsJGdt5YAyE+e1Le5WOdVmnm0=; b=LWTedY2SOmRD4arO1Z2g+eXLHRNwXabVJtAjvF4ORtVxL54im3RURvr04YXcBkwcXt 4oKmLt/fvISWRuJi1+2pCnKW/qjUExvHFm+UF/GP4sQEuc+3wAV53JEX21MU5Bpo7cuS xKk+vbigTSLZYw/QbfpJ6L1woiRPl350ugGkMpyRIPbM/UIe1AtCnwFdC5mppqaORila fExUpcM9NFFLKbwealz33VsJdbXBnGRh5g8pJ2nHSfhm4g7b6BMhSvQbLNASHdGGXh78 SmndPDOmHbFtzNWXgOBJWakheW3+99g6rz84Ed+d5Tk+WXObscfXXc3Ok8R84SfejjOO LEyA== X-Gm-Message-State: ALoCoQluUeWPQBz+qMK8gsdRVyqzEL1yREFCCxUnCv04dbOjF96+2q99uTMYpILXGayCKVt0of/c X-Received: by 10.182.108.136 with SMTP id hk8mr16440862obb.11.1395775772039; Tue, 25 Mar 2014 12:29:32 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.22.167 with SMTP id 36ls323294qgn.55.gmail; Tue, 25 Mar 2014 12:29:32 -0700 (PDT) X-Received: by 10.58.238.35 with SMTP id vh3mr56166555vec.16.1395775771949; Tue, 25 Mar 2014 12:29:31 -0700 (PDT) Received: from mail-ve0-f176.google.com (mail-ve0-f176.google.com [209.85.128.176]) by mx.google.com with ESMTPS id u5si4054765vdo.130.2014.03.25.12.29.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 12:29:31 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.176; Received: by mail-ve0-f176.google.com with SMTP id cz12so1103679veb.7 for ; Tue, 25 Mar 2014 12:29:31 -0700 (PDT) X-Received: by 10.58.23.6 with SMTP id i6mr21507286vef.12.1395775771810; Tue, 25 Mar 2014 12:29:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp332164vck; Tue, 25 Mar 2014 12:29:29 -0700 (PDT) X-Received: by 10.68.139.137 with SMTP id qy9mr79987435pbb.11.1395775769129; Tue, 25 Mar 2014 12:29:29 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pa10si12017453pbc.237.2014.03.25.12.29.28; Tue, 25 Mar 2014 12:29:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-spi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754415AbaCYT32 (ORCPT + 2 others); Tue, 25 Mar 2014 15:29:28 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36754 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754407AbaCYT31 (ORCPT ); Tue, 25 Mar 2014 15:29:27 -0400 Received: from cpc11-sgyl31-2-0-cust672.sgyl.cable.virginm.net ([94.175.94.161] helo=debutante.sirena.org.uk) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1WSX2K-00010T-7W; Tue, 25 Mar 2014 19:29:25 +0000 Received: from broonie by debutante.sirena.org.uk with local (Exim 4.82) (envelope-from ) id 1WSX2F-0002Yj-KA; Tue, 25 Mar 2014 19:29:19 +0000 From: Mark Brown To: Martin Sperl Cc: linux-spi@vger.kernel.org, linaro-kernel@lists.linaro.org, Mark Brown Date: Tue, 25 Mar 2014 19:29:18 +0000 Message-Id: <1395775758-9804-1-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 1.9.1 X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mezzanine.sirena.org.uk X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Subject: [PATCH] spi: Do not require a completion X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-spi-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: broonie@kernel.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Mark Brown There is no real reason why we require transfers to have a completion and the only user of the completion now checks to see if one has been provided before using it so stop enforcing this. This makes it more convenient for drivers to chain multiple asynchronous transfers together. Signed-off-by: Mark Brown --- drivers/spi/spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 26b331d27c35..121c43b5a8e8 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1812,8 +1812,6 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message) if (list_empty(&message->transfers)) return -EINVAL; - if (!message->complete) - return -EINVAL; /* Half-duplex links include original MicroWire, and ones with * only one data pin like SPI_3WIRE (switches direction) or where