From patchwork Tue Nov 22 08:24:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 5265 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 68F1F23E0C for ; Tue, 22 Nov 2011 08:25:27 +0000 (UTC) Received: from mail-fx0-f52.google.com (mail-fx0-f52.google.com [209.85.161.52]) by fiordland.canonical.com (Postfix) with ESMTP id 2070CA1855C for ; Tue, 22 Nov 2011 08:25:26 +0000 (UTC) Received: by mail-fx0-f52.google.com with SMTP id a26so135349faa.11 for ; Tue, 22 Nov 2011 00:25:26 -0800 (PST) Received: by 10.152.135.225 with SMTP id pv1mr11054833lab.19.1321950326782; Tue, 22 Nov 2011 00:25:26 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.41.198 with SMTP id h6cs166946lal; Tue, 22 Nov 2011 00:25:26 -0800 (PST) Received: by 10.213.10.11 with SMTP id n11mr591812ebn.20.1321950325198; Tue, 22 Nov 2011 00:25:25 -0800 (PST) Received: from eu1sys200aog112.obsmtp.com (eu1sys200aog112.obsmtp.com. [207.126.144.133]) by mx.google.com with SMTP id s50si2977032eeb.106.2011.11.22.00.25.15 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 Nov 2011 00:25:25 -0800 (PST) Received-SPF: neutral (google.com: 207.126.144.133 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) client-ip=207.126.144.133; Authentication-Results: mx.google.com; spf=neutral (google.com: 207.126.144.133 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) smtp.mail=linus.walleij@stericsson.com Received: from beta.dmz-us.st.com ([167.4.1.35]) (using TLSv1) by eu1sys200aob112.postini.com ([207.126.147.11]) with SMTP ID DSNKTstcay038v5Ss1zsim4ZSsD9OeGw0tmH@postini.com; Tue, 22 Nov 2011 08:25:25 UTC Received: from zeta.dmz-us.st.com (ns4.st.com [167.4.16.71]) by beta.dmz-us.st.com (STMicroelectronics) with ESMTP id 1332659; Tue, 22 Nov 2011 08:24:55 +0000 (GMT) Received: from relay2.stm.gmessaging.net (unknown [10.230.100.18]) by zeta.dmz-us.st.com (STMicroelectronics) with ESMTP id 9A77A58; Tue, 22 Nov 2011 08:14:11 +0000 (GMT) Received: from exdcvycastm003.EQ1STM.local (alteon-source-exch [10.230.100.61]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "exdcvycastm003", Issuer "exdcvycastm003" (not verified)) by relay2.stm.gmessaging.net (Postfix) with ESMTPS id 4748BA807D; Tue, 22 Nov 2011 09:24:53 +0100 (CET) Received: from localhost.localdomain (10.230.100.153) by smtp.stericsson.com (10.230.100.1) with Microsoft SMTP Server (TLS) id 8.3.83.0; Tue, 22 Nov 2011 09:24:56 +0100 From: Linus Walleij To: Grant Likely , Cc: , Viresh Kumar , Virupax Sadashivpetimath , Linus Walleij Subject: [PATCH 3/7] spi/pl022: skip default configuration before suspending Date: Tue, 22 Nov 2011 09:24:53 +0100 Message-ID: <1321950293-4749-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.3.2 MIME-Version: 1.0 From: Virupax Sadashivpetimath The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now. Signed-off-by: Virupax Sadashivpetimath Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Use local dev pointer instead of copy/paste bug &adev->dev --- drivers/spi/spi-pl022.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 0d0b165..b4038f9 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2310,11 +2310,6 @@ static int pl022_suspend(struct device *dev) return status; } - amba_vcore_enable(pl022->adev); - amba_pclk_enable(pl022->adev); - load_ssp_default_config(pl022); - amba_pclk_disable(pl022->adev); - amba_vcore_disable(pl022->adev); dev_dbg(dev, "suspended\n"); return 0; }