mbox series

[v2,0/5] This patch set did some clean up and add runtime pm support for flexspi driver

Message ID 20250424-flexspipatch-v2-0-e9eb643e2286@nxp.com
Headers show
Series This patch set did some clean up and add runtime pm support for flexspi driver | expand

Message

Bough Chen April 24, 2025, 7:33 a.m. UTC 
PATCH1/3/4 to clean up the code, make the code more readable
PATCH2 add the runtime pm support
PATCH5 use devm_add_action_or_reset() to replace remove() callback, this can avoid
       oops when do bind/unbind test

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
Changes in v2:
- only change the PATCH2, add #ifdef CONFIG_PM_SLEEP for nxp_fspi_suspend() to avoid build error
  if CONFIG_PM=n and CONFIG_PM_SLEEP=y, no change for all other patches.

- Link to v1: https://lore.kernel.org/r/20250423-flexspipatch-v1-0-292e530509d3@nxp.com

---
Haibo Chen (4):
      spi: spi-nxp-fspi: remove the goto in probe
      spi: spi-nxp-fspi: enable runtime pm for fspi
      spi: spi-nxp-fspi: use guard(mutex) to simplify the code
      spi: spi-nxp-fspi: remove the unchecked return value for nxp_fspi_clk_disable_unprep

Han Xu (1):
      spi: nxp-fspi: use devm instead of remove for driver detach

 drivers/spi/spi-nxp-fspi.c | 191 ++++++++++++++++++++++++++-------------------
 1 file changed, 111 insertions(+), 80 deletions(-)
---
base-commit: 2c9c612abeb38aab0e87d48496de6fd6daafb00b
change-id: 20250421-flexspipatch-1cf724d4213d

Best regards,

Comments

ALOK TIWARI April 25, 2025, 6:46 p.m. UTC | #1 
On 24-04-2025 13:03, Haibo Chen wrote:
> +	/* enable clock first since there is reigster access */

typo reigster

> +	pm_runtime_get_sync(f->dev);
> +
> +	/* disable the hardware */
> +	fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0);


Thanks,
Alok
Bough Chen April 28, 2025, 8:20 a.m. UTC | #2 
> -----Original Message-----
> From: ALOK TIWARI <alok.a.tiwari@oracle.com>
> Sent: 2025年4月26日 2:46
> To: Bough Chen <haibo.chen@nxp.com>; Han Xu <han.xu@nxp.com>; Yogesh
> Gaur <yogeshgaur.83@gmail.com>; Mark Brown <broonie@kernel.org>
> Cc: linux-spi@vger.kernel.org; imx@lists.linux.dev; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 5/5] spi: nxp-fspi: use devm instead of remove for driver
> detach
> 
> 
> 
> On 24-04-2025 13:03, Haibo Chen wrote:
> > +	/* enable clock first since there is reigster access */
> 
> typo register

Thanks, will fix in next version.

Regards
Haibo Chen
> 
> > +	pm_runtime_get_sync(f->dev);
> > +
> > +	/* disable the hardware */
> > +	fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0);
> 
> 
> Thanks,
> Alok