| Message ID | 20240823150057.56141-1-detlev.casanova@collabora.com |
|---|---|
| Headers | show |
| Series | Add device tree for ArmSoM Sige 5 board | expand |
On Fri, Aug 23, 2024 at 10:52:34AM -0400, Detlev Casanova wrote: > The device is compatible with rk3588, so add an entry for the 2 > compatibles together. > > The rk3576 device has a power-domain that needs to be on for the eMMC to > be used. Add it as a requirement. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > --- > .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 32 +++++++++++++------ > 1 file changed, 23 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > index 4d3031d9965f3..7d5e388587027 100644 > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > @@ -12,16 +12,29 @@ maintainers: > > allOf: > - $ref: mmc-controller.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3576-dwcmshc > + then: > + properties: > + power-domains: > + minItems: 1 Plaese move the allOf: after the required: block. It grows too much with such if:then: and that's not the most important part of binding we need to see first. With above change: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > It is compatible with the other rockchip SoCs. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Aug 23, 2024 at 12:07:10PM -0400, Detlev Casanova wrote: > It is compatible with the rockchip,rk3066-spi SPI core. Same comments... subject: spi: dt-bindings: Please use subject prefixes matching the subsystem. You can get them for example with on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > It is compatible with the other rockchip SoCs. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > index c7aab0418a320..b5a3dc3770706 100644 > --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > @@ -29,6 +29,7 @@ properties: > - rockchip,rk3368-wdt > - rockchip,rk3399-wdt > - rockchip,rk3568-wdt > + - rockchip,rk3576-wdt > - rockchip,rk3588-wdt > - rockchip,rv1108-wdt > - const: snps,dw-wdt > -- > 2.46.0 >
Hi Guenter, Am Samstag, 24. August 2024, 18:44:29 CEST schrieb Guenter Roeck: > On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > > It is compatible with the other rockchip SoCs. > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > Acked-by: Guenter Roeck <linux@roeck-us.net> For my understanding, does this Ack mean you expect the patch to go in with the other patches? Because in theory this patch could also be picked and go through the watchdog tree, similar to how the saradc binding went into the iio tree already. Thanks Heiko
On 8/27/24 00:20, Heiko Stübner wrote: > Hi Guenter, > > Am Samstag, 24. August 2024, 18:44:29 CEST schrieb Guenter Roeck: >> On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: >>> It is compatible with the other rockchip SoCs. >>> >>> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> >> >> Acked-by: Guenter Roeck <linux@roeck-us.net> > > For my understanding, does this Ack mean you expect the patch to go in > with the other patches? > Yes > Because in theory this patch could also be picked and go through the > watchdog tree, similar to how the saradc binding went into the > iio tree already. > I thought it was all supposed to be pushed together. Guenter
Hi Guenter, Am Dienstag, 27. August 2024, 21:38:35 CEST schrieb Guenter Roeck: > On 8/27/24 00:20, Heiko Stübner wrote: > > Am Samstag, 24. August 2024, 18:44:29 CEST schrieb Guenter Roeck: > >> On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > >>> It is compatible with the other rockchip SoCs. > >>> > >>> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > >> > >> Acked-by: Guenter Roeck <linux@roeck-us.net> > > > > For my understanding, does this Ack mean you expect the patch to go in > > with the other patches? > > > Yes > > > Because in theory this patch could also be picked and go through the > > watchdog tree, similar to how the saradc binding went into the > > iio tree already. > > > > I thought it was all supposed to be pushed together. I think at this point the rk3576 has still quite a number of separate pieces. A series for clocks, one for mmc and I think there are more. So for stuff that is obvious, like the saradc compatible Jonathan already, picked or this watchdog compatible, a strategy of "someone picks the individual" patch also is helpful, because it reduces the number of pieces on the "chess board" ;-) . So I guess both ways (wdt binding getting applied, or me just applying it with the rest) are doable and we'll just follow what you feel comfortable with doing. Heiko