mbox series

[v2,0/2] spi: fsl-dspi: A couple of error handling improvements

Message ID 20240204203127.1186621-1-andy.shevchenko@gmail.com
Headers show
Series spi: fsl-dspi: A couple of error handling improvements | expand

Message

Andy Shevchenko Feb. 4, 2024, 8:29 p.m. UTC
A couple of error handling improvements here:
- unshadowing error code from dmaengine_slave_config()
- making error messages uniform

In v2:
- split to two patches (Vladimir)
- improved commit message in the patch 2 (Vladimir)

Andy Shevchenko (2):
  spi: fsl-dspi: Preserve error code returned by
    dmaengine_slave_config()
  spi: fsl-dspi: Unify error messaging in dspi_request_dma()

 drivers/spi/spi-fsl-dspi.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

Comments

Vladimir Oltean Feb. 5, 2024, 11:11 a.m. UTC | #1
On Sun, Feb 04, 2024 at 10:29:18PM +0200, andy.shevchenko@gmail.com wrote:
> dmaengine_slave_config() may return different error codes based on
> the circumstances. Preserve it instead of shadowing to -EINVAL.
> 
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>