From patchwork Fri Aug 23 16:54:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 822123 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.86.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC1518E74C for ; Fri, 23 Aug 2024 16:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.86.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432092; cv=none; b=rTmECWAj9i6lhBEn9tkyyuzJ1M7YGwaGjQSGQ4bpqd52bcJ7+JjYJI17hYERGsOhfpWykxoa/TYNXwLEufr3PbYuGYvqOAvPLJApQnFfnmz1PFQBBog8UQPmuXY1pEf25aMEpCEWXTw3qIR10Zz+Y3lOoiDO8ga1uRfh2vfHfN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432092; c=relaxed/simple; bh=xlivHA5ql1it85zYsrc8TIQfQPV0ClIQCYh3/vL6HX4=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=CrZOLGVGfnwUVorAmj3Dmq8ELqiLQLknwr5zejS8uJLBphNsM1+whtvOoHw72g3n7HaUlQaij0hIpvZnhHTytlM/es2FAvz/zYW93ffp2zq46PdW1vYy1encTgWRdl9ymTByiaaAeMTSdb+A5UTybFw4fZnt57t/V/Nlp2/Rb/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=hIU5u7x3; arc=none smtp.client-ip=185.58.86.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="hIU5u7x3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1724432088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c728VZv6v7K8l+pge5+f5HkAlqnOFc8OqhDpJIZ4pus=; b=hIU5u7x3igji6eCBJ3fj1Pz7XUG7KpbrcmpF3ZdTIQ/3p8YRXe6kN5m571KBy/irvPZxPi SxYNunClqG7TzfUmS4Gm1GD8r2Mj4YWVtI1ZAKgUw0JhYsQLAjAUy+A0ynxMO/NP41kuiW CMBUJBMhDOYwLYldjOkyhX5CYEbmVk4= Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01lp2042.outbound.protection.outlook.com [104.47.85.42]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-235-iZ77_G1tN9CxZ2xa7eDk9g-1; Fri, 23 Aug 2024 17:54:47 +0100 X-MC-Unique: iZ77_G1tN9CxZ2xa7eDk9g-1 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) by CWLP123MB3105.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:5c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Fri, 23 Aug 2024 16:54:46 +0000 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567]) by LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567%5]) with mapi id 15.20.7897.014; Fri, 23 Aug 2024 16:54:46 +0000 Message-ID: <8314e995-6f7a-4e9e-98dd-8c424d25b854@camlingroup.com> Date: Fri, 23 Aug 2024 18:54:45 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants From: Lech Perczak To: linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko , =?utf-8?q?Krzysztof_Drobi=C5=84ski?= , =?utf-8?q?Pawe=C5=82_Lenkow?= , Kirill Yatsenko References: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> In-Reply-To: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> X-ClientProxiedBy: BEXP281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10::13) To LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO4P123MB5272:EE_|CWLP123MB3105:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dffcdac-b3c7-4202-e9a7-08dcc3944b4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016 X-Microsoft-Antispam-Message-Info: =?utf-8?q?B8+dlqZM1xYszWn8Y+eGrjsvmBINeaR?= =?utf-8?q?aLjKGpxEm5NPzibLpz1YrwmHhCpDADtQE+jC7MBbrKeVPs0K8q6IfeV1bt1u+S1xA?= =?utf-8?q?qrUX4CjJa1VG//1ZyI/Cd5EK2Dd/cOTlm5cLlPxGMyIsX2Qd9hWvCp7bmo+MbKuUE?= =?utf-8?q?/Fxp3OiGLty8g72BxzMXLvxBM6mRSFFSt/BBTFTKJP8qZdRnlArA7SgU2nRjWKg9Y?= =?utf-8?q?9nRVKGAITd9ENYYRamiWfXeci7tFESrX8kEW8Jgn2LoGibbtQjL3BllomMCnDHN2J?= =?utf-8?q?2bOmuMFa7aH+mmSadIvXBD6oBFYuZ5id+D7zlaFfnjmEqXS210bEhK4GI5AwNVm+z?= =?utf-8?q?ba+c+IMYMDAUQJzosTYziNndXPszAOlHC7sEXLhjGYWdExqpWz1iMv2iuecdK78AT?= =?utf-8?q?DE3ZWQPikRTpwzgd4UWt9JEaT7nGzRnThYeNKKL03cLjXvW8naWYXHp0q+MQDSSkf?= =?utf-8?q?TbXMoHqKvGZS0zAokS/YW9Bu44IquxP3qRZTVy3nJyOIduclW5BTK6mQx00xjL4gs?= =?utf-8?q?8l9TxZ4GOlzA1xcUZZCcW+0DXj9RdsvqO3DAIrT4oRzOoW3TVeqdYnAYy/QIm7DQh?= =?utf-8?q?ke9RSGPaio1NZbkdiqS8Qrbh+PxFarfDKvMtuh7p6Vxx8HBvY7FaPIuF1snE4OFUI?= =?utf-8?q?0zkl+lmz3TFI1SPOjozQvGreKsMld3Dt5AD31q7uUYAvQYdCONIinA6DXAlGxL9dP?= =?utf-8?q?0VmEDIKl0+XzNDjSDZ7DDRg5JSofOFtSeQ9hjDno+338Wtj+SudXujPYL1Ja8+XCE?= =?utf-8?q?6XbO+wlHQbcLuNhtL+ikZjsi1ULqmPtY1Q/tfERj2dKmIz2c5P2Omu+ccGi5QDM5s?= =?utf-8?q?+ZGF1zk2LIO4E6AWCi64PXcGFoRnZMmc6yxcyjdPs0aDvQTfcaL0IM4ivGUJA79Hk?= =?utf-8?q?eqW1IvRSO6vgZkYJEmyxanZfJydMUMWK3hXtwUz4coy6Gohv5WDKWV+InOKX87lz1?= =?utf-8?q?sX4jq0Tqskl2wVpfUWNRN1Gq09DlbvKqA8EoEv39ZkkGcrdugg22i6eevrmYpOkip?= =?utf-8?q?+bWDcQrVLNqnVb9dd4zUS+caWVlNzWig3dRq88rlQDMe+x0KWpsbt1T4fgO3kfkp4?= =?utf-8?q?9wRAXbKMg0JCiYDr/ZWmpghglaJP9rwk+nmzZ9bKtB+2KFFTtzWj0qzFAkZFCwpVI?= =?utf-8?q?RX+Su3qaN6p2kiYN+U4M6ZQRtrG3wI9XCoSklCEUhINzTtmvwpb6Uw2AuRNbxeCHr?= =?utf-8?q?wWkhlfnoxA0Stm/ssWzXuoQK4CTJ2ihi0zIoiwqJBgIcz5oQax4Z045NZa+QNtsWL?= =?utf-8?q?ZK+4MvSCZe2X2JYqzM2s1QEjokXlXmGWO3A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XgYLHK9ZYYfPvsO618T6F81Dl/Nz?= =?utf-8?q?e/Ki+AVp3n2KtQXRCpTM5bOGIggEbEOm07ODBV8TeUow5ueuxdAfnrSeXnERBYSnP?= =?utf-8?q?i2DjYrhGUClmZr7mGjggvL3Xg0xtEjujmccUFH1HVoq0a2B6mfXgEEHTkgyCJxRiP?= =?utf-8?q?tGBj4DkxZ9e0cAmvzpJakHAL8eXeWONvQpc3KvrljZlG2cLESDQ/DXtfdaGV7+XrT?= =?utf-8?q?MEzScs53MP4oZ2sh1pgsJLiJ24czC5G5xf06+9YP/hoRsYg0EVgCXlznQMJALljeF?= =?utf-8?q?AuCYWcM9nDtFkIWMnModmYe1e25KNKOX6YSRp1Sd41em0NCCH3uo4TikoaKrSiZRm?= =?utf-8?q?nMCEY4N+KpPWkxKnD92zUN6HqZdS+A71wuYzB9fqyVVveHzuIoL6+y+OzbPsVpZwz?= =?utf-8?q?4zcvc/CJqHl2+DiuOX2SV2/D6o4dQZ+C7jxocxOe+IllPJK1CT+dSMjy8/QKzDSZo?= =?utf-8?q?VK8vYqm8n01XR5H8fzfqF+v6vb0TQdK+Vy0SGcSouuycFUZ6uiRb73BbdiSqN78kd?= =?utf-8?q?bdCgEQXqJwEE0XSzBDO2yiSvtaU3jlSCSnOaT3J+ENLg5FJXmXqMDRagoThZx4zUX?= =?utf-8?q?RBP7grp58EV9byn5lv4lPkidSz1trrbvLxMI/BFPD+lVXJyCRPKIXvp6A6gPCjsC4?= =?utf-8?q?Nworl4PE6UN5wRWJ6RllxA2pE+cjWjqEscequQhJfNujVXdVP2kGDsI6aOJoT2EXL?= =?utf-8?q?mGsbwZXWgYqfh2LSfSnre07FNlFJmkKFmkXFx6f7hs6xAU//7Xt8Hhu/JJn1C3aWJ?= =?utf-8?q?U8BTVQwG+WjC8opoc1LBVDAXcEb2RtNKJwo508l+98RqZGH9f5OTxaiLoT0c/LHbQ?= =?utf-8?q?NsY/5ihDq7lg2Kj357R/6EZj5RZRg1D1HZxa3LBWMo4+seZHRWcgWoJtDcT9RGzRu?= =?utf-8?q?ZymNmZ0WiS2ZXHICD6+ZDCzwgq3qlsUkApCri4352Ul65+b0CsaFFjwXnaVYi4HqT?= =?utf-8?q?KalxOODvByPdk5Iyy9ukhLM4bwlnMxVt+Qr7kVzoHVeKG7au4sxjefC5T0z33GrGw?= =?utf-8?q?5PUElxkuA3By8uo4J1jEgKbQO9bdaH76MfGFYi9Jnu8ulO+g6em7TexGVfACQeMX4?= =?utf-8?q?Lq0e11GdMUfba3z1oBEeVqd32ciImLXUpVyCDyoICOdWIDAJQ/kY6Wynt9jo3+80u?= =?utf-8?q?6Q6YQW1XF9Y05RF87lKmrI/a9WlZ7pFrWTCp2HFS2kSBPWWx2jXDK/14HmqGU1F4L?= =?utf-8?q?vwTKlkbw7HRUj1Ft4II3yTKPHK3Fivxrcw8wzHLIYPbiTsD3/onelBqU43D5XiUhr?= =?utf-8?q?axAUK8HioENXSgRAii7jGIdoCraGmBk8T6J1x4CkhGEdB+7GnJtp0KTgS0u07mpJz?= =?utf-8?q?craZYZ+5fhvZ4EnVlCJ/tkDtHbUVeVgh4OZ3eCvOE/jX0u54j5/ahcttkk4Z9W+Fe?= =?utf-8?q?GmdGntQW3JFDDJuK0Fb5oVCycl/sA57IlBjnSHytoN4OAtGTvK1ZzNZmPIyldrC+M?= =?utf-8?q?m/10ZJmxjTEsWSozsOPKarB0XzQVGOYHh9McbVnVdN1qInBMsYYN9UWMl0c5Y98pr?= =?utf-8?q?MxqHG/7tEI9wNbJ2UlGapJNAS64+QtlwWtwlvCsXRFJN8SKNLZhSOyqc3pThLZ8tZ?= =?utf-8?q?Y2c30bG4rB3tijDwjAZeoxReXtC1xOWZA=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dffcdac-b3c7-4202-e9a7-08dcc3944b4a X-MS-Exchange-CrossTenant-AuthSource: LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 16:54:46.6601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cLBwOgcMQcNO2w3ITjaVi2jn/6qgOUaErsnt/Of2s56Eh7cZCRyuQT0V2KW2fkQ4GxLfSBOPwGsVX+1YlzbW4Ks1dLBQ07hy7v3oPkd1k1g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB3105 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3, which don't match the datasheet - fix them. At the same time remove comments for individual constants, as they add nothing to the definitions themselves. Signed-off-by: Lech Perczak --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 8a2020f9930e..36b7c682ae94 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -266,9 +266,9 @@ * and writing to IER[7:4], * FCR[5:4], MCR[7:5] */ -#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) /* SWFLOW bit 3 */ -#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) /* SWFLOW bit 2 - * +#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) +#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) + /* * SWFLOW bits 3 & 2 table: * 00 -> no transmitter flow * control @@ -280,10 +280,10 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 2 */ -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 3 - * - * SWFLOW bits 3 & 2 table: +#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) +#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) + /* + * SWFLOW bits 1 & 0 table: * 00 -> no received flow * control * 01 -> receiver compares