diff mbox series

[v2,1/2] dt-bindings: serial: sc16is7xx: add reset-gpios

Message ID 20240604132726.1272475-1-hui.wang@canonical.com
State Superseded
Headers show
Series [v2,1/2] dt-bindings: serial: sc16is7xx: add reset-gpios | expand

Commit Message

Hui Wang June 4, 2024, 1:27 p.m. UTC 
In some designs, the chip reset pin is connected to a gpio, this
gpio needs to be set correctly before probing the driver, so adding
a reset-gpios in the device tree.

Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
In the v2:
 - include the gpio.h
 - run the 'make dt_binding_check' and 'make dtbs_check'

 Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Hui Wang June 5, 2024, 6:07 a.m. UTC | #1 
On 6/4/24 21:29, Krzysztof Kozlowski wrote:
> On 04/06/2024 15:27, Hui Wang wrote:
>> In some designs, the chip reset pin is connected to a gpio, this
>> gpio needs to be set correctly before probing the driver, so adding
>> a reset-gpios in the device tree.
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Where did these happen?!?!?
>
> NAK
>
> Please talk with your colleagues in Canonical to explain how this works.
> Then read submitting patches document.

Sorry, my bad, I will read submitting-pathces.rst carefully.

Thanks,

Hui.

>
> Best regards,
> Krzysztof
>
Hui Wang June 5, 2024, 6:34 a.m. UTC | #2 
On 6/4/24 22:35, Hugo Villeneuve wrote:
> On Tue,  4 Jun 2024 21:27:25 +0800
> Hui Wang <hui.wang@canonical.com> wrote:
>
>> In some designs, the chip reset pin is connected to a gpio, this
> "and this ..."
>
>> gpio needs to be set correctly before probing the driver, so adding
> "so add ..."
>
>
OK, will fix them in the v3.

Thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
index 5dec15b7e7c3..88871480018e 100644
--- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
+++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
@@ -28,6 +28,9 @@  properties:
   clocks:
     maxItems: 1
 
+  reset-gpios:
+    maxItems: 1
+
   clock-frequency:
     description:
       When there is no clock provider visible to the platform, this
@@ -91,6 +94,7 @@  unevaluatedProperties: false
 examples:
   - |
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/gpio/gpio.h>
     i2c {
         #address-cells = <1>;
         #size-cells = <0>;
@@ -120,6 +124,7 @@  examples:
             compatible = "nxp,sc16is752";
             reg = <0x54>;
             clocks = <&clk20m>;
+            reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
             interrupt-parent = <&gpio3>;
             interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
             nxp,modem-control-line-ports = <0 1>; /* Ports 0 and 1 as modem control lines */