| Message ID | 20230705181833.16137-2-ddrokosov@sberdevices.ru |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tty: serial: meson: support ttyS devname | expand |
On 05/07/2023 20:18, Dmitry Rokosov wrote: > Use dev_err_probe() helper for error checking and standard logging. > It makes the driver's probe() function a little bit shorter. > > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru> > --- > drivers/tty/serial/meson_uart.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 2501db5a7aaf..bca54f3d92a1 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -726,8 +726,8 @@ static int meson_uart_probe(struct platform_device *pdev) > of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); > > if (meson_ports[pdev->id]) { > - dev_err(&pdev->dev, "port %d already allocated\n", pdev->id); > - return -EBUSY; > + return dev_err_probe(&pdev->dev, -EBUSY, > + "port %d already allocated\n", pdev->id); > } > > port = devm_kzalloc(&pdev->dev, sizeof(struct uart_port), GFP_KERNEL); Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c index 2501db5a7aaf..bca54f3d92a1 100644 --- a/drivers/tty/serial/meson_uart.c +++ b/drivers/tty/serial/meson_uart.c @@ -726,8 +726,8 @@ static int meson_uart_probe(struct platform_device *pdev) of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); if (meson_ports[pdev->id]) { - dev_err(&pdev->dev, "port %d already allocated\n", pdev->id); - return -EBUSY; + return dev_err_probe(&pdev->dev, -EBUSY, + "port %d already allocated\n", pdev->id); } port = devm_kzalloc(&pdev->dev, sizeof(struct uart_port), GFP_KERNEL);
Use dev_err_probe() helper for error checking and standard logging. It makes the driver's probe() function a little bit shorter. Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru> --- drivers/tty/serial/meson_uart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)