| Message ID | 20230425102418.185783-6-ychuang570808@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce Nuvoton ma35d1 SoC | expand |
On Tue, 25 Apr 2023 10:24:12 +0000, Jacky Huang wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'. > Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add > bindings for ARMv8-based Nuvoton SoCs and platform boards, and include > the initial bindings for ma35d1 series development boards. > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> > --- > .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++ > .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +- > .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +- > 3 files changed, 32 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml > rename Documentation/devicetree/bindings/arm/{npcm/npcm.yaml => nuvoton/nuvoton,npcm.yaml} (93%) > rename Documentation/devicetree/bindings/{arm/npcm/nuvoton,gcr.yaml => soc/nuvoton/nuvoton,npcm-gcr.yaml} (93%) > Reviewed-by: Rob Herring <robh@kernel.org>
On 25/04/2023 12:24, Jacky Huang wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'. > Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add > bindings for ARMv8-based Nuvoton SoCs and platform boards, and include > the initial bindings for ma35d1 series development boards. > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> > --- > .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++ > .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +- > .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +- > 3 files changed, 32 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml I don't see any improvements here. Path in maintainers is still broken. Best regards, Krzysztof
Dear Krzysztof, On 2023/5/1 下午 05:50, Krzysztof Kozlowski wrote: > On 25/04/2023 12:24, Jacky Huang wrote: >> From: Jacky Huang <ychuang3@nuvoton.com> >> >> Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'. >> Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add >> bindings for ARMv8-based Nuvoton SoCs and platform boards, and include >> the initial bindings for ma35d1 series development boards. >> >> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >> --- >> .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++ >> .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +- >> .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +- >> 3 files changed, 32 insertions(+), 2 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml > I don't see any improvements here. Path in maintainers is still broken. > > Best regards, > Krzysztof > Does this line cover 'Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml'? ==> F: Documentation/devicetree/bindings/*/*/*ma35* I ran 'get_maintainer.pl' on this patch, and it was able to find maintainers and looked good. I also ran 'make htmldocs' and did not see any warnings or errors related to the .yaml files in this patch. However, I am still unsure where the problem lies. Can you suggest any tools I can use to check for errors? I would greatly appreciate any guidance you can provide. Best Regards, Jacky Huang
On 02/05/2023 03:31, Jacky Huang wrote: > Dear Krzysztof, > > > On 2023/5/1 下午 05:50, Krzysztof Kozlowski wrote: >> On 25/04/2023 12:24, Jacky Huang wrote: >>> From: Jacky Huang <ychuang3@nuvoton.com> >>> >>> Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'. >>> Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add >>> bindings for ARMv8-based Nuvoton SoCs and platform boards, and include >>> the initial bindings for ma35d1 series development boards. >>> >>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >>> --- >>> .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++ >>> .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +- >>> .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +- >>> 3 files changed, 32 insertions(+), 2 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml >> I don't see any improvements here. Path in maintainers is still broken. >> >> Best regards, >> Krzysztof >> > > Does this line cover > 'Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml'? > ==> F: Documentation/devicetree/bindings/*/*/*ma35* > > I ran 'get_maintainer.pl' on this patch, and it was able to find > maintainers and looked good. > I also ran 'make htmldocs' and did not see any warnings or errors > related to the .yaml files > in this patch. However, I am still unsure where the problem lies. Can > you suggest any > tools I can use to check for errors? I would greatly appreciate any > guidance you can provide. Apply the patches 1 to 5 and then check if all paths from maintainers are correct. I believe the path Documentation/devicetree/bindings/arm/npcm/ is not. I think I told the same last time with explanation that this patch must correct path. Best regards, Krzysztof
Dear Krzysztof, On 2023/5/2 下午 02:31, Krzysztof Kozlowski wrote: > On 02/05/2023 03:31, Jacky Huang wrote: >> Dear Krzysztof, >> >> >> On 2023/5/1 下午 05:50, Krzysztof Kozlowski wrote: >>> On 25/04/2023 12:24, Jacky Huang wrote: >>>> From: Jacky Huang <ychuang3@nuvoton.com> >>>> >>>> Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'. >>>> Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add >>>> bindings for ARMv8-based Nuvoton SoCs and platform boards, and include >>>> the initial bindings for ma35d1 series development boards. >>>> >>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >>>> --- >>>> .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++ >>>> .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +- >>>> .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +- >>>> 3 files changed, 32 insertions(+), 2 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml >>> I don't see any improvements here. Path in maintainers is still broken. >>> >>> Best regards, >>> Krzysztof >>> >> Does this line cover >> 'Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml'? >> ==> F: Documentation/devicetree/bindings/*/*/*ma35* >> >> I ran 'get_maintainer.pl' on this patch, and it was able to find >> maintainers and looked good. >> I also ran 'make htmldocs' and did not see any warnings or errors >> related to the .yaml files >> in this patch. However, I am still unsure where the problem lies. Can >> you suggest any >> tools I can use to check for errors? I would greatly appreciate any >> guidance you can provide. > Apply the patches 1 to 5 and then check if all paths from maintainers > are correct. I believe the path > Documentation/devicetree/bindings/arm/npcm/ is not. > > I think I told the same last time with explanation that this patch must > correct path. > > Best regards, > Krzysztof > Okay, I think I should combine the patch 11 (for MAINTAINER) into patch 5. Best Regards, Jacky Huang
On 02/05/2023 08:40, Jacky Huang wrote: > > Dear Krzysztof, > > > > On 2023/5/2 下午 02:31, Krzysztof Kozlowski wrote: >> On 02/05/2023 03:31, Jacky Huang wrote: >>> Dear Krzysztof, >>> >>> >>> On 2023/5/1 下午 05:50, Krzysztof Kozlowski wrote: >>>> On 25/04/2023 12:24, Jacky Huang wrote: >>>>> From: Jacky Huang <ychuang3@nuvoton.com> >>>>> >>>>> Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'. >>>>> Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add >>>>> bindings for ARMv8-based Nuvoton SoCs and platform boards, and include >>>>> the initial bindings for ma35d1 series development boards. >>>>> >>>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >>>>> --- >>>>> .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++ >>>>> .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +- >>>>> .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +- >>>>> 3 files changed, 32 insertions(+), 2 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml >>>> I don't see any improvements here. Path in maintainers is still broken. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> Does this line cover >>> 'Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml'? >>> ==> F: Documentation/devicetree/bindings/*/*/*ma35* >>> >>> I ran 'get_maintainer.pl' on this patch, and it was able to find >>> maintainers and looked good. >>> I also ran 'make htmldocs' and did not see any warnings or errors >>> related to the .yaml files >>> in this patch. However, I am still unsure where the problem lies. Can >>> you suggest any >>> tools I can use to check for errors? I would greatly appreciate any >>> guidance you can provide. >> Apply the patches 1 to 5 and then check if all paths from maintainers >> are correct. I believe the path >> Documentation/devicetree/bindings/arm/npcm/ is not. >> >> I think I told the same last time with explanation that this patch must >> correct path. >> >> Best regards, >> Krzysztof >> > > Okay, I think I should combine the patch 11 (for MAINTAINER) into patch 5. I don't know what's there. The path which is changed (invalidated) here, should be updated here. Best regards, Krzysztof
Dear Krzysztof, On 2023/5/2 下午 02:46, Krzysztof Kozlowski wrote: > On 02/05/2023 08:40, Jacky Huang wrote: >> Dear Krzysztof, >> >> >> >> On 2023/5/2 下午 02:31, Krzysztof Kozlowski wrote: >>> On 02/05/2023 03:31, Jacky Huang wrote: >>>> Dear Krzysztof, >>>> >>>> >>>> On 2023/5/1 下午 05:50, Krzysztof Kozlowski wrote: >>>>> On 25/04/2023 12:24, Jacky Huang wrote: >>>>>> From: Jacky Huang <ychuang3@nuvoton.com> >>>>>> >>>>>> Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'. >>>>>> Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add >>>>>> bindings for ARMv8-based Nuvoton SoCs and platform boards, and include >>>>>> the initial bindings for ma35d1 series development boards. >>>>>> >>>>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >>>>>> --- >>>>>> .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++ >>>>>> .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +- >>>>>> .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +- >>>>>> 3 files changed, 32 insertions(+), 2 deletions(-) >>>>>> create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml >>>>> I don't see any improvements here. Path in maintainers is still broken. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> Does this line cover >>>> 'Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml'? >>>> ==> F: Documentation/devicetree/bindings/*/*/*ma35* >>>> >>>> I ran 'get_maintainer.pl' on this patch, and it was able to find >>>> maintainers and looked good. >>>> I also ran 'make htmldocs' and did not see any warnings or errors >>>> related to the .yaml files >>>> in this patch. However, I am still unsure where the problem lies. Can >>>> you suggest any >>>> tools I can use to check for errors? I would greatly appreciate any >>>> guidance you can provide. >>> Apply the patches 1 to 5 and then check if all paths from maintainers >>> are correct. I believe the path >>> Documentation/devicetree/bindings/arm/npcm/ is not. >>> >>> I think I told the same last time with explanation that this patch must >>> correct path. >>> >>> Best regards, >>> Krzysztof >>> >> Okay, I think I should combine the patch 11 (for MAINTAINER) into patch 5. > I don't know what's there. The path which is changed (invalidated) here, > should be updated here. > > Best regards, > Krzysztof > I got it and learn the rule. Thank you very much. I will fix it. Best Regards, Jacky Huang
diff --git a/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml new file mode 100644 index 000000000000..fb190db61525 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml @@ -0,0 +1,30 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/nuvoton/nuvoton,ma35d1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton MA35 series SoC based platforms + +maintainers: + - Jacky Huang <ychuang3@nuvoton.com> + +description: | + Boards with an ARMv8 based Nuvoton MA35 series SoC shall have + the following properties. + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: MA35D1 based boards + items: + - enum: + - nuvoton,ma35d1-iot + - nuvoton,ma35d1-som + - const: nuvoton,ma35d1 + +additionalProperties: true +... diff --git a/Documentation/devicetree/bindings/arm/npcm/npcm.yaml b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm.yaml similarity index 93% rename from Documentation/devicetree/bindings/arm/npcm/npcm.yaml rename to Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm.yaml index 6871483947c5..d386744c8815 100644 --- a/Documentation/devicetree/bindings/arm/npcm/npcm.yaml +++ b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 --- -$id: http://devicetree.org/schemas/arm/npcm/npcm.yaml# +$id: http://devicetree.org/schemas/arm/nuvoton/nuvoton,npcm.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: NPCM Platforms diff --git a/Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-gcr.yaml similarity index 93% rename from Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml rename to Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-gcr.yaml index 94e72f25b331..23e7e4ea01ff 100644 --- a/Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml +++ b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-gcr.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 --- -$id: http://devicetree.org/schemas/arm/npcm/nuvoton,gcr.yaml# +$id: http://devicetree.org/schemas/soc/nuvoton/nuvoton,npcm-gcr.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: Global Control Registers block in Nuvoton SoCs