From patchwork Sun Feb 26 05:39:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 658075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43487C7EE33 for ; Sun, 26 Feb 2023 05:40:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbjBZFkA (ORCPT ); Sun, 26 Feb 2023 00:40:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbjBZFj7 (ORCPT ); Sun, 26 Feb 2023 00:39:59 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF6B8136E9; Sat, 25 Feb 2023 21:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=cSNByO9fFLUH/bsd79G915kzP5bO5cbyzpjf2Z+gFkk=; b=Wc+ujKzBtm+iV66xOvUoAUGW1r emDMt3GkBYnW0zXqvn/HmExzeY6gQDdMGhpcFu4c8lxCp3UQHRmYnYPxdl+RiiEWrmwdVJtoDo8ic 2AJ2rMwrf3jXoLafx9hsLP7nJOHL5h2VmuUqb2XpeE8cJwkdWo/k3V+LmYLOkDow6LK+ly4VEI3/q JMbwUBLaJhg3VGoL+4IAzrZukTKM3QBl2T00aO8Cu5bYdy2744qx2geTxx22LnV3UAjkaUVdk4buX TApEbcGYagRdqgIdrXjnnjZAknRduFfiREeJpas6LHqLXhXECpCapPST1GWw0NdCcXTOg7A3zGYMc Jps0jjIw==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pW9lO-006qYL-6D; Sun, 26 Feb 2023 05:39:58 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Greg Kroah-Hartman , Oskar Senft , linux-serial@vger.kernel.org Subject: [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it Date: Sat, 25 Feb 2023 21:39:53 -0800 Message-Id: <20230226053953.4681-9-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230226053953.4681-1-rdunlap@infradead.org> References: <20230226053953.4681-1-rdunlap@infradead.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 8d310c9107a2 ("drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable") Signed-off-by: Randy Dunlap Cc: Greg Kroah-Hartman Cc: Oskar Senft Cc: linux-serial@vger.kernel.org --- drivers/tty/serial/8250/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -257,8 +257,9 @@ config SERIAL_8250_ASPEED_VUART tristate "Aspeed Virtual UART" depends on SERIAL_8250 depends on OF - depends on REGMAP && MFD_SYSCON + depends on MFD_SYSCON depends on ARCH_ASPEED || COMPILE_TEST + select REGMAP help If you want to use the virtual UART (VUART) device on Aspeed BMC platforms, enable this option. This enables the 16550A-