| Message ID | 20221118224540.619276-572-uwe@kleine-koenig.org |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: Complete conversion to i2c_probe_new | expand |
Hello Jiri, On Wed, Nov 23, 2022 at 07:36:52AM +0100, Jiri Slaby wrote: > On 21. 11. 22, 8:07, Uwe Kleine-König wrote: > > On Mon, Nov 21, 2022 at 07:03:41AM +0100, Jiri Slaby wrote: > > > On 18. 11. 22, 23:45, Uwe Kleine-König wrote: > > > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > > > > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > > > > that explicitly in the probe function. > > > > > > I wonder why -- is this a new approach to probe functions? Or is only i2c > > > affected? And why? Could you point to the commit introducing and describing > > > the change in the i2c core? > > > > I didn't sent the cover letter to all recipents of the individual > > patches, so flow of information is a bit rough. Sorry about that. > > > > You can find it at > > https://lore.kernel.org/lkml/20221118224540.619276-1-uwe@kleine-koenig.org/, > > it should answer your question. > > Yes, I looked up that beforehand, but was no more clever after reading it. > > > The short version is: The i2c framework does a more or less expensive > > lookup for each call to .probe() to provide the id parameter. A relevant > > part of the drivers however doesn't use this parameter, so the idea is > > to let the drivers who actually need it, determine it themselves. > > > > Statistics for the current state of this series in my tree: > > Among the 602 converted drivers, 404 don't make use of the parameter. > > So doesn't it make sense to provide both probe with no id and "probe_id" > then? 200 is quite a few (a third to be precise). Having the probe callback with the id parameter is only temporary. As soon as all drivers are converted, the variant with the id parameter will go away. > BTW is this a performance issue? I.e. does it slow down the boot? I don't know the start motivation for Lee (who triggered the conversion in b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type")). Looking at the git history, he created 1e98dcd77970 ("mfd: 88pm860x: Move over to new I2C device .probe() call") converting a driver that doesn't benefit immensely. The lookup is more expensive for drivers with big .id_table, the converted driver has only one entry. I think in the end is a mixture between: - A big part of the drivers doesn't benefit from the lookup. - For most other busses the probe function only gets a device parameter and no id (spi, platform, i3c). There are counter examples though: amba, usb. Didn't check further. Best regards Uwe
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 39f92eb1e698..8412b25eac86 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1665,9 +1665,9 @@ MODULE_ALIAS("spi:sc16is7xx"); #endif #ifdef CONFIG_SERIAL_SC16IS7XX_I2C -static int sc16is7xx_i2c_probe(struct i2c_client *i2c, - const struct i2c_device_id *id) +static int sc16is7xx_i2c_probe(struct i2c_client *i2c) { + const struct i2c_device_id *id = i2c_client_get_device_id(i2c); const struct sc16is7xx_devtype *devtype; struct regmap *regmap; @@ -1708,7 +1708,7 @@ static struct i2c_driver sc16is7xx_i2c_uart_driver = { .name = SC16IS7XX_NAME, .of_match_table = sc16is7xx_dt_ids, }, - .probe = sc16is7xx_i2c_probe, + .probe_new = sc16is7xx_i2c_probe, .remove = sc16is7xx_i2c_remove, .id_table = sc16is7xx_i2c_id_table, };