From patchwork Sun Feb 13 19:39:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 542480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78195C433F5 for ; Sun, 13 Feb 2022 19:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237526AbiBMTjN (ORCPT ); Sun, 13 Feb 2022 14:39:13 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbiBMTjN (ORCPT ); Sun, 13 Feb 2022 14:39:13 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07D5656C2B; Sun, 13 Feb 2022 11:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=8wk56JhGdlcQBk1SHLgauEyhCZzPUCKrQNT4Qxie6hE=; b=ev09HBmSkOOsf26kNFWf+6MwSk V62iWgjf/5ysgMK4blcPc2MzS4uajHZkzlUU5OZ+bg2rrGEJz0QiqDjVhMQZBG++aFeH3PdGz9q5+ CpTj8flarf+LVqKqeAfCrhTVUAMaWlmzpZB8j2yvCfhqCh2QRrSZO8LHfJK82fukecGpgrfXSdz4v UU1ER9woszomIWKMQybecMQgVOMv/O8f4ekrGpJsahWDepfMEpo7Qb6Ivi5upjLOar8WJjvjzBeob 8JWskmvQPoHTwrlVq2ZpS3uzfM7EC3WjgI+Um/kZpvQRw2vtrrefJFPAQFLp7YqjM2hwTNkF2RvBk +yowOS6g==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJKi8-00CO3h-PL; Sun, 13 Feb 2022 19:39:04 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Greg Kroah-Hartman , linux-serial@vger.kernel.org, Jiri Slaby , Johan Hovold Subject: [PATCH] serial: parisc: GSC: fix build when PCI_LBA is not set Date: Sun, 13 Feb 2022 11:39:03 -0800 Message-Id: <20220213193903.8815-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org There is a build error when using a kernel .config file from 'kernel test robot' for a different build problem: hppa64-linux-ld: drivers/tty/serial/8250/8250_gsc.o: in function `.LC3': (.data.rel.ro+0x18): undefined reference to `iosapic_serial_irq' when: CONFIG_GSC=y CONFIG_SERIO_GSCPS2=y CONFIG_SERIAL_8250_GSC=y CONFIG_PCI is not set and hence PCI_LBA is not set. IOSAPIC depends on PCI_LBA, so IOSAPIC is not set/enabled. Making SERIAL_8250_GSC depend on PCI_LBA prevents the build error. Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-parisc@vger.kernel.org Cc: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org Cc: Jiri Slaby Cc: Johan Hovold --- drivers/tty/serial/8250/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20220211.orig/drivers/tty/serial/8250/Kconfig +++ linux-next-20220211/drivers/tty/serial/8250/Kconfig @@ -118,7 +118,7 @@ config SERIAL_8250_CONSOLE config SERIAL_8250_GSC tristate - depends on SERIAL_8250 && GSC + depends on SERIAL_8250 && GSC && PCI_LBA default SERIAL_8250 config SERIAL_8250_DMA